Page MenuHomePhabricator

Uncaught ReferenceError: cbnnr is not defined
Closed, ResolvedPublic

Description

Impact: banner doesn't display, error is thrown

Volume: 22,438 errors per 24hrs (note we call UBN on errors over 1000)

https://logstash.wikimedia.org/goto/13d2bf0e26ba4399a9b1dedbac0e49d3

Applies to logged in users (Luckily I caught this one as I have a special user script alerting me to such errors):

Event Timeline

Jdlrobson renamed this task from Banner error to Banner error cbnnr is not defined.EditedDec 9 2020, 12:00 AM
Jdlrobson triaged this task as Unbreak Now! priority.

Huge spike in error logs starting today. Cannot find any reference to this variable in code or gadgets and given amount of projects impacted feels like a global banner campaign. Nothing displays.

Jdlrobson renamed this task from Banner error cbnnr is not defined to Uncaught ReferenceError: cbnnr is not defined.Dec 9 2020, 2:56 AM
Jdlrobson updated the task description. (Show Details)

This was due to the banner CommunityWishlistVote_Mobile. Fixed with this change. Pinging @Trizek-WMF FYI

Also @Seddon: What's the best tag for non-fundraising CentralNotice banner issues?

Pcoombe claimed this task.

No more logstash errors since the fix, closing this.

Ramtin0071 lowered the priority of this task from Unbreak Now! to High.Dec 9 2020, 1:46 PM
Ramtin0071 reassigned this task from Pcoombe to Alexia.
DannyS712 raised the priority of this task from High to Unbreak Now!.
DannyS712 removed a subscriber: Alexia.
DannyS712 added a subscriber: DannyS712.

...oh wait, it was resolved before they reopened it, sorry

DannyS712 closed this task as Resolved.

@Pcoombe thanks for the fix!

is there a way we can change the banner process for deploying banners to make sure logstash is checked for new errors?

I'm also happy to jump in and fix some errors if you have time to get me up to speed on how and help me get the relevant permissions.