| Jdlrobson | |
| Dec 8 2020, 11:58 PM |
| F33940323: Screen Shot 2020-12-08 at 6.52.35 PM.png | |
| Dec 9 2020, 2:56 AM |
| F33940242: Screenshot_20201208-155651_Chrome.jpg | |
| Dec 8 2020, 11:58 PM |
Impact: banner doesn't display, error is thrown
Volume: 22,438 errors per 24hrs (note we call UBN on errors over 1000)
https://logstash.wikimedia.org/goto/13d2bf0e26ba4399a9b1dedbac0e49d3
Applies to logged in users (Luckily I caught this one as I have a special user script alerting me to such errors):
Huge spike in error logs starting today. Cannot find any reference to this variable in code or gadgets and given amount of projects impacted feels like a global banner campaign. Nothing displays.
This was due to the banner CommunityWishlistVote_Mobile. Fixed with this change. Pinging @Trizek-WMF FYI
Also @Seddon: What's the best tag for non-fundraising CentralNotice banner issues?
@Pcoombe thanks for the fix!
is there a way we can change the banner process for deploying banners to make sure logstash is checked for new errors?
I'm also happy to jump in and fix some errors if you have time to get me up to speed on how and help me get the relevant permissions.
@Jdlrobson, are you volunteering to transform the JS hack we use into a CentralNotice feature? :)
T269758: Provide a way to display of a banner only to users who reach a certain number of edits