Page MenuHomePhabricator
Create Task
Maniphest T269860

Transcluding {{Special:ListFiles/$username}} on any page overrides the skin selected by the viewer in Preferences, makes it Vector-only
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to reproduce:

  1. Make sure you use a skin other than Vector in Special:Preferences (I use MonoBook)
  2. Go to any page, transclude {{Special:ListFiles/$username}} (it can be yours or other user name)
  3. Save

Actual results:
After transcluding that special page, the page is displayed using Vector skin only regardless of the MediaWiki skin you set in Preferences.

Examples: https://meta.wikimedia.org/w/index.php?title=Meta:Sandbox&oldid=20784096

Expected results:
User skin unnafected when transcluding that page.

Software:

  • MediaWiki 1.36.0-wmf.21 (rMW0d99fe6d5442).
  • Tested on enwiki and metawiki.

Other info:
Cache-purging didn't fix the issue.

Related Objects

Event Timeline

MarcoAurelio created this task.Dec 10 2020, 3:41 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 10 2020, 3:41 PM
Base subscribed.Dec 10 2020, 3:46 PM

&useskin is also ignored it seems.

Mainframe98 subscribed.Dec 10 2020, 3:54 PM
MarcoAurelio changed the subtype of this task from "Task" to "Bug Report".Dec 10 2020, 4:12 PM
MarcoAurelio added a project: Beta-Cluster-reproducible.Dec 10 2020, 5:15 PM

I can reproduce this bug on the Beta Cluster.

DannyS712 subscribed.EditedDec 10 2020, 6:58 PM

This doesn't, however, affect directing viewing https://meta.wikimedia.org/wiki/Special:ListFiles/DannyS712?useskin=modern
It also doesn't affect all includable special pages (tested against Special:Allpages on meta)
I have not looked into this enough, but I would guess that the code in Parser::braceSubstitution that handles special pages, specifically setting the context user for cached pages to User::newFromName( '127.0.0.1', false ), results in always having a user with the default skin be used for executing the included special page, and that that leaks into the outer scope of the parser's output

Ammarpad merged a task: T270802: Pages transcluding Special:PrefixIndex are displayed in Legacy Vector.Feb 10 2021, 1:59 PM
Ammarpad added subscribers: sgrabarczuk, Ammarpad, ovasileva, Honjitsu-Seiten.
Ammarpad mentioned this in T270802: Pages transcluding Special:PrefixIndex are displayed in Legacy Vector.Feb 10 2021, 2:16 PM
HirnSpuk subscribed.Apr 25 2021, 11:37 AM

Hi, I just discovered, that this also seems to happen when transcluding Special:recentchanges. Another thing: It doesn't happen consistently, sometimes (really rarely) it works, but I wasn't able to figure out, on what occasions. I'm working on de.wikibooks.org with firefox 87, Linux. Hope I'm in the right spot and this helps somehow. Regards

ExE-Boss subscribed.Jul 6 2021, 3:47 PM
Honjitsu-Seiten added a comment.Nov 27 2021, 1:26 PM

This bug seem to be fixed.

Aklapper closed this task as Resolved.Dec 6 2021, 9:44 PM

Closing per last comment.

Jdlrobson mentioned this in T336504: Transcluding Special:Prefixindex can force the default skin.May 11 2023, 5:42 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL