Stop accessing global config variable from SpecialSecurePoll (OT)
Closed, ResolvedPublic2 Estimated Story PointsJan 12 2021
Actions

Assigned To

Authored By

	Tchanders
	Dec 21 2020, 7:32 PM

Project Tags

Referenced Files

None

Subscribers

Aklapper

STran

Tchanders

Description

See T71084 for the motivation behind this work.

SpecialSecurePoll accesses a global config variable directly.

Instead it can make use of SpecialPage::getConfig and call:

$this->getConfig()->get( 'ExtensionAssetsPath' );

Details

Due Date: Jan 12 2021, 5:00 AM

Related Changes in Gerrit:

	Subject	Author	Repo	Branch	Lines +/-
	Remove global var from SpecialSecurePoll.php	Wikitrent	mediawiki/extensions/SecurePoll	master	+2 -2

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Declined		TTO	T16264 Import sources should be maintained by stewards
Resolved		None	T46294 MWException error - Error: invalid magic word 'speciale'
Open	Feature	None	T28992 Implement configuration database aka configuration management aka no shell excuse
Open		None	T11968 Reduce use of global and public variables
Open		None	T294739 remove configuration access via global variables in core
Open		None	T71084 Convert things to use Config classes instead of globals
In Progress		Mimurawil	T270646 Use Config instead of globals in SecurePoll extension
Resolved	Jan 12 2021	• wikitrent	T270642 Stop accessing global config variable from SpecialSecurePoll (OT)

Event Timeline

Tchanders created this task.Dec 21 2020, 7:32 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 21 2020, 7:32 PM

Tchanders added a parent task: T270646: Use Config instead of globals in SecurePoll extension.Dec 21 2020, 7:57 PM

Tchanders added a subscriber: STran.Dec 21 2020, 7:59 PM

• Niharika moved this task from Onboarding Tasks to Triage/To be Estimated on the Anti-Harassment-Team board.Jan 5 2021, 7:50 PM

• Niharika renamed this task from Stop accessing global config variable from SpecialSecurePoll to Stop accessing global config variable from SpecialSecurePoll (OT).Jan 6 2021, 7:17 AM

• Niharika triaged this task as Medium priority.

ARamirez_WMF set the point value for this task to 2.Jan 6 2021, 5:36 PM

ARamirez_WMF moved this task from Triage/To be Estimated to Cards ready for development on the Anti-Harassment-Team board.

• Niharika moved this task from Cards ready for development to The Letter Song on the Anti-Harassment-Team board.Jan 6 2021, 5:54 PM

• Niharika edited projects, added: Anti-Harassment-Team (The Letter Song); removed: Anti-Harassment-Team.

ARamirez_WMF set Due Date to Jan 12 2021, 5:00 AM.Jan 7 2021, 12:02 AM

ARamirez_WMF changed the subtype of this task from "Task" to "Deadline".

• wikitrent moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment-Team (The Letter Song) board.Jan 19 2021, 7:22 PM

• wikitrent claimed this task.Jan 19 2021, 7:27 PM

Change 657332 had a related patch set uploaded (by Wikitrent; owner: Wikitrent):
[mediawiki/extensions/SecurePoll@master] Remove global var from SpecialSecurePoll.php

https://gerrit.wikimedia.org/r/657332

gerritbot added a project: Patch-For-Review.Jan 20 2021, 12:45 PM

• wikitrent moved this task from In Progress 💪 to Code Review 🔍 on the Anti-Harassment-Team (The Letter Song) board.Jan 20 2021, 12:50 PM

Tchanders moved this task from Code Review 🔍 to Done: Q3 (2020-2021) on the Anti-Harassment-Team (The Letter Song) board.Jan 21 2021, 5:14 PM

Change 657332 merged by jenkins-bot:
[mediawiki/extensions/SecurePoll@master] Remove global var from SpecialSecurePoll.php

https://gerrit.wikimedia.org/r/657332

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.28; 2021-01-26).Jan 21 2021, 6:00 PM

Maintenance_bot removed a project: Patch-For-Review.Jan 21 2021, 6:11 PM

• Niharika closed this task as Resolved.Feb 8 2021, 12:40 PM