Page MenuHomePhabricator

Stop accessing global config variable from SpecialSecurePoll (OT)
Closed, ResolvedPublic2 Estimated Story PointsJan 12 2021

Description

See T71084 for the motivation behind this work.

SpecialSecurePoll accesses a global config variable directly.

Instead it can make use of SpecialPage::getConfig and call:

$this->getConfig()->get( 'ExtensionAssetsPath' );

Details

Event Timeline

Niharika renamed this task from Stop accessing global config variable from SpecialSecurePoll to Stop accessing global config variable from SpecialSecurePoll (OT).Jan 6 2021, 7:17 AM
Niharika triaged this task as Medium priority.
ARamirez_WMF changed the subtype of this task from "Task" to "Deadline".

Change 657332 had a related patch set uploaded (by Wikitrent; owner: Wikitrent):
[mediawiki/extensions/SecurePoll@master] Remove global var from SpecialSecurePoll.php

https://gerrit.wikimedia.org/r/657332

Change 657332 merged by jenkins-bot:
[mediawiki/extensions/SecurePoll@master] Remove global var from SpecialSecurePoll.php

https://gerrit.wikimedia.org/r/657332