Stop accessing global config variables from SecurePoll's ListPager (OT)
Closed, ResolvedPublic2 Estimated Story Points
Actions

Assigned To

Authored By

	Tchanders
	Dec 21 2020, 7:53 PM

Description

See T71084 for the motivation behind this work.

ListPager accesses a couple of global config variables directly.

Instead it can use e.g.:

$this->listPage->specialPage->getConfig()->get('ScriptPath');

Details

	Subject	Repo	Branch	Lines +/-
	Stop accessing global config variables from SecurePoll's ListPager	mediawiki/extensions/SecurePoll	master	+7 -5

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T11968 Reduce use of global and public variables
Open	None	T270646 Use Config instead of globals in SecurePoll extension
Resolved	AdhamKhatean	T270645 Stop accessing global config variables from SecurePoll's ListPager (OT)

Event Timeline

Tchanders created this task.Dec 21 2020, 7:53 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 21 2020, 7:53 PM

Tchanders added a parent task: T270646: Use Config instead of globals in SecurePoll extension.Dec 21 2020, 7:57 PM

Tchanders added a subscriber: STran.

Niharika moved this task from Onboarding Tasks to Triage/To be Estimated on the Anti-Harassment board.Jan 5 2021, 7:34 PM

Niharika renamed this task from Stop accessing global config variables from SecurePoll's ListPager to Stop accessing global config variables from SecurePoll's ListPager (OT).Jan 6 2021, 7:17 AM

Niharika triaged this task as Medium priority.

ARamirez_WMF set the point value for this task to 2.Jan 6 2021, 5:36 PM

ARamirez_WMF moved this task from Triage/To be Estimated to Cards ready for development on the Anti-Harassment board.

Niharika moved this task from Cards ready for development to The Letter Song on the Anti-Harassment board.Jan 6 2021, 5:54 PM

Niharika edited projects, added Anti-Harassment (The Letter Song); removed Anti-Harassment.

Niharika moved this task from The Letter Song to Cards ready for development on the Anti-Harassment board.

Niharika edited projects, added Anti-Harassment; removed Anti-Harassment (The Letter Song).

ARamirez_WMF moved this task from Cards ready for development to The Letter Song on the Anti-Harassment board.Jan 13 2021, 5:54 PM

ARamirez_WMF edited projects, added Anti-Harassment (The Letter Song); removed Anti-Harassment.

ARamirez_WMF moved this task from The Letter Song to Cards ready for development on the Anti-Harassment board.Jan 13 2021, 9:49 PM

ARamirez_WMF edited projects, added Anti-Harassment; removed Anti-Harassment (The Letter Song).

AdhamKhatean subscribed.Jan 19 2021, 5:17 PM

AdhamKhatean claimed this task.Jan 19 2021, 8:57 PM

Change 657226 had a related patch set uploaded (by AdhamKhatean; owner: AdhamKhatean):
[mediawiki/extensions/SecurePoll@master] Stop accessing global config variables from SecurePoll's ListPager

https://gerrit.wikimedia.org/r/657226

gerritbot added a project: Patch-For-Review.Jan 20 2021, 4:56 AM

ARamirez_WMF moved this task from Cards ready for development to The Letter Song on the Anti-Harassment board.Jan 20 2021, 6:52 PM

ARamirez_WMF edited projects, added Anti-Harassment (The Letter Song); removed Anti-Harassment.

ARamirez_WMF moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to Code Review 🔍 on the Anti-Harassment (The Letter Song) board.

Change 657226 merged by jenkins-bot:
[mediawiki/extensions/SecurePoll@master] Stop accessing global config variables from SecurePoll's ListPager

https://gerrit.wikimedia.org/r/657226

Tchanders moved this task from Code Review 🔍 to Done: Q3 (2020-2021) on the Anti-Harassment (The Letter Song) board.Jan 21 2021, 5:05 PM

Maintenance_bot removed a project: Patch-For-Review.Jan 21 2021, 5:11 PM

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.28; 2021-01-26).Jan 21 2021, 6:00 PM

Niharika closed this task as Resolved.Feb 8 2021, 12:09 PM