Page MenuHomePhabricator
Create Task
Maniphest T271287

Parsoid CI broken by Rest\Handler\LanguageLinksHandlerTest
Closed, ResolvedPublic
Actions

Description

Fails on all Parsoid patches, for example this NO-OP patch.
From https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php72-noselenium-docker/56133/console for example.

....
17:03:05 1) MediaWiki\Tests\Rest\Handler\LanguageLinksHandlerTest::testExecute
17:03:05 Failed asserting that actual size 1 matches expected size 2.
17:03:05 
17:03:05 /workspace/src/tests/phpunit/integration/includes/Rest/Handler/LanguageLinksHandlerTest.php:82
17:03:05 /workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php:437
17:03:05 /workspace/src/maintenance/doMaintenance.php:106
....

Details

SubjectRepoBranchLines +/-
LanguageLinksHandlerTest: use wgInterwikiCache instead of mutating databasemediawiki/coremaster+6 -8
LanguageLinksHandlerTest: clean up interwiki table after mutation by testmediawiki/coremaster+5 -1
Customize query in gerrit

Event Timeline

ssastry created this task.Jan 6 2021, 3:07 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 6 2021, 3:07 AM
ssastry updated the task description. (Show Details)Jan 6 2021, 3:09 AM
• Pchelolo added a comment.Jan 6 2021, 3:13 AM

Does Parsoid mess around with inter wiki table in its tests?

cscott subscribed.Jan 6 2021, 6:32 PM

Yes, the Parser test runner setup creates its own interwiki table (using wgInterwikiCache) so that test results are not dependent on the host wiki configuration.

cscott added a comment.Jan 6 2021, 6:33 PM

Related Q: how can we make code CI run your test suite so that it doesn't just break Parsoid CI? Core CI *does* run some tests in a mode where Parsoid is installed -- can we add your tests to that group?

gerritbot added a comment.Jan 6 2021, 6:38 PM

Change 654660 had a related patch set uploaded (by Ppchelko; owner: Ppchelko):
[mediawiki/core@master] LanguageLinksHandlerTest: reset iw table for more robustness

https://gerrit.wikimedia.org/r/654660

gerritbot added a project: Patch-For-Review.Jan 6 2021, 6:39 PM
• Pchelolo added a comment.Jan 6 2021, 6:40 PM
In T271287#6726466, @cscott wrote:

Related Q: how can we make code CI run your test suite so that it doesn't just break Parsoid CI? Core CI *does* run some tests in a mode where Parsoid is installed -- can we add your tests to that group?

This test is run in core CI as well, but it passes. It also passes when Parsoid is installed. In his case I guess parsoid messes up the IW table for this test. Let's see if my patch above helps.

gerritbot added a comment.Jan 6 2021, 9:51 PM

Change 654679 had a related patch set uploaded (by C. Scott Ananian; owner: Ppchelko):
[mediawiki/core@master] LanguageLinksHandlerTest: use wgInterwikiCache instead of mutating database

https://gerrit.wikimedia.org/r/654679

gerritbot added a comment.Jan 6 2021, 10:50 PM

Change 654660 abandoned by Ppchelko:
[mediawiki/core@master] LanguageLinksHandlerTest: clean up interwiki table after mutation by test

Reason:
Superseded by Id1899a89ae6b55e7032befe73990d215370828d8

https://gerrit.wikimedia.org/r/654660

gerritbot added a comment.Jan 6 2021, 10:52 PM

Change 654679 abandoned by C. Scott Ananian:
[mediawiki/core@master] LanguageLinksHandlerTest: use wgInterwikiCache instead of mutating database

Reason:
Abandoned in favor of Id1899a89ae6b55e7032befe73990d215370828d8

https://gerrit.wikimedia.org/r/654679

gerritbot added a comment.Jan 6 2021, 10:52 PM

Change 654679 restored by C. Scott Ananian:
[mediawiki/core@master] LanguageLinksHandlerTest: use wgInterwikiCache instead of mutating database

https://gerrit.wikimedia.org/r/654679

gerritbot added a comment.Jan 6 2021, 11:25 PM

Change 654679 merged by jenkins-bot:
[mediawiki/core@master] LanguageLinksHandlerTest: use wgInterwikiCache instead of mutating database

https://gerrit.wikimedia.org/r/654679

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.26; 2021-01-12).Jan 7 2021, 12:01 AM
• holger.knust triaged this task as Medium priority.Jan 12 2021, 2:23 PM
• holger.knust edited projects, added Platform Team Workboards (Clinic Duty Team); removed Platform Engineering.
• holger.knust subscribed.

@Pchelolo Is this issue resolved?

• holger.knust moved this task from Inbox to Later on the Platform Team Workboards (Clinic Duty Team) board.Jan 12 2021, 2:24 PM
ssastry closed this task as Resolved.Jan 14 2021, 7:25 PM
ssastry assigned this task to • Pchelolo.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL