Page MenuHomePhabricator
Create Task
Maniphest T271482

Normalize styles in Monobook are coming after the main Monobook styles (<hr> is being hidden [and then shown sometimes])
Closed, DuplicatePublic
Actions

Description

For some reason, <hr>, the wikitext four-bar line, seems to being hidden in Javascript and then displayed, at least in Monobook. I am identifying Javascript as the issue since I (unlike the original reporter) get a FOUC in Monobook. (But not in Timeless or Vector.)

Original report: Monobook separator lines have gone invisible.

I assume this is new behavior for this deploy, as the user in question says he has used Monobook for some time.

hr element has height=0 in monobook making it not display

Able to replicate on testwiki, differs if logged in or not logged in:

https://test.wikipedia.org/wiki/Missing_hl?useskin=monobook&safemode=1

Related Objects

Event Timeline

Izno created this task.Jan 7 2021, 10:36 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 7 2021, 10:36 PM
Xaosflux merged a task: T271489: hr element has height=0 in monobook.Jan 7 2021, 11:08 PM
Xaosflux added a project: Regression.
Xaosflux updated the task description. (Show Details)
Xaosflux subscribed.

When logged in:

image.png (148×877 px, 14 KB)

When not logged in:

image.png (129×877 px, 13 KB)

Seems there is a lot competing for the height of the hr tag

Xaosflux added a comment.Jan 7 2021, 11:12 PM

0'd and reset:

image.png (217×372 px, 6 KB)

Xaosflux added a comment.Jan 7 2021, 11:18 PM

Doesn't seem to be client side js, as is occurring with safemode; competing styling appears to be in place with both contextbox and an hr @screen directive

DavidEppstein subscribed.Jan 7 2021, 11:27 PM
Izno added a comment.EditedJan 7 2021, 11:43 PM

For some reason, the normalize styles are being loaded/appended to the main Monobook styles (rather than pre-pended).

Izno renamed this task from <hr> is being hidden and then shown via Javascript (in Monobook) to Normalize styles in Monobook are coming after the main Monobook styles (<hr> is being hidden [and then shown sometimes]).Jan 7 2021, 11:45 PM
Xaosflux added a comment.Jan 8 2021, 1:34 AM

Possible related task: T256520 ?

Xaosflux added subscribers: Volker_E, Jdlrobson.Jan 8 2021, 1:37 AM

@Volker_E or @Jdlrobson would you be able to see see if this is related to T256520 please?

Jdlrobson closed this task as a duplicate of T269618: Order of ResourceLoaderSkinModule should be consistent across skins.Jan 8 2021, 2:03 AM
Ammarpad subscribed.EditedJan 9 2021, 7:17 AM

For some reason, <hr>, the wikitext four-bar line, seems to being hidden in Javascript and then displayed, at least in Monobook. I am identifying Javascript as the issue since I (unlike the original reporter) get a FOUC in Monobook. (But not in Timeless or Vector.)

I think this is still happening for me even if the style files are flipped (to prepend normalize), so it's likely a different issue with MonoBook

Bdijkstra subscribed.Jan 9 2021, 4:30 PM
Bdijkstra unsubscribed.
Iniquity added projects: Design, CSS.Jan 10 2021, 9:30 AM
Iniquity subscribed.
MBH subscribed.Jan 10 2021, 9:42 AM

The problem still exist, see https://ru.wikipedia.org/wiki/User:MBH in monobook and vector (2 horisontal lines disappear in monobook).

valerio.bozzolan subscribed.Jan 19 2021, 8:37 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits