Order of ResourceLoaderSkinModule should be consistent across skins
Closed, ResolvedPublic3 Estimated Story Points
Actions

Assigned To

Authored By

	Jdlrobson
	Dec 7 2020, 7:15 PM

Description

Currently defining a module using ResourceLoaderSkinModule orders styles based on the order of the array keys of the features array defined via ResourceLoader.

This is unintended as it means normalize styles can be applied at the end of the stylesheet, disabling any overrides.

QA steps

in beta

Confirm normalize rules come first in https://en.wikipedia.beta.wmflabs.org/w/load.php?lang=en&modules=skins.monobook.styles&only=styles&skin=monobook&debug=true
Confirm normalize rules come first in https://en.wikipedia.beta.wmflabs.org/w/load.php?lang=en&modules=skins.vector.styles&only=styles&skin=vector&debug=true
Confirm horizontal line is present between the two lines on https://en.wikipedia.beta.wmflabs.org/wiki/Missing_HL?useskin=monobook

in production

Confirm horizontal line is present between the two lines on https://test.wikipedia.org/wiki/Missing_hl?useskin=monobook&safemode=1
Confirm a horizontal line appears above the text "Статистика и инструменты:" in https://ru.wikipedia.org/wiki/Участник:MBH?useskin=monobook

QA Results - Prod

AC	Status	Details
1	✅	T269618#6773391

Details

	Subject	Repo	Branch	Lines +/-
	Feature file styles should precede module defined ones	mediawiki/core	master	+79 -55
	ResourceLoaderSkinModule defines the order of feature styles	mediawiki/core	master	+56 -23

Customize query in gerrit

Related Objects

Mentioned In: T270012: Monobook external link icon has disappeared in responsive version of Monobook

Event Timeline

Jdlrobson created this task.Dec 7 2020, 7:15 PM

Restricted Application added a project: Performance-Team. · View Herald TranscriptDec 7 2020, 7:15 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 646805 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/core@master] ResourceLoaderSkinModule defines the order of feature styles

https://gerrit.wikimedia.org/r/646805

gerritbot added a project: Patch-For-Review.Dec 7 2020, 7:15 PM

Krinkle assigned this task to Jdlrobson.Dec 7 2020, 7:54 PM

Krinkle triaged this task as High priority.

Krinkle moved this task from Inbox, needs triage to Radar on the Performance-Team board.

Krinkle edited projects, added Performance-Team (Radar); removed Performance-Team.

Krinkle moved this task from Inbox to Confirmed Problem on the MediaWiki-ResourceLoader board.

Krinkle moved this task from Limbo to Watching on the Performance-Team (Radar) board.

Jdlrobson mentioned this in T270012: Monobook external link icon has disappeared in responsive version of Monobook.Dec 14 2020, 3:42 PM

Jdlrobson added a project: Web-Team-Backlog (Kanbanana-FY-2020-21).Dec 14 2020, 11:11 PM

Change 646805 merged by jenkins-bot:
[mediawiki/core@master] ResourceLoaderSkinModule defines the order of feature styles

https://gerrit.wikimedia.org/r/646805

Jdlrobson moved this task from Needs Analysis to Ready for Signoff on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.Dec 15 2020, 2:47 AM

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.25; 2021-01-05).Dec 15 2020, 3:00 AM

Maintenance_bot removed a project: Patch-For-Review.Dec 15 2020, 3:10 AM

https://en.wikipedia.beta.wmflabs.org/w/load.php?lang=en&modules=skins.vector.styles&only=styles&skin=vector normalize is now coming first

Jdlrobson merged a task: T271482: Normalize styles in Monobook are coming after the main Monobook styles (<hr> is being hidden [and then shown sometimes]).Jan 8 2021, 2:03 AM

Jdlrobson added subscribers: Izno, Volker_E, DavidEppstein, Xaosflux.

Seems to still be a problem here - in https://en.wikipedia.beta.wmflabs.org/w/load.php?lang=en&modules=skins.monobook.styles&only=styles&skin=monobook&debug=true the @screen media query CSS is appearing above the all which is odd.

local hack-arounds added to enwiki and metawiki production in MediaWiki:Monobook.css for break of hr elements

jhsoby subscribed.Jan 8 2021, 2:15 PM

Change 655131 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/core@master] Feature file styles should precede module defined ones

https://gerrit.wikimedia.org/r/655131

gerritbot added a project: Patch-For-Review.Jan 8 2021, 9:25 PM

The invisible hr element is also reported on nl.wp (and temporarily 'fixed' in the project's monobook.css).

general styles loaded for monobook on nl.wp
the skins.monobook.styles module, with the "MediaWiki style sheet for addressing (normalizing) browser bugs and inconsistencies" at the near-end

Bdijkstra subscribed.Jan 9 2021, 4:30 PM

Iniquity subscribed.Jan 10 2021, 9:32 AM

The problem still exist, see https://ru.wikipedia.org/wiki/User:MBH in monobook and vector (2 horisontal lines disappear in monobook).

Jdlrobson moved this task from Ready for Signoff to Code Review on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.Jan 11 2021, 6:14 PM

ovasileva set the point value for this task to 3.Jan 11 2021, 6:20 PM

phuedx moved this task from Code Review to Needs More Work on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.Jan 12 2021, 2:00 PM

Jdlrobson moved this task from Needs More Work to Doing on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.Jan 12 2021, 6:09 PM

Jdlrobson moved this task from Doing to Code Review on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.Jan 12 2021, 10:10 PM

phuedx removed Jdlrobson as the assignee of this task.Jan 13 2021, 2:04 PM

phuedx moved this task from Code Review to QA on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.

Change 655131 merged by jenkins-bot:
[mediawiki/core@master] Feature file styles should precede module defined ones

https://gerrit.wikimedia.org/r/655131

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.27; 2021-01-19); removed MW-1.36-notes (1.36.0-wmf.25; 2021-01-05).Jan 13 2021, 3:00 PM

Maintenance_bot removed a project: Patch-For-Review.Jan 13 2021, 3:10 PM

Jdlrobson updated the task description. (Show Details)Jan 13 2021, 6:31 PM

Jdlrobson moved this task from QA to QA in Prod on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.

ovasileva assigned this task to Edtadros.Jan 20 2021, 6:06 PM

Test Result - Prod

Status: ✅ PASS
Environment: testwiki
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

AC1: Confirm horizontal line is present between the two lines on https://test.wikipedia.org/wiki/Missing_hl?useskin=monobook&safemode=1

Screen Shot 2021-01-25 at 6.20.52 AM.png (233×829 px, 72 KB)

AC2: Confirm a horizontal line appears above the text "Статистика и инструменты:" in https://ru.wikipedia.org/wiki/Участник:MBH?useskin=monobook

Screen Shot 2021-01-25 at 6.21.44 AM.png (394×1 px, 194 KB)

Edtadros updated the task description. (Show Details)Jan 25 2021, 2:23 PM

ovasileva closed this task as Resolved.Jan 25 2021, 4:18 PM

Prod subscribed.Aug 12 2022, 5:49 AM

	F34022374: Screen Shot 2021-01-25 at 6.20.52 AM.png
	Jan 25 2021, 2:22 PM

	F34022384: Screen Shot 2021-01-25 at 6.21.44 AM.png
	Jan 25 2021, 2:22 PM

Order of ResourceLoaderSkinModule should be consistent across skinsClosed, ResolvedPublic3 Estimated Story PointsActions