Page MenuHomePhabricator

Order of ResourceLoaderSkinModule should be consistent across skins
Closed, ResolvedPublic3 Estimated Story Points

Description

Currently defining a module using ResourceLoaderSkinModule orders styles based on the order of the array keys of the features array defined via ResourceLoader.

This is unintended as it means normalize styles can be applied at the end of the stylesheet, disabling any overrides.

QA steps

in beta

in production

QA Results - Prod

ACStatusDetails
1T269618#6773391

Event Timeline

Jdlrobson created this task.Dec 7 2020, 7:15 PM
Restricted Application added a project: Performance-Team. · View Herald TranscriptDec 7 2020, 7:15 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 646805 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/core@master] ResourceLoaderSkinModule defines the order of feature styles

https://gerrit.wikimedia.org/r/646805

Krinkle assigned this task to Jdlrobson.Dec 7 2020, 7:54 PM
Krinkle triaged this task as High priority.
Krinkle moved this task from Inbox to Radar on the Performance-Team board.
Krinkle edited projects, added Performance-Team (Radar); removed Performance-Team.
Krinkle moved this task from Inbox to Confirmed Problem on the MediaWiki-ResourceLoader board.
Krinkle moved this task from Limbo to Watching on the Performance-Team (Radar) board.

Change 646805 merged by jenkins-bot:
[mediawiki/core@master] ResourceLoaderSkinModule defines the order of feature styles

https://gerrit.wikimedia.org/r/646805

Jdlrobson reopened this task as Open.Fri, Jan 8, 2:07 AM

Seems to still be a problem here - in https://en.wikipedia.beta.wmflabs.org/w/load.php?lang=en&modules=skins.monobook.styles&only=styles&skin=monobook&debug=true the @screen media query CSS is appearing above the all which is odd.

Xaosflux added a comment.EditedFri, Jan 8, 2:38 AM

local hack-arounds added to enwiki and metawiki production in MediaWiki:Monobook.css for break of hr elements

jhsoby added a subscriber: jhsoby.Fri, Jan 8, 2:15 PM

Change 655131 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/core@master] Feature file styles should precede module defined ones

https://gerrit.wikimedia.org/r/655131

Marc added a subscriber: Marc.Sat, Jan 9, 3:58 PM

The invisible hr element is also reported on nl.wp (and temporarily 'fixed' in the project's monobook.css).

MBH added a subscriber: MBH.Sun, Jan 10, 9:52 AM

The problem still exist, see https://ru.wikipedia.org/wiki/User:MBH in monobook and vector (2 horisontal lines disappear in monobook).

ovasileva set the point value for this task to 3.Mon, Jan 11, 6:20 PM
phuedx removed Jdlrobson as the assignee of this task.Wed, Jan 13, 2:04 PM

Change 655131 merged by jenkins-bot:
[mediawiki/core@master] Feature file styles should precede module defined ones

https://gerrit.wikimedia.org/r/655131

Edtadros reassigned this task from Edtadros to ovasileva.Mon, Jan 25, 2:22 PM
Edtadros added a subscriber: Edtadros.

Test Result - Prod

Status: ✅ PASS
Environment: testwiki
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

AC1: Confirm horizontal line is present between the two lines on https://test.wikipedia.org/wiki/Missing_hl?useskin=monobook&safemode=1

AC2: Confirm a horizontal line appears above the text "Статистика и инструменты:" in https://ru.wikipedia.org/wiki/Участник:MBH?useskin=monobook

Edtadros updated the task description. (Show Details)Mon, Jan 25, 2:23 PM
ovasileva closed this task as Resolved.Mon, Jan 25, 4:18 PM