Page MenuHomePhabricator

Quibble runs core *integration* tests against Parsoid-as-an-extension, not *unit* tests
Open, Needs TriagePublic

Description

The integration tests from core are not guaranteed to pass once extensions are loaded, since they can have arbitrary side-effects on core functions via hooks.

For example, installing Scribunto makes core integration tests fail, because (among other things) one of the tests enumerates all the registered namespaces, and Scribunto adds the 'Module' and 'Module_talk' namespaces.

For this reason, integration-config only runs extension tests and core *unit tests* when extensions are installed.

But Parsoid at this moment is running the full test suite including integration tests.

Event Timeline

Change 655760 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[integration/config@master] Zuul: Remove parsoid dependencies

https://gerrit.wikimedia.org/r/655760

Change 655742 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[integration/config@master] Ensure Parsoid's tests include the Disambiguator extension (take 2)

https://gerrit.wikimedia.org/r/655742

Change 655732 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[integration/quibble@master] Test Parsoid as if it were an extension

https://gerrit.wikimedia.org/r/655732

Change 655760 merged by jenkins-bot:
[integration/config@master] Zuul: Remove parsoid dependencies

https://gerrit.wikimedia.org/r/655760

Change 655732 merged by jenkins-bot:
[integration/quibble@master] Test Parsoid as if it were an extension

https://gerrit.wikimedia.org/r/655732