Page MenuHomePhabricator
Create Task
Maniphest T237538

Merge Disambiguation in core or add hook
Closed, ResolvedPublic
Actions

Description

Parsoid depends on the Disambiguator extension. This extension should either be merged into core, or implemented with a hook or API that Parsoid can cleanly use.

(Grep for this task # in the parsoid sources to learn more.)

Details

SubjectRepoBranchLines +/-
Zuul: Add Disambiguator to the MediaWiki gated extension setintegration/configmaster+2 -0
Ensure Parsoid's tests include the Disambiguator extension (take 2)integration/configmaster+2 -4
Move Parsoid disambiguator parser tests to Extension:Disambiguatormediawiki/extensions/Disambiguatormaster+15 -1
Ensure Parsoid's integration job tests against the Disambiguator extensionintegration/configmaster+6 -0
Disentangle Disambiguator extension from Parsoidmediawiki/services/parsoidmaster+37 -32
Bump wikimedia/parsoid to 0.13.0-a22mediawiki/vendormaster+211 -91
api: Fix property description for 'linkclasses' property of ApiQueryInfomediawiki/coremaster+1 -1
api: Use GetLinkColours hook to export CSS classes in page infomediawiki/coremaster+137 -25
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenNoneT261329 Prepare Parsoid for MW
 ResolvedcscottT237538 Merge Disambiguation in core or add hook

Event Timeline

cscott created this task.Nov 6 2019, 2:56 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 6 2019, 2:56 PM
• ssastry edited projects, added Parsoid; removed Parsoid-PHP.Nov 14 2019, 11:09 PM
LGoto moved this task from Needs Triage to Backlog on the Parsoid board.Feb 15 2020, 12:05 AM
LGoto moved this task from Backlog to Non-Parsing-Team Tasks on the Parsoid board.Feb 21 2020, 5:22 PM
cscott added a parent task: T248186: Prepare Parsoid for MediaWiki 1.35 LTS.Mar 23 2020, 6:46 PM
Legoktm subscribed.May 7 2020, 11:03 PM

For merging it into core, see T37981: Move Special:Disambiguations and relevant messages out of core to an extension and https://lists.gt.net/wiki/wikitech/327285 as prior discussion about moving it out of core.

cscott added a comment.Aug 26 2020, 4:52 PM
In T237538#6117935, @Legoktm wrote:

For merging it into core, see T37981: Move Special:Disambiguations and relevant messages out of core to an extension and https://lists.gt.net/wiki/wikitech/327285 as prior discussion about moving it out of core.

Thanks for the pointer. As the title of this task states, we could also add a 'proper' hook to core and leave it as an extension. Worth revisiting that 7-yr-old discussion though!

cscott added a comment.Aug 26 2020, 4:52 PM

(Didn't get this done for 1.35, re-targetting for 1.36.)

cscott edited parent tasks, added: T261329: Prepare Parsoid for MW; removed: T248186: Prepare Parsoid for MediaWiki 1.35 LTS.Aug 26 2020, 4:52 PM
cscott added a comment.Dec 10 2020, 3:22 PM

We already have the GetLinkColors hook, called from LinkHolderArray, which Disambiguator uses to add the appropriate class.
Probably that hook is sufficient, we just need to restructure how the Parsoid DataAccess works. This would still require Disambiguator-specific information in the Parsoid 'API' backend, but that's probably reasonable.

The parser tests which have the disambiguator CSS class should be moved to tests/parser of Extension:Disambiguator with an appropriate extension:Disambiguator line in the !! hooks section.

MBinder_WMF edited projects, added Parsoid (Tracking); removed Parsoid.Dec 10 2020, 8:12 PM
gerritbot added a comment.Dec 10 2020, 11:43 PM

Change 647841 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/core@master] api: Use GetLinkColours hook to export CSS classes in page info

https://gerrit.wikimedia.org/r/647841

gerritbot added a project: Patch-For-Review.Dec 10 2020, 11:43 PM
gerritbot added a comment.Dec 10 2020, 11:50 PM

Change 647847 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/services/parsoid@master] WIP: Disentangle Disambiguator extension from Parsoid

https://gerrit.wikimedia.org/r/647847

gerritbot added a comment.Dec 12 2020, 4:35 AM

Change 648461 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/Disambiguator@master] Move Parsoid disambiguator parser tests to Extension:Disambiguator

https://gerrit.wikimedia.org/r/648461

gerritbot added a comment.Dec 15 2020, 12:27 AM

Change 647841 merged by jenkins-bot:
[mediawiki/core@master] api: Use GetLinkColours hook to export CSS classes in page info

https://gerrit.wikimedia.org/r/647841

gerritbot added a comment.Dec 15 2020, 3:56 PM

Change 649663 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/core@master] api: Fix property description for 'linkclasses' property of ApiQueryInfo

https://gerrit.wikimedia.org/r/649663

gerritbot added a comment.Dec 15 2020, 4:28 PM

Change 649663 merged by jenkins-bot:
[mediawiki/core@master] api: Fix property description for 'linkclasses' property of ApiQueryInfo

https://gerrit.wikimedia.org/r/649663

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.25; 2021-01-05).Dec 15 2020, 5:00 PM
gerritbot added a comment.Jan 8 2021, 4:42 PM

Change 647847 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Disentangle Disambiguator extension from Parsoid

https://gerrit.wikimedia.org/r/647847

gerritbot added a comment.Jan 8 2021, 4:48 PM

Change 655097 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[integration/config@master] Add Disambiguator to mediawiki gated extension set

https://gerrit.wikimedia.org/r/655097

gerritbot added a comment.Jan 8 2021, 4:48 PM

Change 655098 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[integration/config@master] Ensure Parsoid's integration job tests against the Disambiguator extension

https://gerrit.wikimedia.org/r/655098

gerritbot added a comment.Jan 11 2021, 6:24 PM

Change 655482 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.13.0-a22

https://gerrit.wikimedia.org/r/655482

gerritbot added a comment.Jan 11 2021, 8:42 PM

Change 655482 merged by jenkins-bot:
[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.13.0-a22

https://gerrit.wikimedia.org/r/655482

gerritbot added a comment.Jan 12 2021, 1:10 AM

Change 655098 merged by jenkins-bot:
[integration/config@master] Ensure Parsoid's integration job tests against the Disambiguator extension

https://gerrit.wikimedia.org/r/655098

Stashbot added a comment.Jan 12 2021, 1:11 AM

Mentioned in SAL (#wikimedia-releng) [2021-01-12T01:11:38Z] <James_F> Zuul: Ensure Parsoid's integration job tests against the Disambiguator extension T237538

gerritbot added a comment.Jan 12 2021, 7:37 PM

Change 655742 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[integration/config@master] Ensure Parsoid's integration job tests against the Disambiguator extension

https://gerrit.wikimedia.org/r/655742

gerritbot added a comment.Jan 12 2021, 8:29 PM

Change 648461 merged by jenkins-bot:
[mediawiki/extensions/Disambiguator@master] Move Parsoid disambiguator parser tests to Extension:Disambiguator

https://gerrit.wikimedia.org/r/648461

cscott mentioned this in rEDISf9e5a56bf8d4: Move Parsoid disambiguator parser tests to Extension:Disambiguator.Jan 12 2021, 8:31 PM
gerritbot added a comment.May 5 2021, 11:50 PM

Change 655742 merged by jenkins-bot:

[integration/config@master] Ensure Parsoid's tests include the Disambiguator extension (take 2)

https://gerrit.wikimedia.org/r/655742

Stashbot added a comment.May 5 2021, 11:52 PM

Mentioned in SAL (#wikimedia-releng) [2021-05-05T23:52:38Z] <James_F> Zuul: Ensure Parsoid's tests include the Disambiguator extension (take 2) T271863 T237538

Stashbot mentioned this in T271863: Quibble runs core *integration* tests against Parsoid-as-an-extension, not *unit* tests.May 5 2021, 11:52 PM
gerritbot added a comment.May 11 2021, 11:31 PM

Change 655097 merged by jenkins-bot:

[integration/config@master] Zuul: Add Disambiguator to the MediaWiki gated extension set

https://gerrit.wikimedia.org/r/655097

Stashbot added a comment.May 11 2021, 11:32 PM

Mentioned in SAL (#wikimedia-releng) [2021-05-11T23:32:01Z] <James_F> Zuul: Add Disambiguator to the MediaWiki gated extension set T237538 T249674

Stashbot mentioned this in T249674: Have all Wikimedia production extensions and skins in the CI gate.May 11 2021, 11:32 PM
cscott closed this task as Resolved.Feb 16 2022, 8:24 PM
cscott claimed this task.

This task was accomplished!

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL