Page MenuHomePhabricator
Create Task
Maniphest T272132

show constraint violation indicator to non-logged-in users
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

As a non-logged-in editor I want to be made aware of constraints violation on a statement I am looking at in order to see potential mistakes more easily.

Problem:
We are only showing constraint violation indicators to people who are logged in. So editors who are not logged in do not see mistakes that they could potentially fix.

Screenshots/mockups:

image.png (108×467 px, 6 KB)

BDD
GIVEN a statement with a constraint violation
WHEN viewing it without being logged in
THEN the constraint violation indicator is shown

Acceptance criteria:

  • constraint violation indicators are shown regardless of log-in status
  • we have a config option to turn these on/off
  • default for this config is 'on', meaning they are shown to everyone by default

Notes
we add the config check to these three lines https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/WikibaseQualityConstraints/+/52122e9453ca0af5616c6f8d3fbf4064b7a8baf9/src/WikibaseQualityConstraintsHooks.php#143

Details

SubjectRepoBranchLines +/-
Add config to change value showing constraint violation indicatormediawiki/extensions/WikibaseQualityConstraintsmaster+10 -4
Customize query in gerrit

Event Timeline

Lydia_Pintscher created this task.Jan 15 2021, 10:03 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 15 2021, 10:03 AM
Lea_Lacroix_WMDE subscribed.Feb 22 2021, 12:42 PM
Esc3300 subscribed.EditedJun 15 2021, 8:44 AM

The current workaround is to go to https://www.wikidata.org/wiki/Special:ConstraintReport

Esc3300 moved this task from incoming to incoming (display or retrieval of violations) on the Wikibase-Quality-Constraints board.Jun 15 2021, 12:51 PM
• Manuel moved this task from Incoming to Miscellaneous on the Wikidata-Campsite board.Jul 12 2022, 12:05 PM
Mohammed_Sadat_WMDE subscribed.Jul 18 2022, 7:49 AM
• Manuel subscribed.Jul 20 2022, 7:38 AM
Lydia_Pintscher added a project: Wikidata Dev Team.Dec 2 2022, 6:48 PM
Lydia_Pintscher moved this task from Incoming to Product Backlog on the Wikidata Dev Team board.
Lucas_Werkmeister_WMDE subscribed.Dec 7 2022, 10:32 AM

Technically, there don’t seem to be any issues with this; you can run mw.loader.using('wikibase.quality.constraints.gadget') in a private window and get constraint check results right now.

We should wrap the current $out->getUser()->isRegistered() condition in WikibaseQualityConstraintsHooks::onBeforePageDisplay() in a check for a new temporary config setting, and change that in production; if everything goes well and nothing explodes from the additional constraint check requests, we can remove the setting again and always add the module regardless of the user being logged in.

karapayneWMDE moved this task from Product Backlog to Unified DOT Backlog on the Wikidata Dev Team board.Dec 7 2022, 10:36 AM
Michael subscribed.Dec 13 2022, 11:13 AM
karapayneWMDE updated the task description. (Show Details)Dec 13 2022, 11:19 AM
karapayneWMDE set the point value for this task to 3.
karapayneWMDE moved this task from Unified DOT Backlog to Sprint-∞ on the Wikidata Dev Team board.
karapayneWMDE edited projects, added Wikidata Dev Team (Sprint-∞); removed Wikidata Dev Team.
Lucas_Werkmeister_WMDE added a comment.Dec 14 2022, 1:43 PM

Task breakdown notes:

Lucas_Werkmeister_WMDE moved this task from Parents/Waiting to Todo/Backlog on the Wikidata Dev Team (Sprint-∞) board.Dec 14 2022, 1:43 PM
hoo claimed this task.Dec 23 2022, 12:20 PM
hoo moved this task from Todo/Backlog to Doing on the Wikidata Dev Team (Sprint-∞) board.
karapayneWMDE removed hoo as the assignee of this task.Dec 28 2022, 5:58 PM
karapayneWMDE moved this task from Doing to Todo/Backlog on the Wikidata Dev Team (Sprint-∞) board.
karapayneWMDE added a subscriber: hoo.
guergana.tzatchkova claimed this task.Jan 2 2023, 2:43 PM
guergana.tzatchkova moved this task from Todo/Backlog to Doing on the Wikidata Dev Team (Sprint-∞) board.
gerritbot added a comment.Jan 2 2023, 2:59 PM

Change 874417 had a related patch set uploaded (by Guergana Tzatchkova; author: Guergana Tzatchkova):

[mediawiki/extensions/WikibaseQualityConstraints@master] Add config to change value showing contraint violation indicator

https://gerrit.wikimedia.org/r/874417

gerritbot added a project: Patch-For-Review.Jan 2 2023, 2:59 PM
guergana.tzatchkova moved this task from Doing to Peer Review on the Wikidata Dev Team (Sprint-∞) board.Jan 2 2023, 2:59 PM
gerritbot added a comment.Jan 3 2023, 4:25 PM

Change 874417 merged by jenkins-bot:

[mediawiki/extensions/WikibaseQualityConstraints@master] Add config to change value showing constraint violation indicator

https://gerrit.wikimedia.org/r/874417

Maintenance_bot removed a project: Patch-For-Review.Jan 3 2023, 4:31 PM
guergana.tzatchkova moved this task from Peer Review to Tech Verification on the Wikidata Dev Team (Sprint-∞) board.Jan 4 2023, 9:02 AM
guergana.tzatchkova moved this task from Tech Verification to Product Verification on the Wikidata Dev Team (Sprint-∞) board.Jan 4 2023, 10:34 AM
ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.18; 2023-01-09).Jan 4 2023, 2:01 PM
Arian_Bozorg closed this task as Resolved.Jan 13 2023, 7:58 AM
Arian_Bozorg moved this task from Product Verification to Our work done on the Wikidata Dev Team (Sprint-∞) board.
Arian_Bozorg subscribed.

Thank you \o/

Looking good to me

karapayneWMDE moved this task from Our work done to 2023 completed tasks on the Wikidata Dev Team (Sprint-∞) board.Feb 6 2023, 4:05 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits