Page MenuHomePhabricator

show constraint violation indicator to non-logged-in users
Closed, ResolvedPublic3 Estimated Story Points


As a non-logged-in editor I want to be made aware of constraints violation on a statement I am looking at in order to see potential mistakes more easily.

We are only showing constraint violation indicators to people who are logged in. So editors who are not logged in do not see mistakes that they could potentially fix.


image.png (108×467 px, 6 KB)

GIVEN a statement with a constraint violation
WHEN viewing it without being logged in
THEN the constraint violation indicator is shown

Acceptance criteria:

  • constraint violation indicators are shown regardless of log-in status
  • we have a config option to turn these on/off
  • default for this config is 'on', meaning they are shown to everyone by default

we add the config check to these three lines

Event Timeline

Technically, there don’t seem to be any issues with this; you can run mw.loader.using('wikibase.quality.constraints.gadget') in a private window and get constraint check results right now.

We should wrap the current $out->getUser()->isRegistered() condition in WikibaseQualityConstraintsHooks::onBeforePageDisplay() in a check for a new temporary config setting, and change that in production; if everything goes well and nothing explodes from the additional constraint check requests, we can remove the setting again and always add the module regardless of the user being logged in.

karapayneWMDE set the point value for this task to 3.

Task breakdown notes:

karapayneWMDE moved this task from Doing to Todo/Backlog on the Wikidata Dev Team (Sprint-∞) board.
karapayneWMDE added a subscriber: hoo.

Change 874417 had a related patch set uploaded (by Guergana Tzatchkova; author: Guergana Tzatchkova):

[mediawiki/extensions/WikibaseQualityConstraints@master] Add config to change value showing contraint violation indicator

Change 874417 merged by jenkins-bot:

[mediawiki/extensions/WikibaseQualityConstraints@master] Add config to change value showing constraint violation indicator

Arian_Bozorg added a subscriber: Arian_Bozorg.

Thank you \o/

Looking good to me