Page MenuHomePhabricator

WikiLambda initial installation fails when TemplateData is installed
Closed, ResolvedPublic2 Estimated Story Points

Description

We're probably relying on an assumption about content load sequencing that TD violates; not sure if that's our fault or theirs, but it needs fixing eventually.

e50477d9389befd67809ff8f] [no req]   Error from line 331 of /var/www/MediaWiki/extensions/WikiLambda/includes/ZObjects/ZPersistentObject.php: Call to a member function getData() on bool
Backtrace:
#0 /var/www/MediaWiki/core/includes/content/AbstractContent.php(591): MediaWiki\Extension\WikiLambda\ZObjects\ZPersistentObject->fillParserOutput()
#1 /var/www/MediaWiki/core/includes/Revision/RenderedRevision.php(263): AbstractContent->getParserOutput()
#2 /var/www/MediaWiki/core/includes/Revision/RenderedRevision.php(235): MediaWiki\Revision\RenderedRevision->getSlotParserOutputUncached()
#3 /var/www/MediaWiki/core/includes/Revision/RevisionRenderer.php(215): MediaWiki\Revision\RenderedRevision->getSlotParserOutput()
#4 /var/www/MediaWiki/core/includes/Revision/RevisionRenderer.php(152): MediaWiki\Revision\RevisionRenderer->combineSlotOutput()
#5 [internal function]: MediaWiki\Revision\RevisionRenderer->MediaWiki\Revision\{closure}()
#6 /var/www/MediaWiki/core/includes/Revision/RenderedRevision.php(197): call_user_func()
#7 /var/www/MediaWiki/core/includes/Storage/DerivedPageDataUpdater.php(1337): MediaWiki\Revision\RenderedRevision->getRevisionParserOutput()
#8 [internal function]: MediaWiki\Storage\DerivedPageDataUpdater->getCanonicalParserOutput()
#9 /var/www/MediaWiki/core/includes/edit/PreparedEdit.php(104): call_user_func()
#10 /var/www/MediaWiki/core/includes/edit/PreparedEdit.php(119): MediaWiki\Edit\PreparedEdit->getOutput()
#11 /var/www/MediaWiki/core/includes/Storage/DerivedPageDataUpdater.php(1315): MediaWiki\Edit\PreparedEdit->__get()
#12 /var/www/MediaWiki/core/includes/page/WikiPage.php(2143): MediaWiki\Storage\DerivedPageDataUpdater->getPreparedEdit()
#13 /var/www/MediaWiki/extensions/TemplateData/includes/TemplateDataHooks.php(69): WikiPage->prepareContentForEdit()
#14 /var/www/MediaWiki/core/includes/HookContainer/HookContainer.php(333): TemplateDataHooks::onPageContentSave()
#15 /var/www/MediaWiki/core/includes/HookContainer/HookContainer.php(140): MediaWiki\HookContainer\HookContainer->callLegacyHook()
#16 /var/www/MediaWiki/core/includes/HookContainer/HookRunner.php(2803): MediaWiki\HookContainer\HookContainer->run()
#17 /var/www/MediaWiki/core/includes/Storage/PageUpdater.php(775): MediaWiki\HookContainer\HookRunner->onPageContentSave()
#18 /var/www/MediaWiki/core/includes/page/WikiPage.php(2041): MediaWiki\Storage\PageUpdater->saveRevision()
#19 /var/www/MediaWiki/core/includes/page/WikiPage.php(1894): WikiPage->doUserEditContent()
#20 /var/www/MediaWiki/extensions/WikiLambda/includes/Hooks.php(195): WikiPage->doEditContent()
#21 /var/www/MediaWiki/core/includes/installer/DatabaseUpdater.php(532): MediaWiki\Extension\WikiLambda\Hooks::createInitialContent()
#22 /var/www/MediaWiki/core/includes/installer/DatabaseUpdater.php(500): DatabaseUpdater->runUpdates()
#23 /var/www/MediaWiki/core/maintenance/update.php(183): DatabaseUpdater->doUpdates()
#24 /var/www/MediaWiki/core/maintenance/doMaintenance.php(106): UpdateMediaWiki->execute()
#25 /var/www/MediaWiki/core/maintenance/update.php(255): require_once(string)
#26 {main}

Event Timeline

Jdforrester-WMF raised the priority of this task from Medium to High.
This comment was removed by DannyS712.

Change 665247 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/WikiLambda@master] Fix incomplete assumption in ZObjectContent

https://gerrit.wikimedia.org/r/665247

Change 665331 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/TemplateData@master] Don't validate <templatedata> tags on non-wikitext pages

https://gerrit.wikimedia.org/r/665331

thiemowmde set the point value for this task to 2.
thiemowmde added a subscriber: thiemowmde.

I think I found the reason for this crazy stack trace: https://gerrit.wikimedia.org/r/665331. Additionally I suggest to merge https://gerrit.wikimedia.org/r/665247 as well, just to be sure.

Change 665247 merged by jenkins-bot:
[mediawiki/extensions/WikiLambda@master] Fix incomplete assumption in ZObjectContent

https://gerrit.wikimedia.org/r/665247

Change 665331 merged by jenkins-bot:
[mediawiki/extensions/TemplateData@master] Don't validate <templatedata> tags on non-wikitext pages

https://gerrit.wikimedia.org/r/665331

Jdforrester-WMF reassigned this task from Jdforrester-WMF to thiemowmde.

Re-confirmed. Thank you!