Use OOUI for the form on ListPage.php
Description
Description
Details
Details
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | Goal | None | T122014 Convert all extensions/skins to OOUI | ||
| Open | None | T208687 Convert SecurePoll to use OOUI | |||
| Open | None | T273047 Convert SecurePoll ListPage to use OOUI |
Event Timeline
Comment Actions
Change 670634 had a related patch set uploaded (by DLynch; owner: DLynch):
[mediawiki/extensions/SecurePoll@master] Convert ListPage to OOUI
Comment Actions
Because the patch update just now actively changed the layout...
Before:
After a bit of refactoring for OOUI:
Comment Actions
Change 672521 had a related patch set uploaded (by DLynch; owner: DLynch):
[mediawiki/extensions/SecurePoll@master] Remove now-unusued securepoll-strike-cancel message
Comment Actions
Change 670634 merged by jenkins-bot:
[mediawiki/extensions/SecurePoll@master] Convert ListPage to OOUI
Comment Actions
Because the patch update just now actively changed the layout...
Before:
After a bit of refactoring for OOUI:
Ooo that's a striking change! Love it.
Comment Actions
I tested striking and unstriking votes, checking the appropriate API call is made and it is recorded in the DB.
I briefly tested validation. We show the error that the strike API returns, e.g.
Pressing enter does not automatically submit like it did previously. Is this normal behaviour for a OOUI popup? I tested popups in VE, and they appear to behave the same.
It does not work without JS, but that was the case before.
Test Environment: https://vote.wikimedia.beta.wmflabs.org SecurePoll 2.0.0 (97412a0) 07:26, 19 March 2021.
Comment Actions
Change 672521 merged by jenkins-bot:
[mediawiki/extensions/SecurePoll@master] Remove now-unusued securepoll-strike-cancel message
Comment Actions
Pager (in ListPage.php) is still not converted to OOUI, so reopen this task. It called getLimitForm function defined in includes/pager/TablePager.php (core). We need something similar to the following screenshot?
Comment Actions
@DLynch: Per emails from Sep18 and Oct20 and https://www.mediawiki.org/wiki/Bug_management/Assignee_cleanup , I am resetting the assignee of this task because there has not been progress lately (please correct me if I am wrong!). Resetting the assignee avoids the impression that somebody is already working on this task. It also allows others to potentially work towards fixing this task. Please claim this task again when you plan to work on it (via Add Action... → Assign / Claim in the dropdown menu) - it would be welcome. Thanks for your understanding!