Page MenuHomePhabricator

Convert SecurePoll ListPage to use OOUI
Closed, ResolvedPublic5 Estimated Story Points

Description

Use OOUI for the form on ListPage.php

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 670634 had a related patch set uploaded (by DLynch; owner: DLynch):
[mediawiki/extensions/SecurePoll@master] Convert ListPage to OOUI

https://gerrit.wikimedia.org/r/670634

Because the patch update just now actively changed the layout...

Before:

image.png (364×1 px, 51 KB)

After a bit of refactoring for OOUI:

image.png (306×714 px, 27 KB)

Change 672521 had a related patch set uploaded (by DLynch; owner: DLynch):
[mediawiki/extensions/SecurePoll@master] Remove now-unusued securepoll-strike-cancel message

https://gerrit.wikimedia.org/r/672521

Change 670634 merged by jenkins-bot:
[mediawiki/extensions/SecurePoll@master] Convert ListPage to OOUI

https://gerrit.wikimedia.org/r/670634

Because the patch update just now actively changed the layout...

Before:

image.png (364×1 px, 51 KB)

After a bit of refactoring for OOUI:

image.png (306×714 px, 27 KB)

Ooo that's a striking change! Love it.

dom_walden added a subscriber: dom_walden.

I tested striking and unstriking votes, checking the appropriate API call is made and it is recorded in the DB.

I briefly tested validation. We show the error that the strike API returns, e.g.

strike_popup_validation.png (119×336 px, 9 KB)

Pressing enter does not automatically submit like it did previously. Is this normal behaviour for a OOUI popup? I tested popups in VE, and they appear to behave the same.

It does not work without JS, but that was the case before.

Test Environment: https://vote.wikimedia.beta.wmflabs.org SecurePoll 2.0.0 (97412a0) 07:26, 19 March 2021.

Change 672521 merged by jenkins-bot:
[mediawiki/extensions/SecurePoll@master] Remove now-unusued securepoll-strike-cancel message

https://gerrit.wikimedia.org/r/672521