Release utfnormal 3.0.0
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Legoktm
	Jan 29 2021, 11:59 PM

Description

The main change is https://gerrit.wikimedia.org/r/plugins/gitiles/utfnormal/+/1be6644a4b9f995f818a91f3fa5b2c41725b7ee3%5E%21/#F0 which replaces some methods with their native equivalents.

But since we have to do a breaking change anyways, should we just drop those functions, update usage everywhere (https://codesearch.wmcloud.org/search/?q=(codepointToUtf8%7Cutf8ToCodepoint)&i=nope&files=&excludeFiles=&repos=) and release 3.0.0 without them?

Otherwise we drop them in a future 4.0.0.

Make release / tag
Make our other libraries that use it accept this version and release them: https://libraryupgrader2.wmcloud.org/library/composer/wikimedia/utfnormal
- css-sanitizer
- Equivset
- RemexHtml
Upgrade MediaWiki to use the new versions

Details

Subject	Repo	Branch	Lines +/-
Upgrade wikimedia/utfnormal from 2.0.0 to 3.0.1 (and concomitant remex-html)	mediawiki/core	master	+4 -3
Upgrade wikimedia/utfnormal from 2.0.0 to 3.0.1 (and concomitant libraries)	mediawiki/vendor	master	+307 -283
Release 2.2.2	mediawiki/libs/RemexHtml	master	+3 -0
Support wikimedia/utfnormal ^3.0.1	mediawiki/libs/RemexHtml	master	+1 -1
Support wikimedia/utfnormal ^3.0.1	css-sanitizer	master	+2 -2
Support wikimedia/utfnormal ^3.0.1	mediawiki/libs/Equivset	master	+1 -1
Release 3.0.1	utfnormal	master	+4 -0
Release 3.0.0	utfnormal	master	+28 -0

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Reedy	T263341 Periodic MW Library releases (September 2020)
		Resolved		Legoktm	T273338 Release utfnormal 3.0.0

Event Timeline

Legoktm created this task.Jan 29 2021, 11:59 PM

Jdforrester-WMF added a project: Release.Jan 30 2021, 12:03 AM

Jdforrester-WMF updated the task description. (Show Details)

Dropping the wrappers immediately with no cut-over feels a little unfriendly. Just because we can doesn't mean we should. Of course in practice I doubt anyone is using this outwith the Wikimedia universe; Packagist doesn't list anything public, for instance.

Legoktm mentioned this in T273312: Investigate possible performance degradation on mediawiki servers after Debian Buster upgrade.Jan 30 2021, 12:31 AM

Change 660066 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[utfnormal@master] Release 3.0.0

https://gerrit.wikimedia.org/r/660066

gerritbot added a project: Patch-For-Review.Jan 30 2021, 1:15 AM

https://libraryupgrader2.wmcloud.org/library/composer/wikimedia/utfnormal will need bumps in RemexHtml, css-sanitizer and Equivset.

Change 660066 merged by jenkins-bot:
[utfnormal@master] Release 3.0.0

https://gerrit.wikimedia.org/r/660066

Jdforrester-WMF updated the task description. (Show Details)Jan 30 2021, 1:29 AM

Change 660067 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/libs/RemexHtml@master] Drop wikimedia/utfnormal in favor of mb_chr()

https://gerrit.wikimedia.org/r/660067

RemexHtml's test suite exposed an issue with mb_chr on PHP 7.2, see https://gerrit.wikimedia.org/r/c/utfnormal/+/660083/ as potential fix.

Change 660290 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[utfnormal@master] Release 3.0.1

https://gerrit.wikimedia.org/r/660290

Change 660290 merged by jenkins-bot:
[utfnormal@master] Release 3.0.1

https://gerrit.wikimedia.org/r/660290

Change 660295 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/libs/Equivset@master] Support wikimedia/utfnormal ^3.0.1

https://gerrit.wikimedia.org/r/660295

Change 660296 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[css-sanitizer@master] Support wikimedia/utfnormal ^3.0.1

https://gerrit.wikimedia.org/r/660296

Jdforrester-WMF updated the task description. (Show Details)Jan 30 2021, 3:31 PM

Change 660295 merged by jenkins-bot:
[mediawiki/libs/Equivset@master] Support wikimedia/utfnormal ^3.0.1

https://gerrit.wikimedia.org/r/660295

Change 660296 merged by jenkins-bot:
[css-sanitizer@master] Support wikimedia/utfnormal ^3.0.1

https://gerrit.wikimedia.org/r/660296

Change 660067 merged by jenkins-bot:
[mediawiki/libs/RemexHtml@master] Support wikimedia/utfnormal ^3.0.1

https://gerrit.wikimedia.org/r/660067

Jdforrester-WMF updated the task description. (Show Details)Jan 30 2021, 4:08 PM

Change 660404 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/libs/RemexHtml@master] Release 2.2.2

https://gerrit.wikimedia.org/r/660404

Jdforrester-WMF updated the task description. (Show Details)Jan 30 2021, 4:11 PM

Change 660404 merged by jenkins-bot:
[mediawiki/libs/RemexHtml@master] Release 2.2.2

https://gerrit.wikimedia.org/r/660404

Jdforrester-WMF updated the task description. (Show Details)Jan 30 2021, 4:24 PM

Jdforrester-WMF updated the task description. (Show Details)

Change 660420 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/vendor@master] Upgrade wikimedia/utfnormal from 2.0.0 to 3.0.1 (and concomitant libraries)

https://gerrit.wikimedia.org/r/660420

Change 660421 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@master] Upgrade wikimedia/utfnormal from 2.0.0 to 3.0.1 (and concomitant remex-html)

https://gerrit.wikimedia.org/r/660421

Legoktm mentioned this in rCSSSba1c08590569: Support wikimedia/utfnormal ^3.0.1.Jan 30 2021, 5:41 PM

Change 660420 merged by jenkins-bot:
[mediawiki/vendor@master] Upgrade wikimedia/utfnormal from 2.0.0 to 3.0.1 (and concomitant libraries)

https://gerrit.wikimedia.org/r/660420

Change 660421 merged by jenkins-bot:
[mediawiki/core@master] Upgrade wikimedia/utfnormal from 2.0.0 to 3.0.1 (and concomitant remex-html)

https://gerrit.wikimedia.org/r/660421

Jdforrester-WMF closed this task as Resolved.Feb 1 2021, 9:25 PM

Jdforrester-WMF assigned this task to Legoktm.

Jdforrester-WMF updated the task description. (Show Details)

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.29; 2021-02-02).Feb 1 2021, 10:00 PM

Krinkle awarded a token.Feb 12 2021, 2:39 PM