Page MenuHomePhabricator

Survey extensions for cross-wiki RevisionStore usage
Open, HighPublic

Description

Per T272485, Revisionrecord now requires a wikiId to be passed into getId when used in a cross-wiki context. We need to survey and fix extensions that use RevisionStoreFactory to obtain a cross-wiki RevisionStore for calls to getId().

https://codesearch.wmcloud.org/search/?q=RevisionStoreFactory&i=nope&files=&excludeFiles=&repos=

  • ContributionScores - gets only the local RevisionStore
  • GlobalContribs
  • MessageCommons - does not call getId() on RevisionRecord
  • SpamBlacklist - does not call getId() on RevisionRecord
  • Wikibase: WikiPageEntityDataLoader passes DB ID, other calls are local
  • WikimediaMaintenance