Page MenuHomePhabricator

[S] Add preference to allow users to keep Special:Search as the default target for the skin search input widget
Closed, ResolvedPublic

Description

As an experienced user of Commons who prefers the Special:Search interface, I want a preference to keep that interface as the default target for the skin search input widget so that I can use my preferred interface when searching from the main search bar.

In T273879, we will be changing the skin search input widget to point to Special:MediaSearch. We want users to be able to revert the widget to point to Special:Search.

Acceptance Criteria:

  • A preference exists for users to keep the Special:Search interface as the default for the skin search input widget
  • The preference appears under preferences in the Search tab after the "Redirect to existing matches when searching" preference
  • The preference reads "[x] Show search results in the Special:Search interface", and should not be selected by default
  • Help text underneath the preference reads "Select to show search results from the main search bar in the older Special:Search interface instead of Special:MediaSearch"
  • This preference should apply both to the vector and default skins added comment: except for MinervaNeue
  • Also change the text for the "Don't show the Advanced Search interface" preference to say "Don't show the Advanced Search interface when using Special:Search"
  • A heading is added to the section of preferences that says "General" (see screenshot)

preferences.jpg (930×1 px, 214 KB)

Event Timeline

CBogen added a subscriber: mwilliams.

@mwilliams, I'd love if you could do a quick review of the wording and placement of the preferences in the description. Thanks!

Added a screenshot to the description, the one thing I think we could also update is adding a "header" to the top section of preferences since everything else has one and it felt a bit odd. I put "General" in there but I imagine we could think of something more specific.

CBogen renamed this task from Add preference to allow users to keep Special:Search as the default target for the skin search input widget to [S] Add preference to allow users to keep Special:Search as the default target for the skin search input widget.Feb 9 2021, 5:28 PM

FYI I removed the AC that mentioned changing the msg for Advanced Search - this message comes from a different extension, and we don't want to put MediaInfo-specific messaging in another extension

FYI I removed the AC that mentioned changing the msg for Advanced Search - this message comes from a different extension, and we don't want to put MediaInfo-specific messaging in another extension

I think it's confusing if we don't have this - a user would naturally wonder why they're being asked not to show advanced search for their search experience when that search experience doesn't even have advanced search. I don't think this is MediaInfo specific - it's just being more specific about what it refers to (Special:Search).

Change 672429 had a related patch set uploaded (by Cparle; owner: Cparle):
[mediawiki/extensions/AdvancedSearch@master] Update preference text

https://gerrit.wikimedia.org/r/672429

Change 672429 merged by jenkins-bot:
[mediawiki/extensions/AdvancedSearch@master] Update preference text

https://gerrit.wikimedia.org/r/672429

Etonkovidova added a subscriber: Etonkovidova.

Moving for @mwilliams review, but nothing is blocking from deployment. I'll check the production.

Should be the following issues addressed?
(1)

The preference appears under preferences in the Search tab after the "Redirect to existing matches when searching" preference

"Show search results in the Special:Search interface" appears below "Search autocomplete suggestions...":

Screen Shot 2021-03-22 at 4.57.02 PM.png (478×997 px, 80 KB)

(2)

This preference should apply both to the vector and default skins

The skins (Modern, Monobook, Timeless and Vector, of course) deal with the preference correctly. However, mobile (and accordingly, MinervaNeue skin) ignores the setting. Is that intentional or it's covered in subsequent phab tasks?

The preference appears under preferences in the Search tab after the "Redirect to existing matches when searching" preference

"Show search results in the Special:Search interface" appears below "Search autocomplete suggestions...":

Screen Shot 2021-03-22 at 4.57.02 PM.png (478×997 px, 80 KB)

This is fine because the "Search autocomplete suggestions..." preference is going to be removed shortly.

This preference should apply both to the vector and default skins

The skins (Modern, Monobook, Timeless and Vector, of course) deal with the preference correctly. However, mobile (and accordingly, MinervaNeue skin) ignores the setting. Is that intentional or it's covered in subsequent phab tasks?

This needs to be fixed; it should definitely apply to mobile. I'm going to move this back to ready for development (cc @Cparle)

Change 674618 had a related patch set uploaded (by Cparle; owner: Cparle):
[mediawiki/core@master] Allow public access to getter for default search page

https://gerrit.wikimedia.org/r/674618

Change 674619 had a related patch set uploaded (by Cparle; owner: Cparle):
[mediawiki/skins/MinervaNeue@master] Update search form to use the default search page from the skin

https://gerrit.wikimedia.org/r/674619

Change 674618 merged by jenkins-bot:
[mediawiki/core@master] Allow public access to getter for default search page

https://gerrit.wikimedia.org/r/674618

Change 674619 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Update search form to use the default search page from the skin

https://gerrit.wikimedia.org/r/674619

Resolved - the mobile issue will be addressed in T279057.