Page MenuHomePhabricator
Create Task
Maniphest T273979

[S] Add preference to allow users to keep Special:Search as the default target for the skin search input widget
Closed, ResolvedPublic
Actions

Description

As an experienced user of Commons who prefers the Special:Search interface, I want a preference to keep that interface as the default target for the skin search input widget so that I can use my preferred interface when searching from the main search bar.

In T273879, we will be changing the skin search input widget to point to Special:MediaSearch. We want users to be able to revert the widget to point to Special:Search.

Acceptance Criteria:

  • A preference exists for users to keep the Special:Search interface as the default for the skin search input widget
  • The preference appears under preferences in the Search tab after the "Redirect to existing matches when searching" preference
  • The preference reads "[x] Show search results in the Special:Search interface", and should not be selected by default
  • Help text underneath the preference reads "Select to show search results from the main search bar in the older Special:Search interface instead of Special:MediaSearch"
  • This preference should apply both to the vector and default skins added comment: except for MinervaNeue
  • Also change the text for the "Don't show the Advanced Search interface" preference to say "Don't show the Advanced Search interface when using Special:Search"
  • A heading is added to the section of preferences that says "General" (see screenshot)

preferences.jpg (930×1 px, 214 KB)

Details

SubjectRepoBranchLines +/-
Update search form to use the default search page from the skinmediawiki/skins/MinervaNeuemaster+2 -0
Allow public access to getter for default search pagemediawiki/coremaster+1 -1
Update preference textmediawiki/extensions/AdvancedSearchmaster+1 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

CBogen created this task.Feb 5 2021, 2:57 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 5 2021, 2:57 PM
CBogen updated the task description. (Show Details)Feb 5 2021, 2:58 PM
CBogen added a subscriber: mwilliams.

@mwilliams, I'd love if you could do a quick review of the wording and placement of the preferences in the description. Thanks!

CBogen added a parent task: T273879: [L] Take over the skin search input widget to submit to Special:MediaSearch.Feb 5 2021, 2:59 PM
CBogen edited projects, added Structured-Data-Backlog (Current Work); removed Structured-Data-Backlog.Feb 8 2021, 5:51 PM
CBogen moved this task from Incoming to Ready for Estimation on the Structured-Data-Backlog (Current Work) board.
mwilliams updated the task description. (Show Details)Feb 8 2021, 6:30 PM

Added a screenshot to the description, the one thing I think we could also update is adding a "header" to the top section of preferences since everything else has one and it felt a bit odd. I put "General" in there but I imagine we could think of something more specific.

CBogen updated the task description. (Show Details)Feb 8 2021, 7:20 PM
CBogen renamed this task from Add preference to allow users to keep Special:Search as the default target for the skin search input widget to [S] Add preference to allow users to keep Special:Search as the default target for the skin search input widget.Feb 9 2021, 5:28 PM
CBogen mentioned this in T273879: [L] Take over the skin search input widget to submit to Special:MediaSearch.
CBogen moved this task from Ready for Estimation to Blocked on the Structured-Data-Backlog (Current Work) board.Feb 9 2021, 5:37 PM
CBogen moved this task from Blocked to Ready for Development on the Structured-Data-Backlog (Current Work) board.Mar 2 2021, 6:20 PM
Cparle claimed this task.Mar 10 2021, 5:07 PM
Cparle moved this task from Ready for Development to Doing on the Structured-Data-Backlog (Current Work) board.Mar 10 2021, 5:14 PM
Cparle updated the task description. (Show Details)Mar 12 2021, 5:33 PM

FYI I removed the AC that mentioned changing the msg for Advanced Search - this message comes from a different extension, and we don't want to put MediaInfo-specific messaging in another extension

CBogen added a comment.Mar 12 2021, 7:15 PM
In T273979#6909151, @Cparle wrote:

FYI I removed the AC that mentioned changing the msg for Advanced Search - this message comes from a different extension, and we don't want to put MediaInfo-specific messaging in another extension

I think it's confusing if we don't have this - a user would naturally wonder why they're being asked not to show advanced search for their search experience when that search experience doesn't even have advanced search. I don't think this is MediaInfo specific - it's just being more specific about what it refers to (Special:Search).

Cparle updated the task description. (Show Details)Mar 15 2021, 2:47 PM
gerritbot added a comment.Mar 15 2021, 2:50 PM

Change 672429 had a related patch set uploaded (by Cparle; owner: Cparle):
[mediawiki/extensions/AdvancedSearch@master] Update preference text

https://gerrit.wikimedia.org/r/672429

gerritbot added a project: Patch-For-Review.Mar 15 2021, 2:50 PM
Cparle moved this task from Doing to Code Review on the Structured-Data-Backlog (Current Work) board.Mar 15 2021, 2:57 PM
gerritbot added a comment.Mar 16 2021, 12:54 PM

Change 672429 merged by jenkins-bot:
[mediawiki/extensions/AdvancedSearch@master] Update preference text

https://gerrit.wikimedia.org/r/672429

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.36; 2021-03-23).Mar 16 2021, 1:00 PM
Maintenance_bot removed a project: Patch-For-Review.Mar 16 2021, 1:10 PM
matthiasmullie moved this task from Code Review to Needs QA on the Structured-Data-Backlog (Current Work) board.Mar 17 2021, 12:58 PM
Etonkovidova updated the task description. (Show Details)Mar 22 2021, 11:50 PM
Etonkovidova moved this task from Needs QA to Design QA on the Structured-Data-Backlog (Current Work) board.Mar 23 2021, 12:02 AM
Etonkovidova subscribed.

Moving for @mwilliams review, but nothing is blocking from deployment. I'll check the production.

Should be the following issues addressed?
(1)

The preference appears under preferences in the Search tab after the "Redirect to existing matches when searching" preference

"Show search results in the Special:Search interface" appears below "Search autocomplete suggestions...":

Screen Shot 2021-03-22 at 4.57.02 PM.png (478×997 px, 80 KB)

(2)

This preference should apply both to the vector and default skins

The skins (Modern, Monobook, Timeless and Vector, of course) deal with the preference correctly. However, mobile (and accordingly, MinervaNeue skin) ignores the setting. Is that intentional or it's covered in subsequent phab tasks?

CBogen added a comment.Mar 23 2021, 6:14 PM

The preference appears under preferences in the Search tab after the "Redirect to existing matches when searching" preference

"Show search results in the Special:Search interface" appears below "Search autocomplete suggestions...":

Screen Shot 2021-03-22 at 4.57.02 PM.png (478×997 px, 80 KB)

This is fine because the "Search autocomplete suggestions..." preference is going to be removed shortly.

This preference should apply both to the vector and default skins

The skins (Modern, Monobook, Timeless and Vector, of course) deal with the preference correctly. However, mobile (and accordingly, MinervaNeue skin) ignores the setting. Is that intentional or it's covered in subsequent phab tasks?

This needs to be fixed; it should definitely apply to mobile. I'm going to move this back to ready for development (cc @Cparle)

CBogen moved this task from Design QA to Ready for Development on the Structured-Data-Backlog (Current Work) board.Mar 23 2021, 6:14 PM
Cparle moved this task from Ready for Development to Doing on the Structured-Data-Backlog (Current Work) board.Mar 24 2021, 2:19 PM
gerritbot added a comment.Mar 24 2021, 2:21 PM

Change 674618 had a related patch set uploaded (by Cparle; owner: Cparle):
[mediawiki/core@master] Allow public access to getter for default search page

https://gerrit.wikimedia.org/r/674618

gerritbot added a project: Patch-For-Review.Mar 24 2021, 2:21 PM
gerritbot added a comment.Mar 24 2021, 2:24 PM

Change 674619 had a related patch set uploaded (by Cparle; owner: Cparle):
[mediawiki/skins/MinervaNeue@master] Update search form to use the default search page from the skin

https://gerrit.wikimedia.org/r/674619

Cparle moved this task from Doing to Code Review on the Structured-Data-Backlog (Current Work) board.Mar 24 2021, 2:27 PM
CBogen mentioned this in T278368: Measure percentage of Commons users opting out of MediaSearch as the default search experience.Mar 24 2021, 6:42 PM
gerritbot added a comment.Mar 24 2021, 7:06 PM

Change 674618 merged by jenkins-bot:
[mediawiki/core@master] Allow public access to getter for default search page

https://gerrit.wikimedia.org/r/674618

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.37; 2021-03-30); removed MW-1.36-notes (1.36.0-wmf.36; 2021-03-23).Mar 24 2021, 8:00 PM
gerritbot added a comment.Mar 25 2021, 12:57 PM

Change 674619 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Update search form to use the default search page from the skin

https://gerrit.wikimedia.org/r/674619

matthiasmullie moved this task from Code Review to Needs QA on the Structured-Data-Backlog (Current Work) board.Mar 30 2021, 2:52 PM
Etonkovidova moved this task from Needs QA to Verify on Production on the Structured-Data-Backlog (Current Work) board.Mar 30 2021, 3:00 PM
Etonkovidova updated the task description. (Show Details)Mar 31 2021, 9:21 PM
Restricted Application added a subscriber: Masumrezarock100. · View Herald TranscriptMar 31 2021, 9:21 PM
Etonkovidova closed this task as Resolved.Apr 5 2021, 4:51 PM

Resolved - the mobile issue will be addressed in T279057.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits