Page MenuHomePhabricator

Invalid VisualEditorFeatureUse events
Closed, ResolvedPublic

Description

Roughly 2,500 events per day are missing the required field editingSessionId, which causes the events to be thrown out. I don't see an obvious pattern in which actions exhibit this problem.

In T275553, @Ottomata wrote:

Lots of these:

https://logstash.wikimedia.org/goto/5d8fd1015078e54b40bb40527c736b99

'editingSessionId' is a required property

Event Timeline

awight set the point value for this task to 1.Feb 17 2021, 5:27 PM
awight updated the task description. (Show Details)
awight removed the point value for this task.

There does seem to be a useful pattern: "integration": "discussiontools" was present on every event I checked. I suspect that this means there's a path to a VisualEditorFeatureUse event firing before the first EditAttemptStep init event, which is normally what would generate the sessionid.

Change 666451 had a related patch set uploaded (by DLynch; owner: DLynch):
[mediawiki/extensions/DiscussionTools@master] Change generation of logging session ID

https://gerrit.wikimedia.org/r/666451

Change 666451 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@master] Change generation of logging session ID

https://gerrit.wikimedia.org/r/666451

matmarex added a subscriber: matmarex.

To be checked in the logs using the provided query.

I should note that I couldn't actually reproduce triggering a VisualEditorFeatureUse event which didn't have a session id, so this being the cause is largely speculation. Still, absent some really weird case I think this should fix any possible route to such an event being generated.

To be checked in the logs using the provided query.

We will check this the week of 8-March-2021.

Checking the logstash search, these errors appear to have stopped as of March 4th -- i.e. as of the last train deploy to group2.

FYI, yesterday VisualEditorFeatureUse and EditAttemptStep have been migrated to Event Platform (T267353, T267343), so the logstash search for their errors has changed. Use this logstash dashboard.

Validation errors are now also monitor-able in Grafana too.

Well, the error did disappear before that, and I can't find any for VisualEditorFeatureUse on that new dashboard, so presumably my conclusion holds up...

Well, the error did disappear before that, and I can't find any for VisualEditorFeatureUse on that new dashboard, so presumably my conclusion holds up...

Thank you for verifying this, David.