Page MenuHomePhabricator

Discussion Tools causes TemplateStyles to be empty in certain cases on pages without section headings
Closed, ResolvedPublic

Description

Discussion Tools causes TemplateStyles to be empty in certain cases on pages without section headings. As a result, some templates don't appear correctly.

Splitting off from T270009.

Example affected page: https://nl.wikipedia.org/wiki/Overleg_gebruiker:Thomas~nlwiki


Expected rendering should look like on this page: https://nl.wikipedia.org/wiki/Overleg_gebruiker:FQuist

16, 17

Re-opened, it seems that a regression happened. Same symptom on some user pages: link 16 above looks fine to me, but not link 17.

Also noticed on huwiki: Szerkesztővita:Merkl.otto and Szerkesztővita:Merkl, on both pages the In memoriam… ({{gyász}}) template lacks styling.

Event Timeline

Change 666215 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/DiscussionTools@master] CommentFormatter: Fix inserting placeholder heading marker

https://gerrit.wikimedia.org/r/666215

Esanders added a project: Editing QA.
Esanders added a subscriber: Esanders.

@matmarex can you clean up the testing instructions?

Change 666215 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@master] CommentFormatter: Fix inserting placeholder heading marker

https://gerrit.wikimedia.org/r/666215