Change api cache ttl to be an .env var
Closed, ResolvedPublic3 Estimated Story Points
Actions

Assigned To

Authored By

	dmaza
	Feb 25 2021, 6:52 AM

Description

Cache TTL is hardcoded in src/Util/Api.php.

Reason for this change:

We were having production issues where the VPS was running out of disk space and there was no easy way to change this setting
Is a good practice to have this kind of values as part of the config or environment for easy tweaking

Acceptance criteria

Move ttl value to an .env variable so it can be easily adjustable

Event Timeline

dmaza created this task.Feb 25 2021, 6:52 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 25 2021, 6:52 AM

PR: https://github.com/wikimedia/ws-export/pull/336

dmaza moved this task from Ready 🎬 to Review/Feedback 💬 on the Community-Tech (Kanban-2020-21-Q3) board.Feb 25 2021, 6:53 AM

ARamirez_WMF set the point value for this task to 3.Feb 25 2021, 6:08 PM

Samwilson moved this task from Review/Feedback 💬 to QA 🐛 on the Community-Tech (Kanban-2020-21-Q3) board.Feb 26 2021, 1:53 AM

The default cache time is now 6 hours, and I've updated the pruning cronjob to also run at 6 hour intervals.

I don't think there's anything much to QA here.

Samwilson set Final Story Points to 3.Feb 26 2021, 2:02 AM

Xover renamed this task from Change api cache ttl to be an .evn var to Change api cache ttl to be an .env var.Feb 26 2021, 10:34 AM

In T275735#6863306, @Samwilson wrote:

The default cache time is now 6 hours, and I've updated the pruning cronjob to also run at 6 hour intervals.

I don't think there's anything much to QA here.

I agree. As of now (and for posterity), disk utilization is at ~16% (5.3G). I'll keep an eye on the reports and we'll tweak if necessary.

Aklapper removed a subscriber: Community-Tech.Mar 2 2021, 7:03 AM

In T275735#6865487, @dmaza wrote:

In T275735#6863306, @Samwilson wrote:

The default cache time is now 6 hours, and I've updated the pruning cronjob to also run at 6 hour intervals.

I don't think there's anything much to QA here.

I agree. As of now (and for posterity), disk utilization is at ~16% (5.3G). I'll keep an eye on the reports and we'll tweak if necessary.

Thanks. I will move this along then as there is nothing for me to do.

Nothing user-facing to test here. I'm marking this as Done.

Change api cache ttl to be an .env varClosed, ResolvedPublic3 Estimated Story PointsActions

Description

Event Timeline

Change api cache ttl to be an .env var
Closed, ResolvedPublic3 Estimated Story Points
Actions