Page MenuHomePhabricator
Create Task
Maniphest T276164

Opening special character toolbar moves the cursor to [1,1]
Closed, ResolvedPublic
Actions

Description

  1. Place your cursor in the middle of the page
  2. Open the special character toolbar
  3. Observer your cursor jumps to the start of the document

Expected:

  1. Cursor stays where it was, and you can continue typing

Details

SubjectRepoBranchLines +/-
Update VE core submodule to master (6c46defab)mediawiki/extensions/VisualEditormaster+1 -1
ve.ui.SpecialCharacterDialog: Keep selection when opening the dialogVisualEditor/VisualEditormaster+6 -0
Only apply toolbar focus hack to surfaces that clear selection on blurVisualEditor/VisualEditormaster+28 -26
Customize query in gerrit

Related Objects

Event Timeline

Esanders created this task.Mar 1 2021, 8:17 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 1 2021, 8:17 PM
Esanders added a subscriber: matmarex.Mar 1 2021, 8:20 PM

Bisect blames https://gerrit.wikimedia.org/r/c/VisualEditor/VisualEditor/+/651722, sorry @matmarex

Esanders mentioned this in T249072: Add support in toolbar for special characters within DiscussionTools.Mar 1 2021, 8:20 PM
matmarex claimed this task.Mar 1 2021, 8:21 PM

Hmm.

Esanders added a comment.Mar 1 2021, 8:23 PM
This comment was removed by Esanders.
matmarex added a comment.Mar 1 2021, 11:08 PM

The bug occurs with the special character toolbar because it tries to focus the surface in ve.ui.SpecialCharacterDialog.prototype.getReadyProcess(), which is necessary because OO.ui.Window.prototype.ready() focusses the window itself.

I don't understand why this conflicts with the changes from 651722, but the issue disappears if I comment out either the line this.$content.trigger( 'focus' ); in ready(), or this.surface.getView().focus(); in getReadyProcess().

matmarex moved this task from To Triage to Triaged on the VisualEditor board.Mar 2 2021, 1:02 PM
matmarex added a project: Editing-team (Kanban Board).
matmarex mentioned this in T275650: Page corruption: The first template on the page is being replaced by a citation template.
gerritbot added a comment.Mar 2 2021, 1:06 PM

Change 667853 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[VisualEditor/VisualEditor@master] ve.ui.SpecialCharacterDialog: Keep selection when opening the dialog

https://gerrit.wikimedia.org/r/667853

gerritbot added a project: Patch-For-Review.Mar 2 2021, 1:06 PM

Change 667854 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[VisualEditor/VisualEditor@master] Only apply toolbar focus hack to surfaces that clear selection on blur

https://gerrit.wikimedia.org/r/667854

matmarex moved this task from Incoming to Code Review on the Editing-team (Kanban Board) board.Mar 2 2021, 1:17 PM

That fixes it, but I still don't really understand why the issue happens. I've already spent nearly two days on this, and there ar probably other things I should be working on.

dchan claimed this task.Mar 2 2021, 4:47 PM
PatchDemoBot added a comment.Mar 2 2021, 6:29 PM

Test wiki created on Patch Demo by JKlein (WMF) using patch(es) linked to this task:

https://patchdemo.wmflabs.org/wikis/d097865dbe44111d99feb62a8237c1a7/w/

gerritbot added a comment.Mar 8 2021, 9:44 PM

Change 667853 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] ve.ui.SpecialCharacterDialog: Keep selection when opening the dialog

https://gerrit.wikimedia.org/r/667853

gerritbot added a comment.Mar 8 2021, 9:44 PM

Change 667854 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Only apply toolbar focus hack to surfaces that clear selection on blur

https://gerrit.wikimedia.org/r/667854

Maintenance_bot removed a project: Patch-For-Review.Mar 8 2021, 10:10 PM
gerritbot added a comment.Mar 8 2021, 10:42 PM

Change 669997 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (6c46defab)

https://gerrit.wikimedia.org/r/669997

gerritbot added a project: Patch-For-Review.Mar 8 2021, 10:42 PM
gerritbot added a comment.Mar 8 2021, 11:15 PM

Change 669997 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (6c46defab)

https://gerrit.wikimedia.org/r/669997

matmarex claimed this task.Mar 8 2021, 11:21 PM
matmarex edited projects, added Editing QA; removed Patch-For-Review.
matmarex moved this task from Code Review to QA on the Editing-team (Kanban Board) board.
matmarex updated the task description. (Show Details)
matmarex added a subscriber: dchan.
ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.34; 2021-03-09).Mar 9 2021, 12:00 AM
Ryasmeen edited projects, added Verified; removed Editing QA.Mar 10 2021, 11:36 PM
matmarex moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.Mar 11 2021, 7:42 PM
ppelberg closed this task as Resolved.Mar 16 2021, 12:57 AM
PatchDemoBot added a comment.Nov 12 2021, 2:10 PM

Test wiki on Patch Demo by JKlein (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/d097865dbe44111d99feb62a8237c1a7/w/

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits