Page MenuHomePhabricator

Convert ChooseBallot to use OOUI
Closed, ResolvedPublic3 Estimated Story Points

Description

As part of T273044: Convert SecurePoll VotePage to use OOUI, this included ballot will need to return an OOUI object. You should check the getForm and getQuestionForm functions. VotePage.php calls getForm which calls getQuestionForm.

Event Timeline

Change 674364 had a related patch set uploaded (by Wikitrent; owner: Wikitrent):
[mediawiki/extensions/SecurePoll@master] Convert ChooseBallot to OOUI

https://gerrit.wikimedia.org/r/674364

Niharika set the point value for this task to 3.Mar 24 2021, 4:50 PM

Change 674364 merged by jenkins-bot:
[mediawiki/extensions/SecurePoll@master] Convert ChooseBallot to OOUI

https://gerrit.wikimedia.org/r/674364

dom_walden added a subscriber: dom_walden.

Plurality vote before the change (ignore the title of the election, it is wrong :P):

plurality_before.png (402×1 px, 38 KB)

After the change:

plurality_after.png (460×1 px, 39 KB)

I compared the HTML before and after and it looked fine to me.

I also checked that how the results are recorded in the database were the same before and after.

Test Environment: local docker (sqlite) SecurePoll 2.0.0 (ed8bc5e) 06:37, 29 March 2021.