Page MenuHomePhabricator

Convert RadioRangeCommentBallot to use OOUI
Closed, ResolvedPublic3 Estimated Story Points

Description

As part of T273044: Convert SecurePoll VotePage to use OOUI, this included ballot will need to return an OOUI object. You should check the getForm and getQuestionForm functions. VotePage.php calls getForm which calls getQuestionForm.

Event Timeline

Change 674450 had a related patch set uploaded (by TsepoThoabala; owner: TsepoThoabala):
[mediawiki/extensions/SecurePoll@master] Convert RadioRangeCommentBallot to use OOUI

https://gerrit.wikimedia.org/r/674450

Change 674450 merged by jenkins-bot:
[mediawiki/extensions/SecurePoll@master] Convert RadioRangeCommentBallot to use OOUI

https://gerrit.wikimedia.org/r/674450

Niharika set the point value for this task to 3.Mar 24 2021, 4:50 PM
dom_walden added a subscriber: dom_walden.

The voting page before:

range_plurality_comment_before.png (735×1 px, 40 KB)

The voting page after:

range_plurality_comment_after.png (841×1 px, 41 KB)

I submitted a vote and checked the comments were correctly recorded in the database. Did this for a vote of type "Range Voting (plurality) with comment" and "Range Voting (histogram range) with comment".

I compare the HTML of the voting page before and after, and it looked reasonable to me.

Test Environment: https://vote.wikimedia.beta.wmflabs.org SecurePoll 2.0.0 (02f6c7e) 07:41, 25 March 2021.