Page MenuHomePhabricator
Create Task
Maniphest T277094

Bug in client error logging stops any errors from being logged in group 0 wikis
Closed, ResolvedPublic
Actions

Description

The new method shouldLog returns false if shouldLogFileUrl returns true.
AS a result of this no errors are being logged in group 0 wikis

IT should be the other way round.

We should fix this before rolling the train further.

Details

SubjectRepoBranchLines +/-
Fix client error loggingmediawiki/extensions/WikimediaEventswmf/1.36.0-wmf.34+7 -8
clientError: Restore client error logging outputmediawiki/extensions/WikimediaEventsmaster+7 -8
Revert "Error in shouldLog logic drops most errors"mediawiki/extensions/WikimediaEventswmf/1.36.0-wmf.34+1 -1
Error in shouldLog logic drops most errorsmediawiki/extensions/WikimediaEventsmaster+1 -1
Error in shouldLog logic drops most errorsmediawiki/extensions/WikimediaEventswmf/1.36.0-wmf.34+1 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jdlrobson created this task.Mar 10 2021, 7:58 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 10 2021, 7:58 PM
gerritbot added a comment.Mar 10 2021, 7:59 PM

Change 670569 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/WikimediaEvents@master] Error in shouldLog logic drops most errors

https://gerrit.wikimedia.org/r/670569

gerritbot added a project: Patch-For-Review.Mar 10 2021, 7:59 PM
Jdlrobson triaged this task as Unbreak Now! priority.Mar 10 2021, 7:59 PM
gerritbot added a comment.Mar 10 2021, 8:04 PM

Change 670569 merged by jenkins-bot:
[mediawiki/extensions/WikimediaEvents@master] Error in shouldLog logic drops most errors

https://gerrit.wikimedia.org/r/670569

gerritbot added a comment.Mar 10 2021, 8:05 PM

Change 670529 had a related patch set uploaded (by DannyS712; owner: Jdlrobson):
[mediawiki/extensions/WikimediaEvents@wmf/1.36.0-wmf.34] Error in shouldLog logic drops most errors

https://gerrit.wikimedia.org/r/670529

Jdlrobson added a project: Web-Team-Backlog (Kanbanana-FY-2020-21).Mar 10 2021, 8:10 PM
Jdlrobson moved this task from Needs Analysis to Ready for Signoff on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.Mar 10 2021, 8:17 PM
gerritbot added a comment.Mar 10 2021, 8:18 PM

Change 670529 merged by jenkins-bot:
[mediawiki/extensions/WikimediaEvents@wmf/1.36.0-wmf.34] Error in shouldLog logic drops most errors

https://gerrit.wikimedia.org/r/670529

RhinosF1 subscribed.Mar 10 2021, 8:28 PM
brennen added a parent task: T274938: 1.36.0-wmf.34 deployment blockers.Mar 10 2021, 8:35 PM
brennen added a project: User-brennen.
Stashbot added a comment.Mar 10 2021, 8:41 PM

Mentioned in SAL (#wikimedia-operations) [2021-03-10T20:41:54Z] <brennen@deploy1002> Synchronized php-1.36.0-wmf.34/extensions/WikimediaEvents/modules/ext.wikimediaEvents/clientError.js: Backport: [[gerrit:670529|Error in shouldLog logic drops most errors (T277094)]] (duration: 01m 14s)

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.34; 2021-03-09).Mar 10 2021, 9:00 PM
brennen mentioned this in T274938: 1.36.0-wmf.34 deployment blockers.Mar 10 2021, 9:15 PM
gerritbot added a comment.Mar 10 2021, 9:27 PM

Change 670533 had a related patch set uploaded (by Urbanecm; owner: Urbanecm):
[mediawiki/extensions/WikimediaEvents@wmf/1.36.0-wmf.34] Revert "Error in shouldLog logic drops most errors"

https://gerrit.wikimedia.org/r/670533

Stashbot added a comment.Mar 10 2021, 9:30 PM

Mentioned in SAL (#wikimedia-operations) [2021-03-10T21:30:08Z] <brennen> train status: 1.36.0-wmf.34 (T274938): logstash client error board was set up incorrectly; reverting earlier patch for T277094 and will proceed to group1.

gerritbot added a comment.Mar 10 2021, 9:34 PM

Change 670533 merged by jenkins-bot:
[mediawiki/extensions/WikimediaEvents@wmf/1.36.0-wmf.34] Revert "Error in shouldLog logic drops most errors"

https://gerrit.wikimedia.org/r/670533

Stashbot added a comment.Mar 10 2021, 9:40 PM

Mentioned in SAL (#wikimedia-operations) [2021-03-10T21:40:51Z] <brennen@deploy1002> Synchronized php-1.36.0-wmf.34/extensions/WikimediaEvents/modules/ext.wikimediaEvents/clientError.js: Backport: [[gerrit:670533|Revert "Error in shouldLog logic drops most errors" (T277094)]] (duration: 01m 08s)

Stashbot added a comment.Mar 10 2021, 9:43 PM

Mentioned in SAL (#wikimedia-operations) [2021-03-10T21:43:22Z] <brennen> train status: 1.36.0-wmf.34 (T274938): client errors may still be missing for group0; continuing to hold for T277094 until we know what's broken.

gerritbot added a comment.Mar 10 2021, 9:51 PM

Change 670585 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/WikimediaEvents@master] Fix client error logging

https://gerrit.wikimedia.org/r/670585

gerritbot added a comment.Mar 10 2021, 9:58 PM

Change 670535 had a related patch set uploaded (by Brennen Bearnes; owner: Jdlrobson):
[mediawiki/extensions/WikimediaEvents@wmf/1.36.0-wmf.34] Fix client error logging

https://gerrit.wikimedia.org/r/670535

Jdforrester-WMF subscribed.Mar 10 2021, 10:00 PM
gerritbot added a comment.Mar 10 2021, 10:19 PM

Change 670535 merged by jenkins-bot:
[mediawiki/extensions/WikimediaEvents@wmf/1.36.0-wmf.34] Fix client error logging

https://gerrit.wikimedia.org/r/670535

Stashbot added a comment.Mar 10 2021, 10:25 PM

Mentioned in SAL (#wikimedia-operations) [2021-03-10T22:25:16Z] <brennen@deploy1002> Synchronized php-1.36.0-wmf.34/extensions/WikimediaEvents/modules/ext.wikimediaEvents/clientError.js: Backport: [[gerrit:670535|Fix client error logging (T277094)]] (duration: 01m 09s)

Stashbot added a comment.Mar 10 2021, 10:26 PM

Mentioned in SAL (#wikimedia-operations) [2021-03-10T22:26:37Z] <brennen> train status: 1.36.0-wmf.34 (T274938): T277094 believed resolved, promoting to group1.

Jdlrobson moved this task from Ready for Signoff to Code Review on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.Mar 10 2021, 10:47 PM

Discovered we were dropping errors (around 500) for group 0 wikis due to eventgate_validation_error :
https://logstash.wikimedia.org/app/dashboards#/view/AXN5OoJu3_NNwgAUlbUT?_g=h@0e494b1&_a=h@ab7de48

Screen Shot 2021-03-10 at 2.17.07 PM.png (1×2 px, 246 KB)

The message was incorrectly being passed (due to type checking problem - something that typescript would help us with)
Rather than blocking the train we backported the fix to wmf34. Leaving as UBN as https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikimediaEvents/+/670585 still needs to be merged.

Agusbou2015 subscribed.Mar 11 2021, 1:29 PM
Krinkle reassigned this task from Krinkle to Jdlrobson.Mar 11 2021, 4:00 PM
brennen moved this task from Backlog to Logs/Train on the User-brennen board.Mar 11 2021, 5:15 PM
brennen removed a parent task: T274938: 1.36.0-wmf.34 deployment blockers.
brennen added a parent task: T274939: 1.36.0-wmf.35 deployment blockers.
brennen subscribed.

Removing as a blocker for wmf.34 and adding for wmf.35, since it's been handled with the backport for .34.

gerritbot added a comment.Mar 11 2021, 10:05 PM

Change 670585 merged by jenkins-bot:
[mediawiki/extensions/WikimediaEvents@master] clientError: Restore client error logging output

https://gerrit.wikimedia.org/r/670585

Jdlrobson moved this task from Code Review to Ready for Signoff on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.Mar 11 2021, 10:07 PM
ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.35; 2021-03-16); removed MW-1.36-notes (1.36.0-wmf.34; 2021-03-09).Mar 11 2021, 11:00 PM
Jdlrobson lowered the priority of this task from Unbreak Now! to Needs Triage.Mar 12 2021, 3:22 PM
Jdlrobson closed this task as Resolved.Mar 12 2021, 5:08 PM

We are seeing errors for all group wikis now.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits