Background
Targets Occurrences of '(white|black)[ \-]?list' in Directory /Users/reedy/PhpstormProjects/mediawiki/extensions/PageImages Found Occurrences (26 usages found) extensions (26 usages found) PageImages (26 usages found) i18n (2 usages found) en.json (1 usage found) 6 "pageimages-blacklist": "", qqq.json (1 usage found) 9 "pageimages-blacklist": "{{notranslate}}\nList of images. They will never be selected as page images", includes (16 usages found) Hooks (16 usages found) LinksUpdateHookHandler.php (16 usages found) 159 $blacklist = $this->getBlacklist(); 160 if ( isset( $blacklist[$image->getFileName()] ) ) { 249 * Returns a list of images blacklisted from influencing this extension's output 254 protected function getBlacklist() { 255 global $wgPageImagesBlacklistExpiry; 260 $cache->makeKey( 'pageimages-blacklist' ), 261 $wgPageImagesBlacklistExpiry, 263 global $wgPageImagesBlacklist; 266 foreach ( $wgPageImagesBlacklist as $source ) { 271 $this->getDbBlacklist( $source['db'], $source['page'] ) 277 $this->getUrlBlacklist( $source['url'] ) 282 "unrecognized image blacklist type '{$source['type']}'" 293 * Returns list of images linked by the given blacklist page 300 private function getDbBlacklist( $dbName, $page ) { 327 * Returns list of images on given remote blacklist page. 335 private function getUrlBlacklist( $url ) { tests (5 usages found) phpunit (5 usages found) Hooks (5 usages found) LinksUpdateHookHandlerTest.php (5 usages found) 231 ->setMethods( [ 'scoreFromTable', 'getMetadata', 'getRatio', 'getBlacklist' ] ) 241 ->method( 'getBlacklist' ) 242 ->willReturn( [ 'blacklisted.jpg' => 1 ] ); 279 [ 'filename' => 'blacklisted.jpg', 'fullwidth' => 100 ], 282 // blacklist score extension.json (3 usages found) 68 "PageImagesBlacklist": { 72 "page": "MediaWiki:Pageimages-blacklist", 77 "PageImagesBlacklistExpiry": {
Acceptance criteria
- Change naming to "allowlist" and "denylist"