Page MenuHomePhabricator

Remove obsolete `-moz-` prefixed rules and properties (`-moz-keyframes`, `-moz-animation` & `-moz-transition`…) across skins & extensions
Open, Needs TriagePublic

Description

With Firefox 4-26 fallen out of basic browser support in T266866, those prefixes have become obsolete.

Also, in spare cases remove prefixed properties that should have been gone for a while alongside the obsolete -moz ones, like -webkit-border-radius

Note, extensions

  • DonationInterface,
  • FundraisingEmailUnsubscribe and
  • mobileApps (it's relying on an old mediawiki.mixins.less version and is to be updated by MobileApps infrastructure team like in earlier times)

are not touched, as HTML in email is a mess and the CSS code is in no way comparable to any of the other extensions standards-wise.

Dev notes

Removal of

  • -moz-keyframes
  • -moz-animation
  • -moz-transform
  • -moz-transition
  • -moz-linear-gradient
  • Flexbox 2009 spec properties (around *box*)

Search.

Results, manually pruned to ignore upstream libraries and irrelevant results (updated to remove DonationInterface):

[ ] MediaWiki core (2 files)
** [[https://gerrit.wikimedia.org/g/mediawiki/core/+/a38aa2036097da92cd6899d87954be461aae79e8/resources/src/mediawiki.widgets/mw.widgets.DateInputWidget.styles.less|resources/src/mediawiki.widgets/mw.widgets.DateInputWidget.styles.less]] (1 matches)
[ ] WikimediaDebug (1 files)
** [[https://gerrit.wikimedia.org/g/performance/WikimediaDebug/+/5c4b7e3fd6ea491c69918667478b33e2d74c0166/popup.css|popup.css]] (1 matches)
[ ] mediawiki/extensions/Collection (1 files)
** [[https://gerrit.wikimedia.org/g/mediawiki/extensions/Collection/+/ebd8579c5340d08c614bffbdeba1892706f828da/resources/ext.collection.bookcreator.styles/bookcreator.less|resources/ext.collection.bookcreator.styles/bookcreator.less]] (1 matches)
[ ] mediawiki/extensions/CommonsMetadata (1 files)
** [[https://gerrit.wikimedia.org/g/mediawiki/extensions/CommonsMetadata/+/53a3d8c7fe65e3ddeaa3f7f1306e41ca348f32c0/tests/html/File_Sikh_pilgrim_at_the_Golden_Temple_(Harmandir_Sahib)_in_Amritsar,_India.jpg.html|tests/html/File_Sikh_pilgrim_at_the_Golden_Temple_(Harmandir_Sahib)_in_Amritsar,_India.jpg.html]] (1 matches)
** 
[ ] mediawiki/extensions/PageTriage (1 files)
** [[https://gerrit.wikimedia.org/g/mediawiki/extensions/PageTriage/+/ce0915919f8e363ffa9cadab9b6fddfe4c98a6ac/modules/ext.pageTriage.views.toolbar/ToolbarView.css|modules/ext.pageTriage.views.toolbar/ToolbarView.css]] (1 matches)
[ ] mediawiki/extensions/Score (1 files)
** [[https://gerrit.wikimedia.org/g/mediawiki/extensions/Score/+/708dc03e1648638528d4cbbc2344234efc7ed4d4/modules/ext.score.popup/popup.css|modules/ext.score.popup/popup.css]] (1 matches)
[ ] mediawiki/extensions/VisualEditor (3 files)
** [[https://gerrit.wikimedia.org/g/mediawiki/extensions/VisualEditor/+/787bc0db172a6a0434dfee162c7a8693adff97ef/modules/ve-mw/ui/styles/dialogs/ve.ui.MWGalleryDialog.css|modules/ve-mw/ui/styles/dialogs/ve.ui.MWGalleryDialog.css]] (1 matches)
** [[https://gerrit.wikimedia.org/g/mediawiki/extensions/VisualEditor/+/787bc0db172a6a0434dfee162c7a8693adff97ef/modules/ve-mw/ui/styles/dialogs/ve.ui.MWTransclusionDialog.css|modules/ve-mw/ui/styles/dialogs/ve.ui.MWTransclusionDialog.css]] (1 matches)
** [[https://gerrit.wikimedia.org/g/mediawiki/extensions/VisualEditor/+/787bc0db172a6a0434dfee162c7a8693adff97ef/modules/ve-mw/ui/styles/widgets/ve.ui.MWMediaInfoFieldWidget.css|modules/ve-mw/ui/styles/widgets/ve.ui.MWMediaInfoFieldWidget.css]] (1 matches)
[ ] mediawiki/extensions/Wikibase (1 files)
** [[https://gerrit.wikimedia.org/g/mediawiki/extensions/WikidataPageBanner/+/9c72b850b24b7221572c4a4d542e6de6017b6b33/resources/ext.WikidataPageBanner.styles/ext.WikidataPageBanner.less|resources/ext.WikidataPageBanner.styles/ext.WikidataPageBanner.less]] (1 matches)
[ ] mediawiki/extensions/wikihiero (1 files)

Details

ProjectBranchLines +/-Subject
mediawiki/coremaster+0 -2
mediawiki/coreREL1_37+6 -11
mediawiki/coremaster+6 -11
mediawiki/extensions/Wikibasemaster+0 -5
mediawiki/extensions/wikihieromaster+0 -6
mediawiki/extensions/Mathmaster+0 -1
mediawiki/extensions/WikibaseMediaInfomaster+1 -9
mediawiki/extensions/MediaSearchmaster+0 -8
mediawiki/extensions/VisualEditormaster+1 -1
VisualEditor/VisualEditormaster+0 -21
mediawiki/extensions/CentralAuthmaster+0 -30
mediawiki/extensions/VisualEditormaster+0 -10
mediawiki/extensions/Kartographermaster+2 -15
mediawiki/extensions/GWToolsetmaster+0 -5
mediawiki/extensions/ContentTranslationmaster+0 -14
mediawiki/extensions/Flowmaster+2 -22
mediawiki/extensions/WikimediaMessagesmaster+5 -34
mediawiki/extensions/MultimediaViewermaster+1 -19
mediawiki/extensions/Popupsmaster+0 -22
mediawiki/skins/Miragemaster+9 -42
mediawiki/extensions/CentralNoticemaster+1 -2
mediawiki/skins/MinervaNeuemaster+0 -1
mediawiki/extensions/CollaborationKitmaster+0 -2
mediawiki/extensions/GrowthExperimentsmaster+0 -2
mediawiki/extensions/GuidedTourmaster+0 -100
mediawiki/extensions/RevisionSlidermaster+0 -13
mediawiki/extensions/Citoidmaster+0 -1
mediawiki/extensions/AdvancedSearchmaster+0 -23
Show related patches Customize query in gerrit

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

Change 675451 had a related patch set uploaded (by VolkerE; author: VolkerE):
[mediawiki/extensions/AdvancedSearch@master] styles: Remove obsolete -moz-keyframes vendor prefixed rules

https://gerrit.wikimedia.org/r/675451

Change 675457 had a related patch set uploaded (by VolkerE; author: VolkerE):
[mediawiki/extensions/CentralNotice@master] styles: Remove obsolete -moz- vendor prefixed rules

https://gerrit.wikimedia.org/r/675457

Change 675451 merged by jenkins-bot:
[mediawiki/extensions/AdvancedSearch@master] styles: Remove obsolete -moz-keyframes vendor prefixed rules

https://gerrit.wikimedia.org/r/675451

Change 675461 had a related patch set uploaded (by VolkerE; author: VolkerE):
[mediawiki/extensions/Citoid@master] styles: Remove obsolete -moz- vendor prefixed properties

https://gerrit.wikimedia.org/r/675461

Change 675464 had a related patch set uploaded (by VolkerE; author: VolkerE):
[mediawiki/extensions/CollaborationKit@master] styles: Remove obsolete -moz- vendor prefixed properties

https://gerrit.wikimedia.org/r/675464

Change 675465 had a related patch set uploaded (by VolkerE; author: VolkerE):
[mediawiki/extensions/GrowthExperiments@master] styles: Remove obsolete vendor prefixed properties

https://gerrit.wikimedia.org/r/675465

Change 675466 had a related patch set uploaded (by VolkerE; author: VolkerE):
[mediawiki/extensions/GuidedTour@master] styles: Remove obsolete vendor prefixed rules & properties

https://gerrit.wikimedia.org/r/675466

Change 675468 had a related patch set uploaded (by VolkerE; author: VolkerE):
[mediawiki/extensions/GWToolset@master] styles: Remove obsolete vendor prefixed properties

https://gerrit.wikimedia.org/r/675468

Change 675474 had a related patch set uploaded (by VolkerE; author: VolkerE):
[mediawiki/extensions/Kartographer@master] styles: Remove obsolete vendor prefixed properties

https://gerrit.wikimedia.org/r/675474

Change 675461 merged by jenkins-bot:
[mediawiki/extensions/Citoid@master] styles: Remove obsolete -moz- vendor prefixed properties

https://gerrit.wikimedia.org/r/675461

Change 675475 had a related patch set uploaded (by VolkerE; author: VolkerE):
[mediawiki/extensions/MultimediaViewer@master] styles: Remove obsolete vendor prefixed properties

https://gerrit.wikimedia.org/r/675475

Change 675477 had a related patch set uploaded (by VolkerE; author: VolkerE):
[mediawiki/extensions/Flow@master] styles: Remove obsolete vendor prefixed properties

https://gerrit.wikimedia.org/r/675477

Change 675480 had a related patch set uploaded (by VolkerE; author: VolkerE):
[mediawiki/extensions/Popups@master] styles: Remove obsolete vendor prefixed properties

https://gerrit.wikimedia.org/r/675480

Change 675481 had a related patch set uploaded (by VolkerE; author: VolkerE):
[mediawiki/extensions/ContentTranslation@master] styles: Remove obsolete -moz- vendor prefixed rules

https://gerrit.wikimedia.org/r/675481

Change 675482 had a related patch set uploaded (by VolkerE; author: VolkerE):
[mediawiki/extensions/RevisionSlider@master] styles: Remove obsolete -moz- vendor prefixed rules

https://gerrit.wikimedia.org/r/675482

Change 675483 had a related patch set uploaded (by VolkerE; author: VolkerE):
[mediawiki/extensions/WikimediaMessages@master] styles: Remove obsolete -moz- vendor prefixed rules & properties

https://gerrit.wikimedia.org/r/675483

Volker_E renamed this task from Remove `-moz-keyframes`, `-moz-animation` & `-moz-transition` across skins & extensions to Remove obsolete `-moz-` prefixed rules and properties (`-moz-keyframes`, `-moz-animation` & `-moz-transition`) across skins & extensions.Mar 29 2021, 10:04 AM

Change 675484 had a related patch set uploaded (by VolkerE; author: VolkerE):
[mediawiki/skins/MinervaNeue@master] styles: Remove obsolete -moz- vendor prefixed properties

https://gerrit.wikimedia.org/r/675484

Change 675482 merged by jenkins-bot:
[mediawiki/extensions/RevisionSlider@master] styles: Remove obsolete -moz- vendor prefixed rules

https://gerrit.wikimedia.org/r/675482

Change 675466 merged by jenkins-bot:
[mediawiki/extensions/GuidedTour@master] styles: Remove obsolete vendor prefixed rules & properties

https://gerrit.wikimedia.org/r/675466

Volker_E renamed this task from Remove obsolete `-moz-` prefixed rules and properties (`-moz-keyframes`, `-moz-animation` & `-moz-transition`) across skins & extensions to Remove obsolete `-moz-` prefixed rules and properties (`-moz-keyframes`, `-moz-animation` & `-moz-transition`…) across skins & extensions.Mar 29 2021, 11:26 AM
Volker_E updated the task description. (Show Details)

Change 675465 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] styles: Remove obsolete vendor prefixed properties

https://gerrit.wikimedia.org/r/675465

Change 675484 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] styles: Remove obsolete -moz- vendor prefixed properties

https://gerrit.wikimedia.org/r/675484

Change 675464 merged by jenkins-bot:
[mediawiki/extensions/CollaborationKit@master] styles: Remove obsolete -moz- vendor prefixed properties

https://gerrit.wikimedia.org/r/675464

Change 675457 merged by jenkins-bot:
[mediawiki/extensions/CentralNotice@master] styles: Remove obsolete -moz- vendor prefixed rules

https://gerrit.wikimedia.org/r/675457

Change 675516 had a related patch set uploaded (by Mainframe98; author: Mainframe98):
[mediawiki/skins/Mirage@master] Remove obsolete vendor prefixed rules

https://gerrit.wikimedia.org/r/675516

Change 675516 merged by jenkins-bot:
[mediawiki/skins/Mirage@master] Remove obsolete vendor prefixed rules

https://gerrit.wikimedia.org/r/675516

Change 675480 merged by jenkins-bot:
[mediawiki/extensions/Popups@master] styles: Remove obsolete vendor prefixed properties

https://gerrit.wikimedia.org/r/675480

Change 675475 merged by jenkins-bot:
[mediawiki/extensions/MultimediaViewer@master] styles: Remove obsolete vendor prefixed properties

https://gerrit.wikimedia.org/r/675475

Change 675477 merged by jenkins-bot:
[mediawiki/extensions/Flow@master] styles: Remove obsolete vendor prefixed properties

https://gerrit.wikimedia.org/r/675477

Change 675483 merged by jenkins-bot:
[mediawiki/extensions/WikimediaMessages@master] styles: Remove obsolete -moz- vendor prefixed rules & properties

https://gerrit.wikimedia.org/r/675483

Change 675474 merged by jenkins-bot:
[mediawiki/extensions/Kartographer@master] styles: Remove obsolete vendor prefixed properties

https://gerrit.wikimedia.org/r/675474

Change 675481 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] styles: Remove obsolete `-moz-` vendor prefixed rules

https://gerrit.wikimedia.org/r/675481

Change 675468 abandoned by VolkerE:

[mediawiki/extensions/GWToolset@master] styles: Remove obsolete vendor prefixed properties

Reason:

I don't have time to work on that to meet scope-extending quests. Wanted to clean up the code base for sanity when searching for occurrences of specific vendor properties. Requests shared are independent and would ask for a change of status quo in modern browsers. That's a different outcome to this patch's scope and would need more time than this.

https://gerrit.wikimedia.org/r/675468

Change 684272 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/extensions/VisualEditor@master] Remove obsolete vendor prefixed properties

https://gerrit.wikimedia.org/r/684272

Change 684272 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Remove obsolete vendor prefixed properties

https://gerrit.wikimedia.org/r/684272

No references inside resources/src/mediawiki.skinning so untagging.

Change 720448 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/extensions/CentralAuth@master] styles: Remove obsolete vendor prefixed properties

https://gerrit.wikimedia.org/r/720448

Change 720449 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/extensions/MediaSearch@master] styles: Remove obsolete vendor prefixed properties

https://gerrit.wikimedia.org/r/720449

Change 720450 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/extensions/WikibaseMediaInfo@master] styles: Remove obsolete vendor prefixed properties

https://gerrit.wikimedia.org/r/720450

Change 720448 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] styles: Remove obsolete vendor prefixed properties

https://gerrit.wikimedia.org/r/720448

Change 720779 had a related patch set uploaded (by VolkerE; author: VolkerE):

[VisualEditor/VisualEditor@master] styles: Remove obsolete vendor prefixed properties

https://gerrit.wikimedia.org/r/720779

Change 720779 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] styles: Remove obsolete vendor prefixed properties

https://gerrit.wikimedia.org/r/720779

Change 720786 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (f89945db3)

https://gerrit.wikimedia.org/r/720786

Change 720786 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (f89945db3)

https://gerrit.wikimedia.org/r/720786

Change 720449 merged by jenkins-bot:

[mediawiki/extensions/MediaSearch@master] styles: Remove obsolete vendor prefixed properties

https://gerrit.wikimedia.org/r/720449

Change 720450 merged by jenkins-bot:

[mediawiki/extensions/WikibaseMediaInfo@master] styles: Remove obsolete vendor prefixed properties

https://gerrit.wikimedia.org/r/720450

Change 720829 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/core@master] mediawiki.mixins: Remove 2009 Flexbox spec support

https://gerrit.wikimedia.org/r/720829

Change 720957 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/extensions/Math@master] styles: Remove obsolete -moz- vendor prefixed rules

https://gerrit.wikimedia.org/r/720957

Change 720958 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/extensions/Wikibase@master] styles: Remove obsolete -moz- vendor prefixed rules

https://gerrit.wikimedia.org/r/720958

Change 720960 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/core@master] styles: Remove obsolete -moz- vendor prefixed rules

https://gerrit.wikimedia.org/r/720960

Change 720961 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/extensions/wikihiero@master] styles: Remove obsolete -moz- vendor prefixed rules

https://gerrit.wikimedia.org/r/720961

Change 720957 merged by jenkins-bot:

[mediawiki/extensions/Math@master] styles: Remove obsolete -moz- vendor prefixed rules

https://gerrit.wikimedia.org/r/720957

Change 720961 merged by jenkins-bot:

[mediawiki/extensions/wikihiero@master] styles: Remove obsolete -moz- vendor prefixed rules

https://gerrit.wikimedia.org/r/720961

Change 720958 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] styles: Remove obsolete -moz- vendor prefixed rules

https://gerrit.wikimedia.org/r/720958

Change 720829 merged by jenkins-bot:

[mediawiki/core@master] mediawiki.mixins: Remove 2009 Flexbox spec support

https://gerrit.wikimedia.org/r/720829

Change 722451 had a related patch set uploaded (by Jforrester; author: VolkerE):

[mediawiki/core@REL1_37] mediawiki.mixins: Remove 2009 Flexbox spec support

https://gerrit.wikimedia.org/r/722451

Change 722451 merged by jenkins-bot:

[mediawiki/core@REL1_37] mediawiki.mixins: Remove 2009 Flexbox spec support

https://gerrit.wikimedia.org/r/722451

Change 720960 merged by jenkins-bot:

[mediawiki/core@master] mediawiki.widgets: Remove obsolete -moz- vendor prefixed rules

https://gerrit.wikimedia.org/r/720960