Page MenuHomePhabricator

The .editOptions styles should not be shipped as part of ResourceLoaderSkinModule
Closed, ResolvedPublic


ResourceLoaderSkinModule ships several styles that match the .editOptions CSS selector when the interface feature is enabled.

These should only apply to edit pages, so should be moved to resources/src/mediawiki.action/mediawiki.action.edit.styles.less

Event Timeline

Change 675999 had a related patch set uploaded (by Mainframe98; author: Mainframe98):

[mediawiki/core@master] Move category and editOptions styles out of interface

Might wanna check livepreview and wikieditor and something like the HotCat gadget for previously undeclared implicit dependencies.

Basically anything in codesearch or gadgets using those selectors might be sus.

Thanks for the note @TheDJ
The damage here is minor (loss of background and padding) and easily fixed by a line of JS mw.loader.using('mediawiki.action.edit.styles');. I think a user notice should cover us. Does that sound good to you?*js

Not seeing anything of concern in codesearch:

Change 675999 merged by jenkins-bot:

[mediawiki/core@master] Move category and editOptions styles out of interface

Suggested tech news note:

In the week commencing 12th April 2021, editors should be alert for any UI regressions in gadgets which attempt to emulate edit summary area pictured in the following screenshot:

Screen Shot 2021-04-06 at 2.34.04 PM.png (470×1 px, 113 KB)

Impacted Gadgets/scripts (if any) should add mw.loader.using('mediawiki.action.edit.styles') to restore the previous styling.

@Jdlrobson Just so you're aware, there's no Tech News issue going out on Monday, since the writers will be off most of the relevant days; the next issue will be sent out on 19 April.

Thanks! Feel free to resolve this once the message is out.