Page MenuHomePhabricator

Minor edit marker no longer bolded on diffs
Closed, ResolvedPublicBUG REPORT

Description

Minor edit m letters on diffs are no longer bolded, see e.g. https://hu.wikipedia.org/w/index.php?title=ELTE_Tanító-_és_Óvóképző_Kar&diff=23735048. This is a new regression with with MW-1.36-notes (1.36.0-wmf.37; 2021-03-30) and seems to be caused by 84197bf6bb25/T278576. Although it’s a minor problem and doesn’t warrant UBN, I think it can lead to this markers being unnoticed, so I’d like to have it fixed ASAP and backported if possible.

Event Timeline

This is because these indicators (m, b, N and !) are provided through ChangesList::flag. I had not noticed this to be a static method, used all over the place.

The common ground is mediawiki.interface.helpers.styles. Moving it there should be sufficient.

Change 676548 had a related patch set uploaded (by Mainframe98; author: Mainframe98):

[mediawiki/core@master] Fix missing styles on diff

https://gerrit.wikimedia.org/r/676548

Change 676548 merged by jenkins-bot:

[mediawiki/core@master] Fix missing styles on diff

https://gerrit.wikimedia.org/r/676548

Thanks for fixing it! Is there a chance to have this backported, at least on Monday? (If anyone works on Easter Monday.)

IF anyone is able to by all means they should go ahead. We do have a backport window on Monday https://wikitech.wikimedia.org/wiki/Deployments but i'm not going to be available for it.

Change 676964 had a related patch set uploaded (by Bartosz Dziewoński; author: Mainframe98):

[mediawiki/core@wmf/1.36.0-wmf.37] Fix missing styles on diff

https://gerrit.wikimedia.org/r/676964

Change 676964 merged by jenkins-bot:

[mediawiki/core@wmf/1.36.0-wmf.37] Fix missing styles on diff

https://gerrit.wikimedia.org/r/676964

Mentioned in SAL (#wikimedia-operations) [2021-04-06T23:36:05Z] <urbanecm@deploy1002> Synchronized php-1.36.0-wmf.37/resources/src/: rMWb8a0dabb1599: Fix missing styles on diff (T279099) (duration: 01m 08s)