Page MenuHomePhabricator

Vector will not use the `legacy` ResourceLoaderSkinModule
Open, MediumPublic2 Estimated Story Points

Description

The legacy feature of ResourceLoaderSkinModule will be deprecated in the 1.36 release (see T89981)
In 1.37 vector will cherry pick the styles it needs from the new features provided in https://www.mediawiki.org/wiki/Manual:ResourceLoaderSkinModule
This will reduce the CSS on the critical path by around 2kb.

https://www.mediawiki.org/wiki/Manual:ResourceLoaderSkinModule#For_skins_deprecating_the_legacy_feature as a guide to make the migration.

Blocker: T278894

Acceptance criteria

  • Vector modern drops legacy feature
  • A user notice goes out to gadgets to fix gadgets using this style (testing in modern Vector)
  • Vector legacy will drop the legacy feature

QA steps

  • Please test the print version for any content that is hidden before and after the change.

Developer notes

I'm fairly confident this should be drama free. Visual impacts to the Vector skin are unlikely but there is an unlikely but small risk that this causes minor impact to user gadgets.

Event Timeline

Change 675918 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] [modern/performance] Simplify Vector styles

https://gerrit.wikimedia.org/r/675918

Change 675918 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] [modern/performance] Simplify Vector styles

https://gerrit.wikimedia.org/r/675918

I can predict one regression ahead of time: red links. Vector currently uses ba0000 from legacy, which will change to d33 when only using elements. T213778 states that this shouldn't change, so the definition for a.new should be added to typography.less.

Thanks @mainframe I've started documenting the legacy deprecation on https://m.mediawiki.org/wiki/Manual:ResourceLoaderSkinModule#For_skins_deprecating_the_legacy_feature
Please feel free to edit if you think of anything I've missed.

Oh and perhaps we'll want to User-notice this for tech news. Something like:

Vector is no longer using some outdated styles. This should not have any visible effect as the styles had been moved earlier.

Especially because things like T279099 pop up, and if we've got something to shepherd them to, we can spot the regressions easier.

Thanks @mainframe I've started documenting the legacy deprecation on https://m.mediawiki.org/wiki/Manual:ResourceLoaderSkinModule#For_skins_deprecating_the_legacy_feature
Please feel free to edit if you think of anything I've missed.

I'll have a more in-depth look later, but I made some adjustments.

Krinkle added a subscriber: Krinkle.

LGTM. It seems the deprecatation itself of legacy is being tracked at ResourceLoaderSkinModule, so I'll untag us here. If not, then perhaps that's worth tracking as its own follow-up Technical-Debt (Deprecation process) task to tag RL+Perf with.

Jdlrobson added a subscriber: ovasileva.

@ovasileva good opportunity to improve performance on Vector. Please prioritize at your leisure. Happy to talk through in more detail.

Jdlrobson lowered the priority of this task from High to Medium.Wed, Jul 21, 4:21 PM

Adjusting priority compared to other patches in code review.