Change 675918 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] [modern/performance] Simplify Vector styles

https://gerrit.wikimedia.org/r/675918

Change 675918 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] [modern/performance] Simplify Vector styles

https://gerrit.wikimedia.org/r/675918

I can predict one regression ahead of time: red links. Vector currently uses ba0000 from legacy, which will change to d33 when only using elements. T213778 states that this shouldn't change, so the definition for a.new should be added to typography.less.

Thanks @mainframe I've started documenting the legacy deprecation on https://m.mediawiki.org/wiki/Manual:ResourceLoaderSkinModule#For_skins_deprecating_the_legacy_feature
Please feel free to edit if you think of anything I've missed.

Oh and perhaps we'll want to User-notice this for tech news. Something like:

Vector is no longer using some outdated styles. This should not have any visible effect as the styles had been moved earlier.

Especially because things like T279099 pop up, and if we've got something to shepherd them to, we can spot the regressions easier.

In T278896#6961112, @Jdlrobson wrote:

Thanks @mainframe I've started documenting the legacy deprecation on https://m.mediawiki.org/wiki/Manual:ResourceLoaderSkinModule#For_skins_deprecating_the_legacy_feature
Please feel free to edit if you think of anything I've missed.

I'll have a more in-depth look later, but I made some adjustments.

LGTM. It seems the deprecatation itself of legacy is being tracked at ResourceLoaderSkinModule, so I'll untag us here. If not, then perhaps that's worth tracking as its own follow-up Technical-Debt (Deprecation process) task to tag RL+Perf with.

@ovasileva good opportunity to improve performance on Vector. Please prioritize at your leisure. Happy to talk through in more detail.

Change 675918 merged by jenkins-bot:

[mediawiki/skins/Vector@master] [modern/performance] Simplify Vector styles

https://gerrit.wikimedia.org/r/675918

Test Result - Beta

Status: ❌ Fail
Environment: beta
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

Please compare several pages in production (en.wikipedia.org) to beta cluster (https://en.wikipedia.beta.wmflabs.org/)

✅ AC1: Check categories at bottom of the page render identically

Beta	Enwiki

✅ AC2: Please check headings in page render identically

Beta	Enwiki

✅ AC3: Please check thumbnails in page render identically

Beta	Enwiki

✅ AC4: Please check any lists in page render identically (make sure to test numbered lists as well as unordered lists)

Beta	Enwiki

❌ AC5: Please check all the above in the print version

Beta has the following issues:

1. Sidebar menu is printed
2. Top Menu items are printed

Change 708307 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] Restore print and message box styles

https://gerrit.wikimedia.org/r/708307

(I will backport this change)

Change 708220 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@wmf/1.37.0-wmf.16] Restore print, links, table and message box styles

https://gerrit.wikimedia.org/r/708220

Change 708307 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Restore print, links, table and message box styles

https://gerrit.wikimedia.org/r/708307

This should shortly be ready for another round of QA on the beta cluster.

Change 708220 merged by jenkins-bot:

[mediawiki/skins/Vector@wmf/1.37.0-wmf.16] Restore print, links, table and message box styles

https://gerrit.wikimedia.org/r/708220

Mentioned in SAL (#wikimedia-operations) [2021-07-27T23:53:51Z] <thcipriani@deploy1002> Synchronized php-1.37.0-wmf.16/skins/Vector: Backport: [[gerrit:708220|Restore print, links, table and message box styles (T278896)]] (duration: 01m 07s)

Change 708425 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/skins/Vector@master] Revert \"[modern/performance] Simplify Vector styles\"

https://gerrit.wikimedia.org/r/708425

Hi. Can I understand from this that mw-content-ltr and mw-content-rtl classes will not work any more in the new Vector? Our wiki has 26,582 uses of these classes, and they show noncence now. Why did you do this? Why did not you announced a year before, so we can fix all the uses? What other classes are broken? Thank you.

In T278896#7246871, @IKhitron wrote:

Hi. Can I understand from this that mw-content-ltr and mw-content-rtl classes will not work any more in the new Vector? Our wiki has 26,582 uses of these classes, and they show noncence now. Why did you do this? Why did not you announced a year before, so we can fix all the uses? What other classes are broken? Thank you.

Yes, we are moving away from mw-content-(ltr|rtl) classes (without dir and lang attributes) and encouraging use of the dir attribute inside HTML which is better for screen readers and accessibility as well as being easier to support. When you say "our wiki" can you clarify which wiki you mean and provide some examples? I would suggest these wikis ship these styles in MediaWiki:Vector.css as a relatively straightforward solution.

It's a disaster. I'm talking about hewiki. The examples are all our sources. We use

==References==
* Some local article
* Some local article
<div class="mw-content-rtl">
* Some article from US
* Some article from Britain
</div>

We can change this to dir attribute, but as I already said, you should give us a year. Working on common.css.

We can change this to dir attribute, but as I already said, you should give us a year. Working on common.css.

Yep using Mediawiki:Vector.css would be the way to go for now if you are saying this problem is widespread.

.mw-content-ltr { dir: ltr; }
.mw-content-rtl { dir: rtl; }

The following markup would fix th

==References==
* Some local article
* Some local article
<div class="mw-content-rtl" dir="rtl">
* Some article from US
* Some article from Britain
</div>

It's a disaster.

Thanks for bringing this issue to my attention. I'll create a User-notice to make sure other projects are notified about this particular issue. I wouldn't say this is a disaster :). On the long term by providing HTML markup for our users, they'll have a much better experience of the site. The site should also be loading faster due to the reduction of unnecessary CSS.

Already worked on this, before spiking with you. It is for sure disaster. There are many thousands of broken articles. Every user knows how to do this, and they all will need to learn it again, while most of them do not know html and css.

I have created T287701. Thanks for reporting.

In T278896#7247030, @IKhitron wrote:

Already worked on this, before spiking with you. It is for sure disaster. There are many thousands of broken articles. Every user knows how to do this, and they all will need to learn it again, while most of them do not know html and css.

I would suggest on the longer term a template would be an appropriate solution to this. Hardcoding HTML inside wikitext doesn't seem like an ideal solution.

Change 708425 abandoned by Jdlrobson:

[mediawiki/skins/Vector@master] Revert \"[modern/performance] Simplify Vector styles\"

Reason:

Fixed in GlobalWatchlist extension.

https://gerrit.wikimedia.org/r/708425

Test Result - Beta

Status: ✅ Pass
Environment: beta
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

Please compare several pages in production (en.wikipedia.org) to beta cluster (https://en.wikipedia.beta.wmflabs.org/)

✅ AC1: Check categories at bottom of the page render identically

Beta	Enwiki

✅ AC2: Please check headings in page render identically

Beta	Enwiki

✅ AC3: Please check thumbnails in page render identically

Beta	Enwiki

✅ AC4: Please check any lists in page render identically (make sure to test numbered lists as well as unordered lists)

Beta	Enwiki

✅ AC5: Please check all the above in the print version