Page MenuHomePhabricator

Quicksurveys: [1.37] The class mw-ajax-loader will no longer be styled by Vector
Open, MediumPublic2 Estimated Story Points

Description

The legacy feature of ResourceLoaderSkinModule will be deprecated in the 1.36 release (see T89981)

In the 1.37 release Vector will drop use of the legacy feature. This will reduce the amount of bytes on the critical path of Vector.

This will also remove styling support for the elements .mw-ajax-loader, .mw-small-spinner
https://codesearch.wmcloud.org/deployed/?q=(mw-ajax-loader%7Cmw-small-spinner)&i=nope&files=&excludeFiles=&repos=

Repos that wish to continue to use these styles should either

  1. copy across the style to their own repository. It would be preferable if such repos used their own class as well to avoid false positives in the above search result.

e.g.

.mw-ajax-loader {
	background-image: url( images/ajax-loader.gif );
	background-position: center center;
	background-repeat: no-repeat;
	padding: 16px;
	position: relative;
	top: -16px;
}

.mw-small-spinner {
	padding: 10px !important; /* stylelint-disable-line declaration-no-important */
	margin-right: 0.6em;
	background-image: url( images/spinner.gif );
	background-position: center center;
	background-repeat: no-repeat;
}
  1. Use $.createSpinner() from the 'jquery.spinner' library.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

You should use $.createSpinner() from the 'jquery.spinner' module as a replacement.

Change 676129 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] Replace use of deprecated CSS class 'mw-ajax-loader'

https://gerrit.wikimedia.org/r/676129

Change 676129 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Replace use of deprecated CSS class 'mw-ajax-loader'

https://gerrit.wikimedia.org/r/676129

ovasileva renamed this task from [1.37] The class mw-ajax-loader will no longer be styled by Vector to Quicksurveys: [1.37] The class mw-ajax-loader will no longer be styled by Vector.May 3 2021, 1:38 PM
ovasileva triaged this task as Medium priority.

We can use jquery.spinner here for QuickSurveys ($.createSpinner()) or simply copy pasta. No preference.

to clarify the estimate above only applies to removing the class from QuickSurveys.

@bwang: Are you working on this? If so, could you move it into Doing.

Change 699001 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/extensions/QuickSurveys@master] Replace use of deprecated CSS class 'mw-ajax-loader' with jquery.spinner

https://gerrit.wikimedia.org/r/699001

bwang removed bwang as the assignee of this task.Wed, Jun 9, 3:13 PM
bwang added a subscriber: bwang.

Change 699001 merged by jenkins-bot:

[mediawiki/extensions/QuickSurveys@master] Replace use of deprecated CSS class 'mw-ajax-loader' with jquery.spinner

https://gerrit.wikimedia.org/r/699001