Page MenuHomePhabricator

[Wikibase] Remove usage of 1.37 deprecated CSS class 'mw-small-spinner''
Closed, ResolvedPublic3 Estimated Story Points

Description

Extracted from T278894: [1.37] The class mw-ajax-loader will no longer be styled by Vector for Wikibase.

The legacy feature of ResourceLoaderSkinModule will be deprecated in the 1.36 release (see T89981)

In the 1.37 release Vector will drop use of the legacy feature. This will reduce the amount of bytes on the critical path of Vector.

This will also remove styling support for the elements .mw-ajax-loader, .mw-small-spinner
https://codesearch.wmcloud.org/deployed/?q=(mw-ajax-loader%7Cmw-small-spinner)&i=nope&files=&excludeFiles=&repos=

Repos that wish to continue to use these styles should either

  1. copy across the style to their own repository. It would be preferable if such repos used their own class as well to avoid false positives in the above search result.
  2. Use $.createSpinner() from the 'jquery.spinner' library.

Acceptance CriteriaπŸ•οΈπŸŒŸ

  • We no longer directly use the deprecated class that will be removed in the future

Event Timeline

Addshore renamed this task from Remove usage of 1.37 deprecated CSS class 'mw-ajax-loader' to [Wikibase] Remove usage of 1.37 deprecated CSS class 'mw-ajax-loader'.Apr 12 2021, 7:30 AM
Addshore created this task.
Addshore moved this task from Inbox to To Prioritize on the [DEPRECATED] wdwb-tech board.
ovasileva triaged this task as Medium priority.Apr 19 2021, 3:21 PM
ovasileva moved this task from Incoming to Triaged but Future on the Web-Team-Backlog board.
Addshore set the point value for this task to 3.Apr 28 2021, 10:35 AM

There seem to be no occurrence of mw-ajax-loader in Wikibase. Am I right to assume this task is not valid? btw the parent ticket mentioned style support for mw-small-spinner is also removed and Wikibase uses that class.

Jdlrobson renamed this task from [Wikibase] Remove usage of 1.37 deprecated CSS class 'mw-ajax-loader' to [Wikibase] Remove usage of 1.37 deprecated CSS class 'mw-small-spinner''.May 10 2021, 8:35 PM
Jdlrobson awarded a token.

Change 688932 had a related patch set uploaded (by Rosalie Perside (WMDE); author: Rosalie Perside (WMDE)):

[mediawiki/extensions/Wikibase@master] Remove usage of 1.37 deprecated CSS class 'mw-small-spinner'

https://gerrit.wikimedia.org/r/688932

Change 688932 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Remove usage of 1.37 deprecated CSS class 'mw-small-spinner'

https://gerrit.wikimedia.org/r/688932