Page MenuHomePhabricator
Create Task
Maniphest T279127

Enwiki autoreview for flagged revs not working
Closed, DuplicatePublicBUG REPORT
Actions

Description

First reported in #wikipedia-en-help
Steps to reproduce:
On a page that is configured with autoreview=autoconfirmed
As a user who is autoconfirmed but not a pending changes reviewer, make an edit

Expected result:
edit is automatically approved

Actual result:
edit is pending

(If the edit is made by an autoconfirmed user who is a pending changes reviewer, it is autoreviewed)

Details

SubjectRepoBranchLines +/-
Rollback group1 and group2 wikis to 1.36.0-wmf.36operations/mediawiki-configmaster+842 -842
Customize query in gerrit

Related Objects

Event Timeline

DannyS712 created this task.Apr 2 2021, 4:17 AM
Restricted Application added a project: User-DannyS712. · View Herald TranscriptApr 2 2021, 4:17 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
DannyS712 triaged this task as High priority.Apr 2 2021, 4:18 AM
DannyS712 moved this task from Unsorted to Reports on the User-DannyS712 board.
DannyS712 changed the subtype of this task from "Task" to "Bug Report".
DannyS712 added a subscriber: Ladsgroup.

Might also affect other wikis, not tested

DannyS712 mentioned this in T278343: 1.36.0-wmf.37 deployment blockers.Apr 2 2021, 4:18 AM
hashar added a parent task: T278343: 1.36.0-wmf.37 deployment blockers.Apr 2 2021, 9:40 AM
gerritbot added a comment.Apr 2 2021, 9:42 AM

Change 676557 had a related patch set uploaded (by Hashar; author: Hashar):

[operations/mediawiki-config@master] Rollback group1 and group2 wikis to 1.36.0-wmf.36

https://gerrit.wikimedia.org/r/676557

gerritbot added a project: Patch-For-Review.Apr 2 2021, 9:42 AM

Change 676557 merged by jenkins-bot:

[operations/mediawiki-config@master] Rollback group1 and group2 wikis to 1.36.0-wmf.36

https://gerrit.wikimedia.org/r/676557

Ladsgroup added a comment.Apr 2 2021, 9:47 AM

It doesn't happen in all cases (check https://en.wikipedia.org/w/index.php?title=April_6&action=history) meaning this is just a duplicate of an old bug: T275322: Some edits made by extended confirmed users are no longer automatically accepted

hashar raised the priority of this task from High to Unbreak Now!.Apr 2 2021, 9:52 AM
hashar subscribed.

I have rolled Mediawiki deployment from 1.36.0-wmf.37 to 1.36.0-wmf.36 that should have restored the behavior (I don't know how to check though).

Ladsgroup added a comment.Apr 2 2021, 9:54 AM

This is definitely not an issue with wmf.37:

Maintenance_bot removed a project: Patch-For-Review.Apr 2 2021, 10:10 AM
Ladsgroup lowered the priority of this task from Unbreak Now! to High.Apr 2 2021, 10:16 AM
Ladsgroup removed a parent task: T278343: 1.36.0-wmf.37 deployment blockers.
Ladsgroup closed this task as a duplicate of T275322: Some edits made by extended confirmed users are no longer automatically accepted.
DannyS712 removed a project: User-DannyS712.Apr 2 2021, 1:25 PM
In T279127#6967552, @Ladsgroup wrote:

This is definitely not an issue with wmf.37:

Apologies, I didn't realize there was an existing task. Sorry for the trouble

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits