Page MenuHomePhabricator
Create Task
Maniphest T278343

1.36.0-wmf.37 deployment blockers
Closed, ResolvedPublicRelease
Actions

Details

Backup Train Conductor
hashar
Release Version
1.36.0-wmf.37
Release Date
Mar 29 2021, 12:00 AM
Train Status
NOTE: Deployed to all wikis.

2021 week 13 1.36-wmf.37 Changes wmf/1.36.0-wmf.37

This MediaWiki Train Deployment is scheduled for the week of Monday, March 29th:

Monday March 29thTuesday, March 30thWednesday, March 31stThursday, April 1stFriday
Backports only.Branch wmf.37 and deploy to Group 0 Wikis.Deploy wmf.37 to Group 1 Wikis.Deploy wmf.37 to all Wikis.No deployments on fridays

How this works

  • Any serious bugs affecting wmf.37 should be added as subtasks beneath this one.
  • Any open subtask(s) block the train from moving forward. This means no further deployments until the blockers are resolved.
  • If something is serious enough to warrant a rollback then you should bring it to the attention of deployers on the #wikimedia-operations IRC channel.
  • If you have a risky change in this week's train add a comment to this task using the Risky patch template
  • For more info about deployment blockers, see Holding the train.

Related Links

Other Deployments

Previous: 1.36.0-wmf.36
Next: 1.36.0-wmf.38
SubjectRepoBranchLines +/-
Revert "group0 wikis to 1.36.0-wmf.37"operations/mediawiki-configmaster+132 -132
Rollback group1 and group2 wikis to 1.36.0-wmf.36operations/mediawiki-configmaster+842 -842
Branch commit for wmf/1.36.0-wmf.37mediawiki/corewmf/1.36.0-wmf.37+976 -3
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedRelease• mmodellT278343 1.36.0-wmf.37 deployment blockers
 DuplicateBUG REPORTNoneT279132 Special:Export creates an empty XML file for any pages

Event Timeline

thcipriani created this task.Mar 24 2021, 3:46 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 24 2021, 3:46 PM
• Pchelolo added a subtask: T278376: Parser Use of RevisionRecord for a page that can't exist: (eg Special:MyLanguage/Main Page).Mar 24 2021, 8:24 PM
hashar removed a subtask: T278376: Parser Use of RevisionRecord for a page that can't exist: (eg Special:MyLanguage/Main Page).Mar 24 2021, 8:59 PM
daniel added a subtask: T278376: Parser Use of RevisionRecord for a page that can't exist: (eg Special:MyLanguage/Main Page).Mar 24 2021, 10:09 PM
thcipriani assigned this task to • mmodell.Mar 26 2021, 5:57 PM
thcipriani triaged this task as Medium priority.
thcipriani updated Other Assignee, added: hashar.
thcipriani added a project: Release-Engineering-Team-TODO (2021-01-01 to 2021-03-31 (Q3)).
thcipriani moved this task from INBOX to Deployment on the Release-Engineering-Team-TODO (2021-01-01 to 2021-03-31 (Q3)) board.
gerritbot added a comment.Mar 30 2021, 2:18 AM

Change 675625 had a related patch set uploaded (by DannyS712; author: trainbranchbot):
[mediawiki/core@wmf/1.36.0-wmf.37] Branch commit for wmf/1.36.0-wmf.37

https://gerrit.wikimedia.org/r/675625

gerritbot added a project: Patch-For-Review.Mar 30 2021, 2:18 AM
gerritbot added a comment.Mar 30 2021, 7:25 AM

Change 675625 merged by jenkins-bot:
[mediawiki/core@wmf/1.36.0-wmf.37] Branch commit for wmf/1.36.0-wmf.37

https://gerrit.wikimedia.org/r/675625

cscott subscribed.Mar 30 2021, 5:05 PM

https://gerrit.wikimedia.org/r/675738 - The Parsoid bunch to vendor missed the branch cut due to the Monday holiday. I've cherry-picked it onto wmf.37 which AFAIK hasn't been deployed anywhere yet. Figured I'd let the train conductors know, though, just in case.

thcipriani added a comment.Mar 30 2021, 5:28 PM
In T278343#6957381, @cscott wrote:

https://gerrit.wikimedia.org/r/675738 - The Parsoid bunch to vendor missed the branch cut due to the Monday holiday. I've cherry-picked it onto wmf.37 which AFAIK hasn't been deployed anywhere yet. Figured I'd let the train conductors know, though, just in case.

Thanks for the heads up! There is a weird period of time after we do the branch cut but before we merge the branch commit (i.e., https://gerrit.wikimedia.org/r/675625 ) where this can get tricky (see T277507: Core subproject commits aren't updated for backports if wmf branch commit has not yet been merged. ) You should make sure that MediaWiki/core wmf/1.36.0-wmf.37 points to the right commit in vendor: https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/core/+/refs/heads/wmf/1.36.0-wmf.37/vendor (currently that's 89b69fb9b2f9eff1e6d1f29eb24f8516adbeb71d which looks like the parent of your commit) -- do we need to bump this submodule manually? (I think so?)

• mmodell added a comment.Mar 30 2021, 5:53 PM

Looks like the submodule bump got merged into the branch: https://gerrit.wikimedia.org/g/mediawiki/core/+/013534312d1ecaf71ece8b884724ab2af919bc4b

gerritbot added a comment.Mar 30 2021, 7:12 PM

Change 675886 had a related patch set uploaded (by 20after4; author: 20after4):

[operations/mediawiki-config@master] testwikis wikis to 1.36.0-wmf.37 refs T278343

https://gerrit.wikimedia.org/r/675886

gerritbot added a comment.Mar 30 2021, 7:13 PM

Change 675886 merged by jenkins-bot:

[operations/mediawiki-config@master] testwikis wikis to 1.36.0-wmf.37 refs T278343

https://gerrit.wikimedia.org/r/675886

Stashbot added a comment.Mar 30 2021, 7:13 PM

Mentioned in SAL (#wikimedia-operations) [2021-03-30T19:13:39Z] <twentyafterfour@deploy1002> Started scap: testwikis wikis to 1.36.0-wmf.37 refs T278343

Stashbot added a comment.Mar 30 2021, 8:02 PM

Mentioned in SAL (#wikimedia-operations) [2021-03-30T20:02:21Z] <twentyafterfour> when syncing 1.36.0-wmf.37 promote to testwikis, one server failed: server mw1298.eqiad.wmnet and two more appear to be hung because scap is stuck at 2 left 99% without making any progress for a long time now. refs T278343

Stashbot added a comment.Mar 30 2021, 8:33 PM

Mentioned in SAL (#wikimedia-operations) [2021-03-30T20:33:49Z] <twentyafterfour@deploy1002> Finished scap: testwikis wikis to 1.36.0-wmf.37 refs T278343 (duration: 80m 32s)

• mmodell edited Train Status. (Show Details)Mar 30 2021, 8:55 PM
• mmodell edited Train Status. (Show Details)
DannyS712 added a subtask: T278904: [Regression 1.36.0-wmf.36] On enwiki, new edits are being marked as quality instead of "accepted" after manual pending changes review.Mar 31 2021, 12:05 AM
DannyS712 subscribed.Mar 31 2021, 12:08 AM

T278904: [Regression 1.36.0-wmf.36] On enwiki, new edits are being marked as quality instead of "accepted" after manual pending changes review is an issue with .36 that wasn't discovered until now, tagging this week's .37 task since last week's task was already resolved (unless we want to rollback?)

Jdforrester-WMF removed a subtask: T278904: [Regression 1.36.0-wmf.36] On enwiki, new edits are being marked as quality instead of "accepted" after manual pending changes review.Mar 31 2021, 3:47 PM
• ssastry removed a subtask: T278376: Parser Use of RevisionRecord for a page that can't exist: (eg Special:MyLanguage/Main Page).Mar 31 2021, 4:55 PM
Stashbot added a comment.Mar 31 2021, 5:41 PM

Mentioned in SAL (#wikimedia-operations) [2021-03-31T17:41:42Z] <twentyafterfour> The train is now unblocked, promoting to group0 refs T278343

gerritbot added a comment.Mar 31 2021, 5:44 PM

Change 676111 had a related patch set uploaded (by 20after4; author: 20after4):

[operations/mediawiki-config@master] group0 wikis to 1.36.0-wmf.37 refs T278343

https://gerrit.wikimedia.org/r/676111

gerritbot added a comment.Mar 31 2021, 5:45 PM

Change 676111 merged by jenkins-bot:

[operations/mediawiki-config@master] group0 wikis to 1.36.0-wmf.37 refs T278343

https://gerrit.wikimedia.org/r/676111

Stashbot added a comment.Mar 31 2021, 5:49 PM

Mentioned in SAL (#wikimedia-operations) [2021-03-31T17:49:02Z] <twentyafterfour@deploy1002> rebuilt and synchronized wikiversions files: group0 wikis to 1.36.0-wmf.37 refs T278343

gerritbot added a comment.Mar 31 2021, 5:53 PM

Change 676115 had a related patch set uploaded (by 20after4; author: 20after4):

[operations/mediawiki-config@master] group0 wikis to 1.36.0-wmf.36 refs T278343

https://gerrit.wikimedia.org/r/676115

gerritbot added a comment.Mar 31 2021, 5:55 PM

Change 676115 merged by jenkins-bot:

[operations/mediawiki-config@master] group0 wikis to 1.36.0-wmf.36 refs T278343

https://gerrit.wikimedia.org/r/676115

Stashbot added a comment.Mar 31 2021, 5:56 PM

Mentioned in SAL (#wikimedia-operations) [2021-03-31T17:56:47Z] <twentyafterfour@deploy1002> rebuilt and synchronized wikiversions files: group0 wikis to 1.36.0-wmf.36 refs T278343

Stashbot added a comment.Mar 31 2021, 7:03 PM

Mentioned in SAL (#wikimedia-operations) [2021-03-31T19:03:52Z] <twentyafterfour@deploy1002> Synchronized php-1.36.0-wmf.37/includes/Revision/RevisionRecord.php: sync https://gerrit.wikimedia.org/r/c/mediawiki/core/+/675875 to unblock train refs T278376 T278343 (duration: 00m 58s)

Stashbot mentioned this in T278376: Parser Use of RevisionRecord for a page that can't exist: (eg Special:MyLanguage/Main Page).Mar 31 2021, 7:03 PM
gerritbot added a comment.Mar 31 2021, 7:11 PM

Change 676136 had a related patch set uploaded (by 20after4; author: 20after4):

[operations/mediawiki-config@master] group0 wikis to 1.36.0-wmf.37 refs T278343

https://gerrit.wikimedia.org/r/676136

gerritbot added a comment.Mar 31 2021, 7:11 PM

Change 676136 merged by jenkins-bot:

[operations/mediawiki-config@master] group0 wikis to 1.36.0-wmf.37 refs T278343

https://gerrit.wikimedia.org/r/676136

Stashbot added a comment.Mar 31 2021, 7:13 PM

Mentioned in SAL (#wikimedia-operations) [2021-03-31T19:13:20Z] <twentyafterfour@deploy1002> rebuilt and synchronized wikiversions files: group0 wikis to 1.36.0-wmf.37 refs T278343

gerritbot added a comment.Mar 31 2021, 7:18 PM

Change 676138 had a related patch set uploaded (by 20after4; author: 20after4):

[operations/mediawiki-config@master] group1 wikis to 1.36.0-wmf.37 refs T278343

https://gerrit.wikimedia.org/r/676138

gerritbot added a comment.Mar 31 2021, 7:19 PM

Change 676138 merged by jenkins-bot:

[operations/mediawiki-config@master] group1 wikis to 1.36.0-wmf.37 refs T278343

https://gerrit.wikimedia.org/r/676138

Stashbot added a comment.Mar 31 2021, 7:20 PM

Mentioned in SAL (#wikimedia-operations) [2021-03-31T19:20:31Z] <twentyafterfour@deploy1002> rebuilt and synchronized wikiversions files: group1 wikis to 1.36.0-wmf.37 refs T278343

Stashbot added a comment.Mar 31 2021, 7:21 PM

Mentioned in SAL (#wikimedia-operations) [2021-03-31T19:21:40Z] <twentyafterfour@deploy1002> Synchronized php: group1 wikis to 1.36.0-wmf.37 refs T278343 (duration: 01m 08s)

Krinkle added a subtask: T279008: mw-parser-output now clears after block, which is a noticeable change for Category pages where infoboxes used to render floated alongside the automatic content.Mar 31 2021, 8:01 PM
RhinosF1 subscribed.Mar 31 2021, 8:06 PM
• mmodell edited Train Status. (Show Details)Mar 31 2021, 8:10 PM
Jdlrobson removed a subtask: T279008: mw-parser-output now clears after block, which is a noticeable change for Category pages where infoboxes used to render floated alongside the automatic content.Mar 31 2021, 8:19 PM
Jdlrobson added a subtask: T279008: mw-parser-output now clears after block, which is a noticeable change for Category pages where infoboxes used to render floated alongside the automatic content.
Jdlrobson removed a subtask: T279008: mw-parser-output now clears after block, which is a noticeable change for Category pages where infoboxes used to render floated alongside the automatic content.Mar 31 2021, 8:23 PM
Krinkle added a subtask: T279008: mw-parser-output now clears after block, which is a noticeable change for Category pages where infoboxes used to render floated alongside the automatic content.Mar 31 2021, 9:17 PM
Jdlrobson removed a subtask: T279008: mw-parser-output now clears after block, which is a noticeable change for Category pages where infoboxes used to render floated alongside the automatic content.Apr 1 2021, 2:51 PM
• mmodell added a comment.Apr 1 2021, 6:49 PM

No blockers, looks like we should be good to go with today's deployment to group2.

gerritbot added a comment.Apr 1 2021, 7:19 PM

Change 676441 had a related patch set uploaded (by 20after4; author: 20after4):

[operations/mediawiki-config@master] group2 wikis to 1.36.0-wmf.37 refs T278343

https://gerrit.wikimedia.org/r/676441

gerritbot added a comment.Apr 1 2021, 7:20 PM

Change 676441 merged by jenkins-bot:

[operations/mediawiki-config@master] group2 wikis to 1.36.0-wmf.37 refs T278343

https://gerrit.wikimedia.org/r/676441

Stashbot added a comment.Apr 1 2021, 7:21 PM

Mentioned in SAL (#wikimedia-operations) [2021-04-01T19:21:48Z] <twentyafterfour@deploy1002> rebuilt and synchronized wikiversions files: group2 wikis to 1.36.0-wmf.37 refs T278343

• mmodell edited Train Status. (Show Details)Apr 1 2021, 7:39 PM
DannyS712 added a comment.EditedApr 2 2021, 4:18 AM

Filed T279127: Enwiki autoreview for flagged revs not working - might be caused by code that went out with the train

hashar added a subtask: T279132: Special:Export creates an empty XML file for any pages.Apr 2 2021, 9:30 AM
hashar mentioned this in T279132: Special:Export creates an empty XML file for any pages.Apr 2 2021, 9:32 AM
hashar added a subtask: T278579: Special:Export broken: always generates an empty file.Apr 2 2021, 9:35 AM
hashar mentioned this in T278579: Special:Export broken: always generates an empty file.
hashar added a subtask: T279127: Enwiki autoreview for flagged revs not working.Apr 2 2021, 9:40 AM
gerritbot added a comment.Apr 2 2021, 9:42 AM

Change 676557 had a related patch set uploaded (by Hashar; author: Hashar):

[operations/mediawiki-config@master] Rollback group1 and group2 wikis to 1.36.0-wmf.36

https://gerrit.wikimedia.org/r/676557

gerritbot added a comment.Apr 2 2021, 9:43 AM

Change 676557 merged by jenkins-bot:

[operations/mediawiki-config@master] Rollback group1 and group2 wikis to 1.36.0-wmf.36

https://gerrit.wikimedia.org/r/676557

Stashbot added a comment.Apr 2 2021, 9:45 AM

Mentioned in SAL (#wikimedia-operations) [2021-04-02T09:45:56Z] <hashar@deploy1002> rebuilt and synchronized wikiversions files: Revert group1 and group2 wikis to 1.36.0-wmf.36 - T278343

gerritbot added a comment.Apr 2 2021, 10:05 AM

Change 676559 had a related patch set uploaded (by Hashar; author: Hashar):

[operations/mediawiki-config@master] Revert "group0 wikis to 1.36.0-wmf.37"

https://gerrit.wikimedia.org/r/676559

gerritbot added a comment.Apr 2 2021, 10:05 AM

Change 676559 merged by jenkins-bot:

[operations/mediawiki-config@master] Revert "group0 wikis to 1.36.0-wmf.37"

https://gerrit.wikimedia.org/r/676559

Stashbot added a comment.Apr 2 2021, 10:07 AM

Mentioned in SAL (#wikimedia-operations) [2021-04-02T10:07:04Z] <hashar@deploy1002> rebuilt and synchronized wikiversions files: Rollback group0 wikis to 1.36.0-wmf.36 - T278343

hashar subscribed.Apr 2 2021, 10:08 AM

I have rolled back group 0 wikis as well since https://www.mediawiki.org/wiki/Special:Export/Main_Page was broken there.

Ladsgroup removed a subtask: T279127: Enwiki autoreview for flagged revs not working.Apr 2 2021, 10:17 AM
matmarex mentioned this in T273413: Cannot reply to a comment with an external link in section title.Apr 2 2021, 1:26 PM
matmarex mentioned this in T275821: Reply tool does not work for most comments on community wishlist index pages.
hashar added a comment.Apr 2 2021, 1:43 PM

The Special:Export issue has been figured out and confirmed to be fixed on beta. So I have rolled all wikis to 1.36.0-wmf.37 again

[13:42:10] <logmsgbot> !log hashar@deploy1002 rebuilt and synchronized wikiversions files: all wikis to 1.36.0-wmf.37
hashar closed subtask T278579: Special:Export broken: always generates an empty file as Resolved.Apr 2 2021, 1:44 PM
• mmodell closed this task as Resolved.Apr 6 2021, 4:01 PM
tstarling removed a subtask: T278579: Special:Export broken: always generates an empty file.Apr 7 2021, 12:18 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits