Page MenuHomePhabricator

Reply tool does not work for most comments on community wishlist index pages
Closed, ResolvedPublic

Description

Splitting off from T268992#6680158.

Reply tool does not work for most comments on community wishlist index pages, e.g. https://meta.wikimedia.org/wiki/Community_Wishlist_Survey_2021/Citations. (The survey is closed now, so please don't save the changes, but presumably there will be another similar one next year.)

Reply links in the first section work (except the first one); but those in following sections do not (except for nested comments).

image.png (2×3 px, 692 KB)

This weird behavior occurs because the section structure on that index page is different from the sections on the transcluded subpages like https://meta.wikimedia.org/wiki/Community_Wishlist_Survey_2021/Citations/Structuring_of_individual_references (where all reply links work):

  • h2 section headings on the index page are not present on the subpage
  • h3 section headings on the index page have numbers added to their id attributes (which would otherwise be identical), on the subpage they don't

Event Timeline

Change 663906 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/DiscussionTools@master] Introduce comment "names" to identify comments across revisions/pages

https://gerrit.wikimedia.org/r/663906

Change 663906 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@master] Introduce comment "names" to identify comments across revisions/pages

https://gerrit.wikimedia.org/r/663906

matmarex added a project: Editing QA.
matmarex moved this task from Code Review to QA on the Editing-team (FY2021-22 Kanban Board) board.

(accidentally closed due to Phabricator misfeature, re-opening for QA)

@matmarex: This is still happening on that page on Meta wiki. Shouldn't this be fixed with the wmf.37 rollout?

wmf.37 was undeployed, see https://lists.wikimedia.org/pipermail/wikitech-l/2021-April/094406.html for the notice and T278343 for current status. We should re-check after it's deployed again.

@matmarex: I tested this before the wmf.37 rollback (I check the special:version page first before testing) and also, it's not working now either.

I'm sorry, you're right, this is not fixed. I assumed it would be, but I didn't test it. I'm really sorry for wasting your time!

I think it would have worked if it wasn't for patch 7ad6328223579b6c1141aa3d0431dc6ea6edea30. I forgot we've made that change.

Change 677657 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@master] Include comment names in 'transcludedfrom' API response

https://gerrit.wikimedia.org/r/677657

This patch will actually fix the issue. I made a reduced test case and tested it locally, here's a demo as well: https://patchdemo.wmflabs.org/wikis/179220305e/wiki/Talk:T275821

Change 677657 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Include comment names in 'transcludedfrom' API response

https://gerrit.wikimedia.org/r/677657