https://meta.wikimedia.org/wiki/Community_Wishlist_Survey_2021/Citations?dtenable=1 et al is a simple transclusion list of sub pages and so should be supported by DT, however I get an error whenever I try to load the tool on the main index page. The tool loads fine from the sub pages.
Description
Details
Related Objects
Event Timeline
The transclusions include a wikitext newline after the template, so DiscussionTools doesn't recognize them (we only handle simple transclusions).
I wonder if this might be fixed by https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/+/634672 or one of the related patches?
@matmarex Would adding an empty <div></div> to Community Wishlist Survey/Proposal header (its part that’s displayed on category pages) work this issue around? Every hour DT works on these pages is worth it.
@Arlolra and @cscott are reviewing https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/+/637887 and that will fix this problem.
Maybe, I have no idea. Adding or removing some line breaks may also help. I don't really want to experiment with this myself since I don't want to somehow break the bot that maintains the wishlist pages.
(After an edit conflict)
Apparently it didn’t work out. :(
Couldn’t it be backported? There are plenty of free places in the calendar currently.
>>>! In T268992#6657174, @ssastry wrote:
But, this won't be live till the next train rollout -- so next Thu at the earliest.
Couldn’t it be backported? There are plenty of free places in the calendar currently.
It is still under review. So, once it is merged and we run a round of rt testing, we could do that. But, it is still at least a day or two away.
I see it’s not yet merged. But even a Thursday backport is six days earlier than the next week’s train (the train should arrive at Meta on Wednesday, not Thursday).
Change 637887 had a related patch set uploaded (by Subramanya Sastry; owner: Subramanya Sastry):
[mediawiki/services/parsoid@master] Redo template-section boundary conflict code
Change 637887 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Redo template-section boundary conflict code
This week's train has been rolled back so we cannot swat this out today. This will roll out with the train next week at this point.
Change 646892 had a related patch set uploaded (by Subramanya Sastry; owner: Subramanya Sastry):
[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.13.0-a19
Change 646892 merged by jenkins-bot:
[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.13.0-a19
Change 646771 had a related patch set uploaded (by C. Scott Ananian; owner: Subramanya Sastry):
[mediawiki/vendor@wmf/1.36.0-wmf.21] Bump wikimedia/parsoid to 0.13.0-a19
Change 646771 merged by jenkins-bot:
[mediawiki/vendor@wmf/1.36.0-wmf.21] Bump wikimedia/parsoid to 0.13.0-a19
The fixes are now live on metawiki. I see that https://meta.wikimedia.org/wiki/Community_Wishlist_Survey_2021/Citations?dtenable=1 now shows reply links.
For the record, it showed reply links before, they just did not work (they'd show an error in a popup).
Now… some of them work, but others still don't. Specifically, only the first "Voting" and "Discussion" sections work (they open the reply widget when clicked); all other reply links still display an error when clicked. It seems related to how we identify the section in which you're replying.
We might want to make another task for this? The issue with sections and transclusions is definitely fixed, this just uncovered another one.
Ah, okay ... misunderstood that then.
We might want to make another task for this? The issue with sections and transclusions is definitely fixed, this just uncovered another one.
Yes, a separate task with some info about what the issues are.