Page MenuHomePhabricator

Some edits made by extended confirmed users are no longer automatically accepted
Open, HighPublic

Description

I am an extended confirmed user editor on Wikipedia. On Michael Rosen, which is pending changes protected, my 8 Feb edit https://en.wikipedia.org/w/index.php?title=Michael_Rosen&type=revision&diff=1005571365&oldid=1005008162 was automatically accepted, but those of 19 Feb were not e.g. (the first one) https://en.wikipedia.org/w/index.php?title=Michael_Rosen&type=revision&diff=1007735566&oldid=1007730996. The edit history shows the issue more clearly: https://en.wikipedia.org/w/index.php?title=Michael_Rosen&action=history
I have not had this problem before.
The issue is the same for all pending changes protected articles which I have subsequently edited e.g.
https://en.wikipedia.org/w/index.php?title=2008_Mumbai_attacks&action=history
I can continue to edit articles which are not pending change protected as before, included those with extended protection and extended confirmed protection.

STEPS TO REPRODUCE
  1. Find an article with pending changes protection ([[Category:Wikipedia_pending_changes_protected_pages]])
  2. Click on Edit
  3. Change something
  4. Click on Submit changes
ACTUAL RESULTS

The edit appears in the edit history as a pending edit with the notice “pending review”. The edit is not made to the article until it is accepted by a pending changes reviewer.

EXPECTED RESULTS

The edit is automatically accepted.

Additional details

I use Microsoft Windows and Chrome on a desktop. The issue is the same on Firefox.

Event Timeline

Urbanecm renamed this task from Am an extended confirmed editor on Wikipedia but my edits of articles with pending changes protection are no longer automatically accepted to Some edits made by extended confirmed users at en.wikipedia are no longer automatically accepted.Feb 21 2021, 9:08 PM
Urbanecm added a project: Regression.

Change 666587 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/extensions/FlaggedRevs@master] Run setup from MediaWikiServices hook.

https://gerrit.wikimedia.org/r/666587

Reporting an additional incident of this bug. enwiki user DiamondIIIXX came into #wikipedia-en-help tonight and inquired about Pending Changes rights issues. We determined that he was having a similar issue as is described in this bug.

Below are some diffs that were caught by Pending Changes, but should not have been.

https://en.wikipedia.org/w/index.php?title=Steve_Smith_(cricketer)&oldid=1009560175
https://en.wikipedia.org/w/index.php?title=List_of_stadiums_by_capacity&diff=prev&oldid=1009397562

Ladsgroup renamed this task from Some edits made by extended confirmed users at en.wikipedia are no longer automatically accepted to Some edits made by extended confirmed users are no longer automatically accepted.Mar 1 2021, 9:22 PM

There is also discussion (with more examples) at https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)#Pending_Changes_again . For the record, in my opinion, this problem warrants prompt action, but since there are other issues (including the code for this being apparently abandoned), that might be more complicated than we think. Cheers,

There is also discussion (with more examples) at https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)#Pending_Changes_again . For the record, in my opinion, this problem warrants prompt action, but since there are other issues (including the code for this being apparently abandoned), that might be more complicated than we think. Cheers,

I've left a comment at dewiki, but apparently they are not experiencing this kind of issue... [https://de.wikipedia.org/w/index.php?title=Wikipedia%3ATechnik%2FWerkstatt&type=revision&diff=209523517&oldid=209523120] Odd.

It seems like T233561 may be related/the same issue?

@RandomCanadian: Also happens on dewiki.

Thanks for the information. Likely the same issue; then.

Some users on the enwiki thread suggest it might be better to ditch the current implementation of "pending changes" and restart from scratch, if there's nobody who can fix the current issues.

Since the problem occurs randomly, could this be database replication lag?

I have done some work on this extension (e.g. using new icons for it) but the code is +15K lines of convoluted mess which most of it is not enabled in production at all. I have a rather medium-term vision to hollow out the extension. Started making some patches which also gives me better understanding of its internals. It also reimplemented significant parts of mediawiki core which I'm trying to just reuse core. Let's see how it goes...

Change 666587 merged by jenkins-bot:

[mediawiki/extensions/FlaggedRevs@master] Run setup from MediaWikiServices hook.

https://gerrit.wikimedia.org/r/666587