Page MenuHomePhabricator

[wmf.38-regression] mobile VE - "oo-ui-icon-close" button does not work
Open, Needs TriagePublicBUG REPORT

Description

Steps to Reproduce:

  1. On mobile on wikis in groups 0 and 1 (e.g. testwikior cawiki) open an article in VE.
  2. Click on the X button to close the VE mode.

Actual Results:
Clicking on the button does not do anything.

Notes:

  • the button works when a user is in the source editing mode
  • The X button works on wikis in group 2
  • betalabs also has this issue

Event Timeline

Change 677907 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] Revert incorrect changes to ve.ui.MWBackCommand that made it stop working

https://gerrit.wikimedia.org/r/677907

Change 677907 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Revert incorrect changes to ve.ui.MWBackCommand that made it stop working

https://gerrit.wikimedia.org/r/677907

Works in betalabs now. Will it be scheduled for backporting?

Change 677725 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@wmf/1.36.0-wmf.38] Revert incorrect changes to ve.ui.MWBackCommand that made it stop working

https://gerrit.wikimedia.org/r/677725

Change 677725 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@wmf/1.36.0-wmf.38] Revert incorrect changes to ve.ui.MWBackCommand that made it stop working

https://gerrit.wikimedia.org/r/677725

Mentioned in SAL (#wikimedia-operations) [2021-04-08T18:29:42Z] <urbanecm@deploy1002> Synchronized php-1.36.0-wmf.38/extensions/VisualEditor/modules/ve-mw/ui/tools/ve.ui.MWBackTool.js: e0f3735f6a31d2914bae6c9daac1267707a2d108: Revert incorrect changes to ve.ui.MWBackCommand that made it stop working (T279613) (duration: 01m 07s)

And thank you for noticing this @Etonkovidova!

You're welvome! Checked in wmf.38 - now it is working as expected.