Maniphest T280352

Use radio buttons rather than checkboxes
Closed, ResolvedPublic
Actions

Description

In T280150#7003815, @MMiller_WMF wrote:

[...]

For the following options, we want to make them into radio buttons with two options, instead of checkboxes:

Where to post questions on help desk? Options: "Top of page", "Bottom of page".

Where should questions from help panel be directed? Options: "Mentors", "Help desk"

Enable mentorship features? Options: "Yes", "No".

We'll likely need to decouple validation from UI definition (right now, both comes from the validator class).

Details

	Subject	Repo	Branch	Lines +/-
	Special:EditGrowthConfig: Use radio buttons rather than checkboxes	mediawiki/extensions/GrowthExperiments	master	+39 -5

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Trizek-WMF	T246939 [Growth scaling] streamlined configuration
		Resolved		Urbanecm_WMF	T282986 Add description field on NewcomerTasksInfo special page
		Resolved		Urbanecm_WMF	T274520 Move Growth configuration to on-wiki JSON file
		Resolved		Urbanecm_WMF	T274031 Provide custom editing interface for GrowthExperiments on-wiki configuration
		Resolved		Urbanecm_WMF	T280352 Use radio buttons rather than checkboxes

Event Timeline

Urbanecm_WMF created this task.Apr 16 2021, 12:42 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 16 2021, 12:42 PM

Urbanecm_WMF mentioned this in T280150: Test the on-wiki configuration editor.Apr 16 2021, 12:43 PM

Change 681124 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] Special:EditGrowthConfig: Use radio buttons rather than checkboxes

https://gerrit.wikimedia.org/r/681124

gerritbot added a project: Patch-For-Review.Apr 19 2021, 4:29 PM

Urbanecm_WMF triaged this task as Medium priority.Apr 19 2021, 4:30 PM

Urbanecm_WMF moved this task from Incoming to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.

Urbanecm_WMF moved this task from Backlog to In review on the User-Urbanecm_WMF (Engineering) board.

Change 681124 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Special:EditGrowthConfig: Use radio buttons rather than checkboxes

https://gerrit.wikimedia.org/r/681124

@Etonkovidova Hello, moving this to QA. Special:EditGrowthConfig now should not have any checkboxes.

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.3; 2021-04-27).Apr 26 2021, 12:00 AM

Maintenance_bot removed a project: Patch-For-Review.Apr 26 2021, 12:10 AM

Urbanecm_WMF moved this task from In review to My Part Done on the User-Urbanecm_WMF (Engineering) board.Apr 26 2021, 10:04 AM

Urbanecm_WMF closed this task as Resolved.May 14 2021, 2:01 PM

Urbanecm_WMF edited projects, added GrowthExperiments-EditGrowthConfig; removed GrowthExperiments.Aug 3 2021, 11:02 PM