One concern with the phrase matching approach T261398: Add a link engineering: Prototype the recommended link plugin in VisualEditor using phrase matching approach we've used for mapping link recommendations from the [link recommendation service]() to context items in VisualEditor is that wrapped entities may not get found in the VisualEditor document (see T267695: Add a link in VE: handle span-wrapped entities and annotations when finding link recommendation phrases for some examples – for example we might be searching for German cuisine but <i>German</i> cuisine is in VisualEditor).
We will be instrumenting how often phrase are not found in production via T278487: Instrumentation: Number of phrases not found in document, but before we go live with this feature it would be useful to do some QA with our target wikis.
Proposed test:
- Visit 10 link-recommendation tasks on each target wikis beta instance
- take note of how many instances there are where the number of expected phrases to be found doesn't match the actual of RecommendedLinkContextItems shown in the VisualEditor document.
- for example, if the phrase café is in the article text, and the list of recommendations from the service includes a recommendation with the link text of café, but the the word café is not highlighted in blue with the robot icon in the VisualEditor document, then that is a problem.
We might want to wait for T278487: Instrumentation: Number of phrases not found in document, because we could for example output in the console when expected/actual doesn't match, to simplify the job for QA.
