| • mewoph | |
| Apr 19 2021, 4:17 PM |
| F34439223: image.png | |
| May 3 2021, 6:46 PM |
| F34439269: image.png | |
| May 3 2021, 6:46 PM |
| F34407700: Screen Shot 2021-04-19 at 9.15.05 AM.png | |
| Apr 19 2021, 4:17 PM |
List of steps to reproduce:
What happens?:
Help panel button appears on top of the link inspector.
What should have happened instead?:
Help panel button should not be shown.
Change 681126 had a related patch set uploaded (by MewOphaswongse; author: MewOphaswongse):
[mediawiki/extensions/GrowthExperiments@master] Add a link: always suppress help panel CTA
Change 681126 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Add a link: always suppress help panel CTA
Re-opening - need Design Review.
Disabling Help panel button has the following effects (the issues are related to mobile only. I compare the behavior with `testwiki):
Yes, this is as expected.
- discarding the link inspector won't bring the Help panel into the surface
I think this is fine since the expected behaviour on mobile is meant to be that link inspector cannot be dismissed, so this is not an issue once that bigger bug is resolved.
- if a user switches to Source editing mode, the Help panel is also absent.
That is fine too, since the structured link task is not available in Source editing. However, I thought we were not shouldn't be allowing users to switch to Source editor in the initial release in the first place without the warning per T269653. @mewoph and @kostajh - should we file a new ticket to remove this?
Thanks, @RHo for the answers!
I've added the two points below (with your comments) to my list of the issues to monitor.
- discarding the link inspector won't bring the Help panel into the surface
- if a user switches to Source editing mode, the Help panel is also absent.
Thanks @Etonkovidova - on this second point, I think we would have the help panel load but without the SE quick tips screen like so:
@MMiller_WMF - do you think we may want to instead keep the same behaviour as other Suggested edits when the user does switch to source editor, whereby the help panel is now visible as a floating button and has a notice at the top of quick tips letting the user know that they need to switch to the different editor mode as per the example in the Copyedit case (though we would of course need to change the copy to "switch to Machine suggested mode"):
Given this is a temporary exception case, we could also ignore it and go with the help panel showing without the SE tips screen.
@RHo -- I think your first suggestion, with the disclaimer, is best. But I think we would want the disclaimer to read like, "You are using the source editor. To return to reviewing suggestions, switch editing modes."
But I am also okay with just showing without the SE tips screen.
@mewoph -- could you please tell us which of the two ideas above you prefer? We want the easiest route for now.
Change 684818 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):
[mediawiki/extensions/GrowthExperiments@master] AddLink: Hide SwitchEditor panel for machineSuggestions mode
I think we should pick this up again when T269653: Add a link: edit mode toggle (machine suggestions & visual) is being done. For now, we don't show "Edit source" and we don't allow the user to switch away from machineSuggestions mode to visual edit mode. I've pushed a patch to hide the switch editor panel when the user is in machine suggestions mode.
Change 684821 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):
[schemas/event/secondary@master] helppanel: Add machineSuggestion as valid editor_interface
Change 684821 merged by jenkins-bot:
[schemas/event/secondary@master] helppanel: Add machineSuggestion as valid editor_interface
Change 684818 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] HelpPanel: Allow setting preferredEditor per task-type handler