Remove Skin::getRevisionId, Skin::isRevisionCurrent
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

These methods were moved to OutputPage
They were deprecated in 1.34. They can safely be removed, as I see no known usages.

https://codesearch.wmcloud.org/search/?q=isRevisionCurrent&i=nope&files=&excludeFiles=&repos=
https://codesearch.wmcloud.org/search/?q=getRevisionId&i=nope&files=&excludeFiles=&repos=

TODO

Two functions are removed from Skin (the OutputPage methods remain untouched)
Release notes have been updated

Details

	Subject	Repo	Branch	Lines +/-
	Remove Skin::getRevisionId, Skin::isRevisionCurrent	mediawiki/core	master	+4 -24

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Jdlrobson	T282045 [GOAL] Deprecate and remove skin code in preparation for 1.37
		Resolved		Jdlrobson	T280613 Remove Skin::getRevisionId, Skin::isRevisionCurrent

Event Timeline

Jdlrobson created this task.Apr 20 2021, 12:43 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 20 2021, 12:43 AM

Jdlrobson added a project: Web-Team-Backlog.May 5 2021, 7:12 PM

Jdlrobson added a parent task: T282045: [GOAL] Deprecate and remove skin code in preparation for 1.37.

Jdlrobson assigned this task to ovasileva.May 5 2021, 7:14 PM

Jdlrobson moved this task from Incoming to Needs Prioritization on the Web-Team-Backlog board.

ovasileva triaged this task as Medium priority.May 10 2021, 2:47 PM

ovasileva moved this task from Needs Prioritization to Triaged but Future on the Web-Team-Backlog board.

Jdlrobson updated the task description. (Show Details)Jun 11 2021, 9:09 PM

Jdlrobson moved this task from Triaged but Future to unsed on the Web-Team-Backlog board.

Jdlrobson removed ovasileva as the assignee of this task.Jun 11 2021, 9:12 PM

Jdlrobson moved this task from unsed to Triaged but Future on the Web-Team-Backlog board.

Jdlrobson moved this task from Triaged but Future to unsed on the Web-Team-Backlog board.

Jdlrobson added a subscriber: ovasileva.

Jdlrobson updated the task description. (Show Details)Jun 23 2021, 10:09 PM

Jdlrobson moved this task from unsed to Kanbanana-FY-2020-21 on the Web-Team-Backlog board.

Jdlrobson edited projects, added Web-Team-Backlog (Kanbanana-FY-2020-21); removed Web-Team-Backlog.

Jdlrobson moved this task from Needs Analysis to Upcoming on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.

LGoto set the point value for this task to 2.Jun 29 2021, 5:42 PM

LGoto moved this task from Upcoming to Ready for Development on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.

DannyS712 moved this task from Blocker to To deprecate or remove on the MW-1.37-release board.Jul 7 2021, 10:22 PM

cjming claimed this task.Jul 14 2021, 11:04 PM

cjming moved this task from Ready for Development to Doing on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.

Change 704860 had a related patch set uploaded (by Clare Ming; author: Clare Ming):

[mediawiki/core@master] Remove Skin::getRevisionId, Skin::isRevisionCurrent

https://gerrit.wikimedia.org/r/704860

gerritbot added a project: Patch-For-Review.Jul 15 2021, 7:53 PM

cjming removed cjming as the assignee of this task.Jul 15 2021, 7:55 PM

cjming moved this task from Doing to Code Review on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.

cjming subscribed.

cjming moved this task from Code Review to Ready for Signoff on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.Jul 15 2021, 8:18 PM

Change 704860 merged by jenkins-bot:

[mediawiki/core@master] Remove Skin::getRevisionId, Skin::isRevisionCurrent

https://gerrit.wikimedia.org/r/704860

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.15; 2021-07-19).Jul 15 2021, 9:00 PM

Maintenance_bot removed a project: Patch-For-Review.Jul 15 2021, 9:10 PM

LGoto assigned this task to Jdlrobson.Jul 19 2021, 5:31 PM

Reedy renamed this task from Remove Skin::getRevisionId, Skin::isRevisionCurrent to Remove Skin::getRevisionId, Skin::isRevisionCurrent.Jul 19 2021, 5:32 PM

Jdlrobson closed this task as Resolved.Jul 20 2021, 4:19 PM

Jdlrobson updated the task description. (Show Details)

Remove Skin::getRevisionId, Skin::isRevisionCurrentClosed, ResolvedPublic2 Estimated Story PointsActions