Page MenuHomePhabricator

Remove Skin::getRevisionId, Skin::isRevisionCurrent
Closed, ResolvedPublic2 Estimated Story Points

Description

These methods were moved to OutputPage
They were deprecated in 1.34. They can safely be removed, as I see no known usages.

https://codesearch.wmcloud.org/search/?q=isRevisionCurrent&i=nope&files=&excludeFiles=&repos=
https://codesearch.wmcloud.org/search/?q=getRevisionId&i=nope&files=&excludeFiles=&repos=

TODO

  • Two functions are removed from Skin (the OutputPage methods remain untouched)
  • Release notes have been updated

Event Timeline

Jdlrobson moved this task from unsed to Triaged but Future on the Readers-Web-Backlog board.
Jdlrobson moved this task from Triaged but Future to unsed on the Readers-Web-Backlog board.
Jdlrobson added a subscriber: ovasileva.

Change 704860 had a related patch set uploaded (by Clare Ming; author: Clare Ming):

[mediawiki/core@master] Remove Skin::getRevisionId, Skin::isRevisionCurrent

https://gerrit.wikimedia.org/r/704860

cjming added a subscriber: cjming.

Change 704860 merged by jenkins-bot:

[mediawiki/core@master] Remove Skin::getRevisionId, Skin::isRevisionCurrent

https://gerrit.wikimedia.org/r/704860

Reedy renamed this task from Remove Skin::getRevisionId, Skin::isRevisionCurrent to Remove Skin::getRevisionId, Skin::isRevisionCurrent.Jul 19 2021, 5:32 PM
Jdlrobson updated the task description. (Show Details)