Page MenuHomePhabricator

Wikisource OCR: Add version number to tool
Closed, ResolvedPublic2 Estimated Story Points

Description

Currently, it is difficult to know what version of the Wikisource OCR tool we are using.

We could add the version number somewhere on the tool's page (e.g. in the footer like T271780).

This would be very helpful for testing, so I know I am testing the correct version.

Event Timeline

Restricted Application added a subscriber: Aklapper. ยท View Herald TranscriptApr 26 2021, 8:29 AM
MusikAnimal subscribed.

PR: https://github.com/wikimedia/wikimedia-ocr/pull/20

I went ahead and added a link to create a bug report, too. I assume at some point the whole UI may get a design makeover, so the copy and appearance is subject to change.

MusikAnimal set the point value for this task to 2.Apr 27 2021, 5:18 PM

I'd put this at around 2 points. I mostly copied what we did in our other apps.

QA notes: There is no version number yet so this shows up as just the SHA at https://ocr-test.wmcloud.org/. The link is broken and for instance goes to https://github.com/wikimedia/wikimedia-ocr/releases/tag/1e8a0fb when it should be https://github.com/wikimedia/wikimedia-ocr/tree/1e8a0fb. In order to fix this, we need a change to ToolforgeBundle to better handle situations where there is no tagged release, since it currently fallsback to returning the SHA instead of the tag. I'll look into this, but for now we can consider that a separate issue. The link won't be broken in production since there we will only show version numbers. Similar issue with WS Export's staging vs. production.

QA notes: There is no version number yet so this shows up as just the SHA at https://ocr-test.wmcloud.org/. The link is broken...

No problem, the SHA is all I need. Thanks for doing this.