When hovering a page preview in mobile view (a.k.a. the Minerva skin) I get a slightly cut of setting cogwheel.
Description
Description
Details
Details
Subject | Repo | Branch | Lines +/- | |
---|---|---|---|---|
Fix settings cog wheel being cut off on mobile | mediawiki/extensions/Popups | master | +7 -0 |
Related Objects
Related Objects
Event Timeline
Comment Actions
First investigation: Page previews are enabled on mobile since T236097: Dev: Popups modules should set targets to mobile and desktop. So the fact that we end here is intentional. The icon might have been broken because of some CSS optimizations we did while working on ReferencePreviews. I did a quick git bisect and found:
- The icon is broken ever since the very first patch https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Popups/+/571465/ (April 2020, T236097). However, it looked different back then. It was cut off on the bottom instead.
- With patch https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Popups/+/636710 (November 2020, T256504) the icon changed. Since then it's cut off on the left.
Both patches are unrelated to Reference Previews.
Comment Actions
Change 683549 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/Popups@master] Fix settings cog wheel being cut off on mobile
Comment Actions
Change 683549 merged by jenkins-bot:
[mediawiki/extensions/Popups@master] Fix settings cog wheel being cut off on mobile