Page MenuHomePhabricator

PHP Deprecated: Use of User::isIP was deprecated in MediaWiki 1.35. [Called from ApiVisualEditor::execute]
Closed, ResolvedPublicPRODUCTION ERROR

Description

Error
normalized_message
[{reqId}] {exception_url}   PHP Deprecated: Use of User::isIP was deprecated in MediaWiki 1.35. [Called from ApiVisualEditor::execute]
exception.trace
from /srv/mediawiki/php-1.37.0-wmf.3/extensions/VisualEditor/includes/ApiVisualEditor.php(410)
#0 [internal function]: MWExceptionHandler::handleError(integer, string, string, string, array)
#1 /srv/mediawiki/php-1.37.0-wmf.3/includes/debug/MWDebug.php(376): trigger_error(string, integer)
#2 /srv/mediawiki/php-1.37.0-wmf.3/includes/debug/MWDebug.php(352): MWDebug::sendRawDeprecated(string, boolean, string)
#3 /srv/mediawiki/php-1.37.0-wmf.3/includes/debug/MWDebug.php(230): MWDebug::deprecatedMsg(string, string, string, integer)
#4 /srv/mediawiki/php-1.37.0-wmf.3/includes/GlobalFunctions.php(1036): MWDebug::deprecated(string, string, string, integer)
#5 /srv/mediawiki/php-1.37.0-wmf.3/includes/user/User.php(984): wfDeprecated(string, string)
#6 /srv/mediawiki/php-1.37.0-wmf.3/extensions/VisualEditor/includes/ApiVisualEditor.php(410): User::isIP(string)
#7 /srv/mediawiki/php-1.37.0-wmf.3/includes/api/ApiMain.php(1668): ApiVisualEditor->execute()
#8 /srv/mediawiki/php-1.37.0-wmf.3/includes/api/ApiMain.php(638): ApiMain->executeAction()
#9 /srv/mediawiki/php-1.37.0-wmf.3/includes/api/ApiMain.php(609): ApiMain->executeActionWithErrorHandling()
#10 /srv/mediawiki/php-1.37.0-wmf.3/api.php(90): ApiMain->execute()
#11 /srv/mediawiki/php-1.37.0-wmf.3/api.php(45): wfApiMain()
#12 /srv/mediawiki/w/api.php(3): require(string)
#13 {main}
Impact
  • New for wmf.3
  • 18 messages from group0 only in 24 hours
Notes

Details

Request URL
https://www.mediawiki.org/w/api.php?action=visualeditor&format=*&paction=*&page=*&uselang=*&formatversion=*

Event Timeline

Pchelolo added a subscriber: Pchelolo.

Not a train blocker, just a deprecation. Will handle before next train branch cut.

Adding as blocker for next train per previous discussion with Platform Engineering folks

Change 683392 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/VisualEditor@master] ApiVisualEditor: remove call to deprecated User::isIP

https://gerrit.wikimedia.org/r/683392

Pchelolo added a subscriber: Vlad.shapik.

Adding as blocker for next train per previous discussion with Platform Engineering folks

Amazing. I love this process already! :)

Change 683392 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] ApiVisualEditor: remove call to deprecated User::isIP

https://gerrit.wikimedia.org/r/683392

Is this resolved? All patches are merged.

It's marked as blocking this weeks train.

Is there any reason this is still marked as a train blocker?

Unmarking as blocker; please re-add if I'm mistaken.

Pchelolo claimed this task.

This was added as a NEXT train blocker since it's a deprecation warning and after fixing it, we forgot to resolve the ticket. It is resolved.