Page MenuHomePhabricator
Create Task
Maniphest T281401

PHP Deprecated: Use of User::isIP was deprecated in MediaWiki 1.35. [Called from ApiVisualEditor::execute]
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error
normalized_message
[{reqId}] {exception_url}   PHP Deprecated: Use of User::isIP was deprecated in MediaWiki 1.35. [Called from ApiVisualEditor::execute]
exception.trace
from /srv/mediawiki/php-1.37.0-wmf.3/extensions/VisualEditor/includes/ApiVisualEditor.php(410)
#0 [internal function]: MWExceptionHandler::handleError(integer, string, string, string, array)
#1 /srv/mediawiki/php-1.37.0-wmf.3/includes/debug/MWDebug.php(376): trigger_error(string, integer)
#2 /srv/mediawiki/php-1.37.0-wmf.3/includes/debug/MWDebug.php(352): MWDebug::sendRawDeprecated(string, boolean, string)
#3 /srv/mediawiki/php-1.37.0-wmf.3/includes/debug/MWDebug.php(230): MWDebug::deprecatedMsg(string, string, string, integer)
#4 /srv/mediawiki/php-1.37.0-wmf.3/includes/GlobalFunctions.php(1036): MWDebug::deprecated(string, string, string, integer)
#5 /srv/mediawiki/php-1.37.0-wmf.3/includes/user/User.php(984): wfDeprecated(string, string)
#6 /srv/mediawiki/php-1.37.0-wmf.3/extensions/VisualEditor/includes/ApiVisualEditor.php(410): User::isIP(string)
#7 /srv/mediawiki/php-1.37.0-wmf.3/includes/api/ApiMain.php(1668): ApiVisualEditor->execute()
#8 /srv/mediawiki/php-1.37.0-wmf.3/includes/api/ApiMain.php(638): ApiMain->executeAction()
#9 /srv/mediawiki/php-1.37.0-wmf.3/includes/api/ApiMain.php(609): ApiMain->executeActionWithErrorHandling()
#10 /srv/mediawiki/php-1.37.0-wmf.3/api.php(90): ApiMain->execute()
#11 /srv/mediawiki/php-1.37.0-wmf.3/api.php(45): wfApiMain()
#12 /srv/mediawiki/w/api.php(3): require(string)
#13 {main}
Impact
  • New for wmf.3
  • 18 messages from group0 only in 24 hours
Notes

Details

Request URL
https://www.mediawiki.org/w/api.php?action=visualeditor&format=*&paction=*&page=*&uselang=*&formatversion=*
SubjectRepoBranchLines +/-
ApiVisualEditor: remove call to deprecated User::isIPmediawiki/extensions/VisualEditormaster+1 -1
Customize query in gerrit

Event Timeline

thcipriani created this task.Apr 28 2021, 6:47 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 28 2021, 6:47 PM
thcipriani added a parent task: T281145: 1.37.0-wmf.4 deployment blockers.Apr 28 2021, 6:48 PM
• Pchelolo assigned this task to Vlad.shapik.Apr 28 2021, 6:48 PM
• Pchelolo edited projects, added Platform Team Workboards (MW Expedition); removed Platform Team Workboards (Clinic Duty Team).
• Pchelolo subscribed.

Not a train blocker, just a deprecation. Will handle before next train branch cut.

thcipriani added a comment.Apr 28 2021, 6:49 PM

Adding as blocker for next train per previous discussion with Platform Engineering folks

gerritbot added a comment.Apr 28 2021, 6:49 PM

Change 683392 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/VisualEditor@master] ApiVisualEditor: remove call to deprecated User::isIP

https://gerrit.wikimedia.org/r/683392

gerritbot added a project: Patch-For-Review.Apr 28 2021, 6:49 PM
• Pchelolo removed Vlad.shapik as the assignee of this task.Apr 28 2021, 6:50 PM
• Pchelolo added a subscriber: Vlad.shapik.
In T281401#7043157, @thcipriani wrote:

Adding as blocker for next train per previous discussion with Platform Engineering folks

Amazing. I love this process already! :)

Krinkle moved this task from Untriaged to Apr 2021 on the Wikimedia-production-error board.Apr 28 2021, 6:51 PM
gerritbot added a comment.Apr 28 2021, 7:44 PM

Change 683392 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] ApiVisualEditor: remove call to deprecated User::isIP

https://gerrit.wikimedia.org/r/683392

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.4; 2021-05-04).Apr 28 2021, 8:00 PM
Maintenance_bot removed a project: Patch-For-Review.Apr 28 2021, 8:10 PM
Agusbou2015 subscribed.May 5 2021, 2:37 AM
RhinosF1 subscribed.May 5 2021, 3:27 PM

Is this resolved? All patches are merged.

It's marked as blocking this weeks train.

brennen subscribed.May 5 2021, 3:29 PM

Is there any reason this is still marked as a train blocker?

brennen removed a parent task: T281145: 1.37.0-wmf.4 deployment blockers.May 5 2021, 3:45 PM

Unmarking as blocker; please re-add if I'm mistaken.

• Pchelolo closed this task as Resolved.May 5 2021, 4:34 PM
• Pchelolo claimed this task.

This was added as a NEXT train blocker since it's a deprecation warning and after fixing it, we forgot to resolve the ticket. It is resolved.

DannyS712 claimed this task.May 5 2021, 4:42 PM
Restricted Application added a project: User-DannyS712. · View Herald TranscriptMay 5 2021, 4:42 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits