Maniphest T281991

extensions/OATHAuth - use AbstractAuthenticationProvider ::init, ::postInitSetup instead of the setters of AbstractAuthenticationProvider
Closed, ResolvedPublic
Actions

Description

Provided that the following methods are used only in tests, all usages of deprecated AbstractAuthenticationProvider ::setLogger, ::setManager, ::setConfig, ::setHookContainer methods must be replaced with AbstractAuthenticationProvider::init.
If it's overridden AbstractAuthenticationProvider::setConfig or AbstractAuthenticationProvider ::setLogger, ::setManager, ::setConfig, ::setHookContainer are used outside the test codebase of the extension, so replace it with AbstractAuthenticationProvider::postInitSetup to do any necessary setup.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Replace uses of the deprecated setters of AbstractAuthenticationProvider	mediawiki/extensions/OATHAuth	master	+14 -9

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Vlad.shapik	T281174 Use AbstractAuthenticationProvider ::init, ::postInitSetup instead of the setters of AbstractAuthenticationProvider in extensions
		Resolved		Vlad.shapik	T281991 extensions/OATHAuth - use AbstractAuthenticationProvider ::init, ::postInitSetup instead of the setters of AbstractAuthenticationProvider

Event Timeline

Vlad.shapik created this task.May 5 2021, 2:51 PM

Vlad.shapik triaged this task as Medium priority.

Vlad.shapik updated the task description. (Show Details)May 5 2021, 4:05 PM

Change 685797 had a related patch set uploaded (by Vlad.shapik; author: Vlad.shapik):

[mediawiki/extensions/OATHAuth@master] Hard deprecate the setters of AbstractAuthenticationProvider class

https://gerrit.wikimedia.org/r/685797

gerritbot added a project: Patch-For-Review.May 6 2021, 1:39 PM

@Vlad.shapik for future reference for these tasks and patches, they are for *replacing uses of the methods* in the different extensions, so the methods can be hard deprecated in core, and should be named accordingly - its confusing to see tasks and patches saying hard deprecate the methods in a bunch of extensions

In T281991#7066160, @DannyS712 wrote:

@Vlad.shapik for future reference for these tasks and patches, they are for *replacing uses of the methods* in the different extensions, so the methods can be hard deprecated in core, and should be named accordingly - its confusing to see tasks and patches saying hard deprecate the methods in a bunch of extensions

Got it . Will edit

Vlad.shapik renamed this task from extensions/OATHAuth - hard deprecate the setters of AbstractAuthenticationProvider class to extensions/OATHAuth - use AbstractAuthenticationProvider ::init, ::postInitSetup instead of the setters of AbstractAuthenticationProvider.May 6 2021, 2:52 PM

Vlad.shapik moved this task from Unsorted pile to Waiting for Review on the Platform Team Workboards (MW Expedition) board.May 7 2021, 11:23 AM

Zabe mentioned this in T282778: OATHAuth Phan throws PhanUndeclaredMethod Call to undeclared method \MediaWiki\Auth\SecondaryAuthenticationProvider::setLogger.May 13 2021, 10:55 AM

Vlad.shapik closed this task as Resolved.May 13 2021, 2:36 PM

Change 685797 merged by jenkins-bot:

[mediawiki/extensions/OATHAuth@master] Replace uses of the deprecated setters of AbstractAuthenticationProvider

https://gerrit.wikimedia.org/r/685797

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.6; 2021-05-18).May 13 2021, 4:00 PM

Maintenance_bot removed a project: Patch-For-Review.May 13 2021, 4:11 PM