Page MenuHomePhabricator

extensions/OATHAuth - use AbstractAuthenticationProvider ::init, ::postInitSetup instead of the setters of AbstractAuthenticationProvider
Closed, ResolvedPublic

Description

  1. Provided that the following methods are used only in tests, all usages of deprecated AbstractAuthenticationProvider ::setLogger, ::setManager, ::setConfig, ::setHookContainer methods must be replaced with AbstractAuthenticationProvider::init.
  2. If it's overridden AbstractAuthenticationProvider::setConfig or AbstractAuthenticationProvider ::setLogger, ::setManager, ::setConfig, ::setHookContainer are used outside the test codebase of the extension, so replace it with AbstractAuthenticationProvider::postInitSetup to do any necessary setup.

Event Timeline

Vlad.shapik triaged this task as Medium priority.May 5 2021, 2:51 PM
Vlad.shapik created this task.

Change 685797 had a related patch set uploaded (by Vlad.shapik; author: Vlad.shapik):

[mediawiki/extensions/OATHAuth@master] Hard deprecate the setters of AbstractAuthenticationProvider class

https://gerrit.wikimedia.org/r/685797

@Vlad.shapik for future reference for these tasks and patches, they are for *replacing uses of the methods* in the different extensions, so the methods can be hard deprecated in core, and should be named accordingly - its confusing to see tasks and patches saying hard deprecate the methods in a bunch of extensions

@Vlad.shapik for future reference for these tasks and patches, they are for *replacing uses of the methods* in the different extensions, so the methods can be hard deprecated in core, and should be named accordingly - its confusing to see tasks and patches saying hard deprecate the methods in a bunch of extensions

Got it . Will edit

Vlad.shapik renamed this task from extensions/OATHAuth - hard deprecate the setters of AbstractAuthenticationProvider class to extensions/OATHAuth - use AbstractAuthenticationProvider ::init, ::postInitSetup instead of the setters of AbstractAuthenticationProvider.May 6 2021, 2:52 PM

Change 685797 merged by jenkins-bot:

[mediawiki/extensions/OATHAuth@master] Replace uses of the deprecated setters of AbstractAuthenticationProvider

https://gerrit.wikimedia.org/r/685797