Page MenuHomePhabricator

Move 'Privacy policy' link to another line in navigation
Closed, ResolvedPublic0 Estimated Story Points

Description

Description

For languages where the "About Wikipedia" and/or "Disclaimers" links are longer strings, the second link can be quite close to the edge of the menu, or even clipped. Example: Russian Wikipedia

image.png (1×640 px, 210 KB)

Platform: iOS
Model: 5se
Browser: Google Chrome

Notes

one possible solution: it seems that if we make the <ul> element a flexbox, and add flex-wrap: wrap to it, the links will be on one line if they are short enough, and two lines if they are longer:

Screen Shot 2021-07-15 at 3.06.09 PM.png (719×1 px, 311 KB)

QA Results - Beta

ACStatusDetails
1T282314#7549986

QA Results - Prod

ACStatusDetails
1T282314#7550002

Event Timeline

ovasileva triaged this task as Medium priority.May 10 2021, 2:26 PM
ovasileva added a project: Web-Team-Backlog.
ovasileva moved this task from Incoming to Triaged but Future on the Web-Team-Backlog board.
ovasileva added a subscriber: alexhollender_WMF.
LGoto subscribed.

This task was closed as part of backlog upkeep. If you believe it was closed in error, please respond on the ticket.

stjn edited projects, added Web-Team-Backlog (Tracking); removed Web-Team-Backlog.
stjn subscribed.

Reverting undiscussed silent close. Visual bug that still needs to be fixed.

thanks for pointing this out @Iniquity, and for re-opening the task @stjn.

one possible solution: it seems that if we make the <ul> element a flexbox, and add flex-wrap: wrap to it, the links will be on one line if they are short enough, and two lines if they are longer:

Screen Shot 2021-07-15 at 3.06.09 PM.png (719×1 px, 311 KB)

Thanks for the opportunity.

There are few ways to fix this problem.

  1. Setting the font-size of class "hlist" as 0.9rem in the corresponding CSS file
ul.hlist{
 font-size:0.9rem;
}

WikiMedia.jpg (1×1 px, 369 KB)

  1. Using class "hlist", providing display method as flexbox and setting flex-direction as column.
ul.hlist{
 display:flex;
 flex-direction: column;
}

WikiMedia01.jpg (1×1 px, 367 KB)

@Dazzlerkumar note the hlist styles are loaded by core, so I'd recommend using .toggle-list__list .hlist to style this element. Flexbox (solution 2) seems like the better solution here.

Hi @Jdlrobson , I can fix this using my solution 2 with you recommendation to use `.hlist`` class as child class of ` .toggle-list__list``. Let me know the further steps.

Sounds good! @Dazzlerkumar please post a patch to Gerrit and add me and i"ll happily test and review it.

@Jdlrobson Hello, this is my first contribution to wikimedia. Thus I cannot find the repo of the above page on Gerrit. Please help me out!

Unassigning @Dazzlerkumar due to lack of activity. Patch still very welcome :)

GPR subscribed.

Hello, I already have patch for this in my local git repo. Just need to figure it out how to submit it out for now.

Change 736764 had a related patch set uploaded (by GPR; author: GPR):

[mediawiki/skins/MinervaNeue@master] Change disclaimer link container to flex box

https://gerrit.wikimedia.org/r/736764

@GPR yay! Glad you figured that out. Adding this to our review queue. You should have a review within next 2 days (hopefully today!).

Jdlrobson set the point value for this task to 9.
Jdlrobson changed the point value for this task from 9 to 0.

Change 736764 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Change disclaimer link container to flex box

https://gerrit.wikimedia.org/r/736764

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Monterey
Browser: Chrome
Device: MBP
Emulated Device:iPhone 11 Max Pro, Responsive

Test Artifact(s):

QA Steps

✅ AC1: Verify "About Wikipedia" and "Disclaimers" are not truncated or are displayed on two lines in languages where the text is long:

Screen Shot 2021-12-06 at 7.27.48 AM.png (830×404 px, 54 KB)

Screen Shot 2021-12-06 at 7.26.09 AM.png (996×412 px, 47 KB)

Screen Shot 2021-12-06 at 7.25.06 AM.png (996×412 px, 82 KB)

Screen Shot 2021-12-06 at 7.26.49 AM.png (996×412 px, 56 KB)

Screen Shot 2021-12-06 at 7.25.54 AM.png (996×412 px, 53 KB)

Screen Shot 2021-12-06 at 7.25.19 AM.png (996×412 px, 80 KB)

Edtadros subscribed.

Test Result - Prod

Status: ✅ PASS
Environment: Prod
OS: macOS Monterey
Browser: Chrome
Device: MBP
Emulated Device:iPhone 11 Max Pro, Responsive

Test Artifact(s):

QA Steps

✅ AC1: Verify "About Wikipedia" and "Disclaimers" are not truncated or are displayed on two lines in languages where the text is long:

Screen Shot 2021-12-06 at 7.32.51 AM.png (1×457 px, 65 KB)

Screen Shot 2021-12-06 at 7.32.35 AM.png (823×414 px, 66 KB)

Screen Shot 2021-12-06 at 7.33.05 AM.png (1×667 px, 125 KB)

All done, looks good!