Page MenuHomePhabricator

Bug: Escaping issue in language switching button
Closed, ResolvedPublic

Description

Background

Found as a part of QA in T280526#7040745

Steps to reproduce

Go to https://en.wikipedia.org/wiki/Boy_Bitten_by_a_Lizard?uselang=fr

Expected:
Language button should appear in French

Observed:

Screen Shot 2021-05-11 at 1.58.12 PM.png (812×2 px, 615 KB)

Note: also observed if display language is set directly from the settings in the ULS

QA Results - Beta

ACStatusDetails
1T282540#7115815

QA Results - Prod

ACStatusDetails
1T282540#7134360

Event Timeline

ovasileva updated the task description. (Show Details)
Jdlrobson subscribed.

Fix should be an easy one. In SkinVector::createULSLanguageButton use escape rather than parse.

Change 693880 had a related patch set uploaded (by Jdrewniak; author: Jdrewniak):

[mediawiki/skins/Vector@master] Use escape() instead of parse() in SkinVector::createULSLanguageButton

https://gerrit.wikimedia.org/r/693880

Change 693880 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Use escaped() instead of parse() in SkinVector::createULSLanguageButton

https://gerrit.wikimedia.org/r/693880

Edtadros subscribed.

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

✅ AC1: Change the language of a page using the "uselang" parameter and observe that the language button changes language.

Screen Shot 2021-05-26 at 6.26.45 AM.png (456×1 px, 119 KB)

Screen Shot 2021-05-26 at 6.27.10 AM.png (448×1 px, 123 KB)

Test Result - Prod

Status: ✅ PASS
Environment: enwiki
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

✅ AC1: Change the language of a page using the "uselang" parameter and observe that the language button changes language.

Screen Shot 2021-06-04 at 6.59.42 AM.png (284×855 px, 50 KB)

Screen Shot 2021-06-04 at 7.00.11 AM.png (298×854 px, 55 KB)