Page MenuHomePhabricator

Add parameter that allows language button to be seen across all wikis
Closed, ResolvedPublic2 Estimated Story Points

Description

Background

We would like to flag potential issues on the pilot wikis for the desktop improvements project with the new language button. One way to do this would be to add a parameter that shows the language button across all wikis

Acceptance criteria

  • explore adding a parameter that shows the language button across all wikis regardless of whether the A/B test is enabled

Notes

  • There's already a check for a query parameter in the Vector\FeatureManagement\Requirements\LanguageInHeaderTreatmentRequirement::isMet() method but it's dependent on a check for whether the A/B test is enabled. The former needs to be independent of the latter.

QA

  1. Go to https://en.wikipedia.beta.wmflabs.org/wiki/Dog?languageinheader=0
  2. Verify that the language list shows up in the sidebar
  1. Go to https://en.wikipedia.beta.wmflabs.org/wiki/Dog?languageinheader=1
  2. Verify that the language list shows up in the content header (next to "Dog")

QA Results - Beta

ACStatusDetails
1T282543#7099728
2T282543#7099728

QA Results - Prod

Event Timeline

I believe that this is already done. Add languageinheader=1 to the query string.

I believe that this is already done. Add languageinheader=1 to the query string.

Is there any way we can get it to work if the feature's not available on a wiki yet?

I think the main use case here is getting the button to show on https://fr.wikipedia.org/wiki/Paris for QA prior to deployment

Change 690620 had a related patch set uploaded (by Nray; author: Nray):

[mediawiki/skins/Vector@master] Allow `languageinheader` query param to fully control treatment of languages

https://gerrit.wikimedia.org/r/690620

nray removed nray as the assignee of this task.May 13 2021, 6:03 PM
nray added a subscriber: nray.

Change 690620 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Allow `languageinheader` query param to fully control treatment of languages

https://gerrit.wikimedia.org/r/690620

Change 692075 had a related patch set uploaded (by Nray; author: Nray):

[mediawiki/skins/Vector@wmf/1.37.0-wmf.5] Allow `languageinheader` query param to fully control treatment of languages

https://gerrit.wikimedia.org/r/692075

Change 692075 merged by jenkins-bot:

[mediawiki/skins/Vector@wmf/1.37.0-wmf.5] Allow `languageinheader` query param to fully control treatment of languages

https://gerrit.wikimedia.org/r/692075

Mentioned in SAL (#wikimedia-operations) [2021-05-17T18:27:35Z] <urbanecm@deploy1002> Synchronized php-1.37.0-wmf.5/skins/Vector/includes/FeatureManagement/Requirements/LanguageInHeaderTreatmentRequirement.php: e180b99: Allow languageinheader query param to fully control treatment of languages (T282543) (duration: 00m 58s)

Can confirm parameter is working on pilot wikis, @Edtadros - not sure if any additional testing is needed here. A couple of more notes:

frwiki

fawiki

  • Issues with coordinate templates
  • Other indicators (lock, featured) seem okay

ptwiki

  • Looks okay with all indicators

euwiki

  • Looks okay with all indicators

frwiktionary

hewiki

  • Seems okay with indicators & coordinates
  • Can't find an example that has both

bnwiki

  • Issues with coordinate templates & indicators

dewikivoyage

  • Looking good!

kowiki:

  • Issues with coordinates
  • Indicators are ok

srwiki:

  • Issues with coordinates
  • Indicators ok

trwiki:

  • Issues with coordinates and indicators
  • Language button note appearing at all

vecwiki:

  • Looks okay

@ovasileva you're very thorough! I will test the same wikis with the URL parameters. Beta works.

Status: ✅ PASS
Environment: beta
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

✅ AC1: Go to https://en.wikipedia.beta.wmflabs.org/wiki/Dog?languageinheader=0
Verify that the language list shows up in the sidebar

✅ AC2: Go to https://en.wikipedia.beta.wmflabs.org/wiki/Dog?languageinheader=1
Verify that the language list shows up in the content header (next to "Dog")

Edtadros added a subscriber: Edtadros.

Status: ✅ PASS
Environment: various
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

✅ AC1: Go to a page in each wiki below using the following URL parameter: ?languageinheader=0
Verify that the language list shows up in the sidebar

frwikifawikiptwikieuwikifrwiktionaryhewikibnwikidewikivoyagekowikisrwikitrwikivecwiki

✅ AC2: Go to a page in each wiki below using the following URL parameter: ?languageinheader=1
Verify that the language list shows up in the content header (next to "Dog")

frwikifawikiptwikieuwikifrwiktionaryhewikibnwikidewikivoyagekowikisrwikitrwikivecwiki

@ovasileva your testing was more than enough. I thought I saw some wikis where the new language button wasn't showing up so I decided to test it, but after I finished this I realized it was because it was old vector. Oops.