Add parameter that allows language button to be seen across all wikis
Closed, ResolvedPublic2 Estimated Story Points
Actions

Assigned To

Authored By

	ovasileva
	May 11 2021, 12:11 PM

Project Tags

Referenced Files

	F34460664: Screen Shot 2021-05-19 at 6.10.01 PM.png
	May 20 2021, 1:27 AM

	F34460677: Screen Shot 2021-05-19 at 6.15.07 PM.png
	May 20 2021, 1:27 AM

	F34460682: Screen Shot 2021-05-19 at 6.17.03 PM.png
	May 20 2021, 1:27 AM

	F34460662: Screen Shot 2021-05-19 at 6.09.45 PM.png
	May 20 2021, 1:27 AM

	F34460688: Screen Shot 2021-05-19 at 6.19.49 PM.png
	May 20 2021, 1:27 AM

	F34460645: Screen Shot 2021-05-19 at 6.02.17 PM.png
	May 20 2021, 1:27 AM

	F34460643: Screen Shot 2021-05-19 at 6.01.28 PM.png
	May 20 2021, 1:27 AM

	F34460675: Screen Shot 2021-05-19 at 6.14.55 PM.png
	May 20 2021, 1:27 AM

Subscribers

Description

Background

We would like to flag potential issues on the pilot wikis for the desktop improvements project with the new language button. One way to do this would be to add a parameter that shows the language button across all wikis

Acceptance criteria

explore adding a parameter that shows the language button across all wikis regardless of whether the A/B test is enabled

Notes

There's already a check for a query parameter in the Vector\FeatureManagement\Requirements\LanguageInHeaderTreatmentRequirement::isMet() method but it's dependent on a check for whether the A/B test is enabled. The former needs to be independent of the latter.

QA

Go to https://en.wikipedia.beta.wmflabs.org/wiki/Dog?languageinheader=0
Verify that the language list shows up in the sidebar

Go to https://en.wikipedia.beta.wmflabs.org/wiki/Dog?languageinheader=1
Verify that the language list shows up in the content header (next to "Dog")

QA Results - Beta

AC	Status	Details
1	✅	T282543#7099728
2	✅	T282543#7099728

QA Results - Prod

AC	Status	Details
1	✅	T282543#7098552 T282543#7099757
2	✅	T282543#7098552 T282543#7099757

Details

Related Changes in Gerrit:

	Subject	Author	Repo	Branch	Lines +/-
	Allow `languageinheader` query param to fully control treatment of languages	Nray	mediawiki/skins/Vector	wmf/1.37.0-wmf.5	+36 -5
	Allow `languageinheader` query param to fully control treatment of languages	Nray	mediawiki/skins/Vector	master	+36 -5

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	ovasileva	T275766 Log sessionID, isAnon, editBucketCount, and selectedLanguage properties in the UniversalLanguageSelector instrument
Resolved	ovasileva	T275794 Log time on page before switching language as part of the UniversalLanguageSelector instrument
Resolved	ovasileva	T256023 [EPIC] Improve language switching capabilities
Resolved	ovasileva	T269093 Deploy new language switching location to test wikis and begin A/B test pt 1
Resolved	ovasileva	T282543 Add parameter that allows language button to be seen across all wikis

Event Timeline

ovasileva created this task.May 11 2021, 12:11 PM

Herald added a subscriber: Aklapper. · View Herald TranscriptMay 11 2021, 12:11 PM

ovasileva triaged this task as High priority.May 11 2021, 12:11 PM

I believe that this is already done. Add languageinheader=1 to the query string.

In T282543#7077870, @phuedx wrote:

I believe that this is already done. Add languageinheader=1 to the query string.

Is there any way we can get it to work if the feature's not available on a wiki yet?

phuedx updated the task description. (Show Details)May 11 2021, 1:23 PM

I think the main use case here is getting the button to show on https://fr.wikipedia.org/wiki/Paris for QA prior to deployment

Jdlrobson moved this task from Needs Analysis to Upcoming on the Web-Team-Backlog-Archived (Kanbanana-FY-2020-21) board.May 11 2021, 6:25 PM

ovasileva added a parent task: T269093: Deploy new language switching location to test wikis and begin A/B test pt 1.May 12 2021, 9:07 AM

ovasileva mentioned this in T269093: Deploy new language switching location to test wikis and begin A/B test pt 1.May 12 2021, 9:10 AM

LGoto set the point value for this task to 2.May 12 2021, 4:53 PM

LGoto moved this task from Upcoming to Ready for Development on the Web-Team-Backlog-Archived (Kanbanana-FY-2020-21) board.

• nray claimed this task.May 13 2021, 5:16 PM

• nray moved this task from Ready for Development to Doing on the Web-Team-Backlog-Archived (Kanbanana-FY-2020-21) board.

Change 690620 had a related patch set uploaded (by Nray; author: Nray):

[mediawiki/skins/Vector@master] Allow `languageinheader` query param to fully control treatment of languages

https://gerrit.wikimedia.org/r/690620

gerritbot added a project: Patch-For-Review.May 13 2021, 6:02 PM

• nray removed • nray as the assignee of this task.May 13 2021, 6:03 PM

• nray moved this task from Doing to Code Review on the Web-Team-Backlog-Archived (Kanbanana-FY-2020-21) board.

• nray subscribed.

Jdlrobson assigned this task to Edtadros.May 13 2021, 7:40 PM

Jdlrobson moved this task from Code Review to QA on the Web-Team-Backlog-Archived (Kanbanana-FY-2020-21) board.

Change 690620 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Allow `languageinheader` query param to fully control treatment of languages

https://gerrit.wikimedia.org/r/690620

Maintenance_bot removed a project: Patch-For-Review.May 13 2021, 8:11 PM

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.6; 2021-05-18).May 13 2021, 9:00 PM

• nray updated the task description. (Show Details)May 14 2021, 12:52 AM

ovasileva mentioned this in T282026: Discussion: Unable to quickly add interwiki links via Wikidata’s "Add link" interface.May 17 2021, 3:15 PM

Change 692075 had a related patch set uploaded (by Nray; author: Nray):

[mediawiki/skins/Vector@wmf/1.37.0-wmf.5] Allow `languageinheader` query param to fully control treatment of languages

https://gerrit.wikimedia.org/r/692075

gerritbot added a project: Patch-For-Review.May 17 2021, 3:17 PM

Change 692075 merged by jenkins-bot:

[mediawiki/skins/Vector@wmf/1.37.0-wmf.5] Allow `languageinheader` query param to fully control treatment of languages

https://gerrit.wikimedia.org/r/692075

Mentioned in SAL (#wikimedia-operations) [2021-05-17T18:27:35Z] <urbanecm@deploy1002> Synchronized php-1.37.0-wmf.5/skins/Vector/includes/FeatureManagement/Requirements/LanguageInHeaderTreatmentRequirement.php: rSVECe180b993c6c7: Allow languageinheader query param to fully control treatment of languages (T282543) (duration: 00m 58s)

ReleaseTaggerBot edited projects, added: MW-1.37-notes (1.37.0-wmf.5; 2021-05-11); removed: MW-1.37-notes (1.37.0-wmf.6; 2021-05-18).May 17 2021, 7:00 PM

Maintenance_bot removed a project: Patch-For-Review.May 17 2021, 7:10 PM

Can confirm parameter is working on pilot wikis, @Edtadros - not sure if any additional testing is needed here. A couple of more notes:

frwiki

Coordinates & other indicators are OK
There is an issue with the button itself (tracked in T282540: Bug: Escaping issue in language switching button

Screen Shot 2021-05-19 at 4.51.20 PM.png (2,880×984 px, 653 KB)

fawiki

Issues with coordinate templates
Other indicators (lock, featured) seem okay

Screen Shot 2021-05-19 at 4.58.23 PM.png (2,876×1,524 px, 1 MB)

ptwiki

Looks okay with all indicators

Screen Shot 2021-05-19 at 5.02.25 PM.png (2,876×1,526 px, 1 MB)

euwiki

Looks okay with all indicators

Screen Shot 2021-05-19 at 5.05.59 PM.png (2,878×1,528 px, 1 MB)

frwiktionary

There is an issue with the button itself (tracked in T282540: Bug: Escaping issue in language switching button
all else looks okay

Screen Shot 2021-05-19 at 5.08.02 PM.png (2,880×1,528 px, 632 KB)

hewiki

Seems okay with indicators & coordinates
Can't find an example that has both

Screen Shot 2021-05-19 at 5.10.37 PM.png (2,880×1,530 px, 774 KB)

Screen Shot 2021-05-19 at 5.09.26 PM.png (2,880×1,528 px, 1006 KB)

bnwiki

Issues with coordinate templates & indicators

Screen Shot 2021-05-19 at 5.13.23 PM.png (2,880×1,532 px, 1 MB)

dewikivoyage

Looking good!

Screen Shot 2021-05-19 at 5.18.06 PM.png (2,880×1,526 px, 1 MB)

kowiki:

Issues with coordinates
Indicators are ok

Screen Shot 2021-05-19 at 5.19.59 PM.png (2,880×1,532 px, 1 MB)

srwiki:

Issues with coordinates
Indicators ok

Screen Shot 2021-05-19 at 5.21.57 PM.png (2,880×1,526 px, 1 MB)

trwiki:

Issues with coordinates and indicators
Language button note appearing at all

Screen Shot 2021-05-19 at 5.22.48 PM.png (2,880×1,534 px, 1 MB)

vecwiki:

Looks okay

Screen Shot 2021-05-19 at 5.24.42 PM.png (2,880×1,530 px, 1 MB)

@ovasileva you're very thorough! I will test the same wikis with the URL parameters. Beta works.

Status: ✅ PASS
Environment: beta
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

✅ AC1: Go to https://en.wikipedia.beta.wmflabs.org/wiki/Dog?languageinheader=0
Verify that the language list shows up in the sidebar

Screen Shot 2021-05-19 at 5.50.13 PM.png (1,086×1,163 px, 596 KB)

✅ AC2: Go to https://en.wikipedia.beta.wmflabs.org/wiki/Dog?languageinheader=1
Verify that the language list shows up in the content header (next to "Dog")

Screen Shot 2021-05-19 at 5.50.40 PM.png (1,086×1,163 px, 428 KB)

Edtadros updated the task description. (Show Details)May 20 2021, 12:53 AM

Status: ✅ PASS
Environment: various
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

✅ AC1: Go to a page in each wiki below using the following URL parameter: ?languageinheader=0
Verify that the language list shows up in the sidebar

✅ frwiki	✅ fawiki	✅ ptwiki	✅ euwiki	✅ frwiktionary	✅ hewiki	✅ bnwiki	✅ dewikivoyage	✅ kowiki	✅ srwiki	✅ trwiki	✅ vecwiki

✅ AC2: Go to a page in each wiki below using the following URL parameter: ?languageinheader=1
Verify that the language list shows up in the content header (next to "Dog")

✅ frwiki	✅ fawiki	✅ ptwiki	✅ euwiki	✅ frwiktionary	✅ hewiki	✅ bnwiki	✅ dewikivoyage	✅ kowiki	✅ srwiki	✅ trwiki	✅ vecwiki

@ovasileva your testing was more than enough. I thought I saw some wikis where the new language button wasn't showing up so I decided to test it, but after I finished this I realized it was because it was old vector. Oops.

Edtadros updated the task description. (Show Details)May 20 2021, 1:29 AM

Edtadros mentioned this in T277588: It should be possible to enable the new language button for logged in users.May 20 2021, 1:34 AM

ovasileva closed this task as Resolved.May 21 2021, 8:00 AM

ovasileva mentioned this in T281974: Fix alignment of coordinates and page indicators (Vector 2022).May 24 2021, 5:57 PM

ovasileva mentioned this in T280770: Instrumentation QA for language switching .May 25 2021, 10:04 AM