As text.old_flags isn't indexed this will need a slow scan through the table to look for rows.
Description
Description
Details
Details
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T128149 Remove wgLegacyEncoding feature of Revision/BlobStore | |||
| Open | None | T282734 Provide a maintenance script to migrate old revisions that use wgLegacyEncoding to UTF-8 | |||
| Open | None | T340174 moveToExternal and fixLegacyEncoding scripts are missing some checks for false return values |
Event Timeline
Comment Actions
Isn't this already done with MoveToExternal maint script that @tstarling has written a year ago? I assume the "going over ids part" is not done yet but we can do the query in stats machines, get the ids and feed them to the script if needed.
Comment Actions
It does move them and also clean them but it ignores any row that is external but on legacy encoding, so needs some tweaking.
Comment Actions
Change 927310 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):
[mediawiki/core@master] Add maintenance/storage/fixLegacyEncoding.php
Comment Actions
Change 927310 merged by jenkins-bot:
[mediawiki/core@master] Add maintenance/storage/fixLegacyEncoding.php
Comment Actions
Do we also want to hook this into update.php so we can retire the feature after a release?
Comment Actions
Probably, if $wgLegacyEncoding is set. Also T340174: moveToExternal and fixLegacyEncoding scripts are missing some checks for false return values probably should be resolved?
Comment Actions
Change 963102 had a related patch set uploaded (by Jforrester; author: Jforrester):
[mediawiki/core@master] update.php: Run fixLegacyEncoding, so the old code can finally die