Page MenuHomePhabricator
Create Task
Maniphest T282833

MapSourcesPage.php: PHP Notice: Undefined offset: 13
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error
normalized_message
[{reqId}] {exception_url}   PHP Notice: Undefined offset: 13
exception.trace
from /srv/mediawiki/php-1.37.0-wmf.5/extensions/MapSources/includes/specials/MapSourcesPage.php(256)
#0 /srv/mediawiki/php-1.37.0-wmf.5/extensions/MapSources/includes/specials/MapSourcesPage.php(256): MWExceptionHandler::handleError(integer, string, string, integer, array)
#1 /srv/mediawiki/php-1.37.0-wmf.5/extensions/MapSources/includes/specials/MapSourcesPage.php(343): MapSourcesPage->setScales()
#2 /srv/mediawiki/php-1.37.0-wmf.5/extensions/MapSources/includes/specials/MapSourcesPage.php(74): MapSourcesPage->getParams(NULL)
#3 /srv/mediawiki/php-1.37.0-wmf.5/includes/specialpage/SpecialPage.php(646): MapSourcesPage->execute(NULL)
#4 /srv/mediawiki/php-1.37.0-wmf.5/includes/specialpage/SpecialPageFactory.php(1396): SpecialPage->run(NULL)
#5 /srv/mediawiki/php-1.37.0-wmf.5/includes/MediaWiki.php(313): MediaWiki\SpecialPage\SpecialPageFactory->executePath(string, RequestContext)
#6 /srv/mediawiki/php-1.37.0-wmf.5/includes/MediaWiki.php(916): MediaWiki->performRequest()
#7 /srv/mediawiki/php-1.37.0-wmf.5/includes/MediaWiki.php(550): MediaWiki->main()
#8 /srv/mediawiki/php-1.37.0-wmf.5/index.php(53): MediaWiki->run()
#9 /srv/mediawiki/php-1.37.0-wmf.5/index.php(46): wfIndexMain()
#10 /srv/mediawiki/w/index.php(3): require(string)
#11 {main}
Notes

New in wmf.5.

Details

Request URL
https://en.wikivoyage.org/w/index.php?title=*&params=*&locname=*&uselang=*
Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Check array boundaries before accessing arraymediawiki/extensions/MapSourceswmf/1.37.0-wmf.5+1 -1
Check array boundaries before accessing arraymediawiki/extensions/MapSourcesmaster+1 -1
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedReleasedancyT281146 1.37.0-wmf.5 deployment blockers
 ResolvedPRODUCTION ERROR• PcheloloT282833 MapSourcesPage.php: PHP Notice: Undefined offset: 13

Event Timeline

dancy created this task.May 13 2021, 9:33 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 13 2021, 9:33 PM
dancy added a parent task: T281146: 1.37.0-wmf.5 deployment blockers.May 13 2021, 9:34 PM
dancy renamed this task from PHP Notice: Undefined offset: 13 to MapSourcesPage.php: PHP Notice: Undefined offset: 13.May 13 2021, 10:02 PM
dancy triaged this task as Unbreak Now! priority.May 13 2021, 11:39 PM
dancy mentioned this in T281146: 1.37.0-wmf.5 deployment blockers.
Jdforrester-WMF subscribed.May 14 2021, 1:06 AM

Also happening in wmf.4. Config issue?

gerritbot added a comment.May 14 2021, 1:18 AM

Change 690792 had a related patch set uploaded (by Ppchelko; author: Ppchelko):

[mediawiki/extensions/MapSources@master] Check array boundaries before accessing array

https://gerrit.wikimedia.org/r/690792

gerritbot added a project: Patch-For-Review.May 14 2021, 1:18 AM
• Pchelolo subscribed.May 14 2021, 1:18 AM

I don't know why it started happening, but the fix above should take care of the out of array bounds issue..

gerritbot added a comment.May 14 2021, 2:43 AM

Change 690792 merged by jenkins-bot:

[mediawiki/extensions/MapSources@master] Check array boundaries before accessing array

https://gerrit.wikimedia.org/r/690792

gerritbot added a comment.May 14 2021, 2:45 AM

Change 690809 had a related patch set uploaded (by Jforrester; author: Ppchelko):

[mediawiki/extensions/MapSources@wmf/1.37.0-wmf.5] Check array boundaries before accessing array

https://gerrit.wikimedia.org/r/690809

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.6; 2021-05-18).May 14 2021, 3:00 AM
gerritbot added a comment.May 14 2021, 3:09 AM

Change 690809 merged by jenkins-bot:

[mediawiki/extensions/MapSources@wmf/1.37.0-wmf.5] Check array boundaries before accessing array

https://gerrit.wikimedia.org/r/690809

Maintenance_bot removed a project: Patch-For-Review.May 14 2021, 3:10 AM
Stashbot added a comment.May 14 2021, 3:25 AM

Mentioned in SAL (#wikimedia-operations) [2021-05-14T03:25:02Z] <tstarling@deploy1002> Synchronized php-1.37.0-wmf.5/extensions/MapSources/includes/specials/MapSourcesPage.php: fix PHP notice T282833 (duration: 01m 07s)

Jdforrester-WMF closed this task as Resolved.May 14 2021, 3:26 AM
Jdforrester-WMF assigned this task to • Pchelolo.
tstarling subscribed.May 14 2021, 3:29 AM

Should be fixed in wmf.5. I'm not closing it because there was no wmf.4 backport. But we can wait for the train to fix it.

Jdforrester-WMF added a comment.May 14 2021, 3:32 AM
In T282833#7087276, @tstarling wrote:

Should be fixed in wmf.5. I'm not closing it because there was no wmf.4 backport. But we can wait for the train to fix it.

Oh, right. This was marginal as a blocker in the first place.

ReleaseTaggerBot edited projects, added MW-1.37-notes (1.37.0-wmf.5; 2021-05-11); removed MW-1.37-notes (1.37.0-wmf.6; 2021-05-18).May 14 2021, 4:00 AM
Krinkle moved this task from Untriaged to May 2021 on the Wikimedia-production-error board.Jun 12 2021, 5:43 PM
Krinkle mentioned this in Blog Post: Production Excellence #32: May 2021.Jun 21 2021, 1:31 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits