The content-links feature includes a very specific rule that does not belong there relating to the #p-personal menu that seems to exist only for the Vector skin:
https://github.com/wikimedia/mediawiki/blob/master/resources/src/mediawiki.skinning/content.links.less#L7
In Vector, a designer has requested that we disable the red link color in this menu T276561#7070166 - this is a skin-level decision and skins should not have to create overly specific selectors to do that kind of thing (see T282254).
It is proposed that styles scoped to #p-personal a.new are dropped from the content-links feature and that we update skins to not require this rule.
Changes
- Update required in CologneBlue - it uses #quickbar span.new a rather than #quickbar .new a to achieve the same goal
- Update required in Vector to copy across the rule
- Remove the rule in core.
Benefits
Apart from giving more control to the skin, this fixes a bug with Monobook which does not style red links consistently (currently the red link in personal tools is inconsistent with the rest of the page)
QA
- login as a user with no user page (use a new account if not sure)
- On https://en.wikipedia.beta.wmflabs.org/wiki/Main_Page?useskinversion=1 cnfirm the link in the top right is red:
QA Results - Beta
| AC | Status | Details |
|---|---|---|
| 1 | ✅ | T282884#7160064 |
QA Results - Prod
| AC | Status | Details |
|---|---|---|
| 1 | ✅ | T282884#7163689 |
