Page MenuHomePhabricator

Clean-up slow TwoColConflict browser tests suite
Closed, ResolvedPublic1 Estimated Story Points

Description

There are quite a lot test cases and these all take a pretty long time to run. That's why they got removed from gated extensions via https://gerrit.wikimedia.org/r/690887

Let's try to clean up the tests to make the whole suite faster. Then we could think about re-adding them to gate and submit.

See also the original discussion and request in T234002#7084538.

Event Timeline

Change 690887 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Ladsgroup):

[integration/config@master] Temporary remove TwoColConflict from gated extensions

https://gerrit.wikimedia.org/r/690887

Change 690887 merged by jenkins-bot:

[integration/config@master] Zuul: Temporarily remove TwoColConflict from gated extensions

https://gerrit.wikimedia.org/r/690887

Mentioned in SAL (#wikimedia-releng) [2021-05-15T18:38:55Z] <James_F> Zuul: Temporarily remove TwoColConflict from gated extensions T234002 T282935.

Change 749537 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/TwoColConflict@master] [selenium] Merge and clean up collapse browser tests

https://gerrit.wikimedia.org/r/749537

Change 749539 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/TwoColConflict@master] [selenium] Merge some save and preview browser tests

https://gerrit.wikimedia.org/r/749539

Change 749555 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/TwoColConflict@master] [selenium] Merge some talk page browser tests

https://gerrit.wikimedia.org/r/749555

Change 749560 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/TwoColConflict@master] [selenium] Remove some useless tests

https://gerrit.wikimedia.org/r/749560

Change 749562 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/TwoColConflict@master] [selenium] Merge some editmerge tests

https://gerrit.wikimedia.org/r/749562

Change 749560 merged by jenkins-bot:

[mediawiki/extensions/TwoColConflict@master] [selenium] Remove some useless tests

https://gerrit.wikimedia.org/r/749560

Change 749537 merged by jenkins-bot:

[mediawiki/extensions/TwoColConflict@master] [selenium] Merge and clean up collapse browser tests

https://gerrit.wikimedia.org/r/749537

Change 749562 merged by jenkins-bot:

[mediawiki/extensions/TwoColConflict@master] [selenium] Merge some editmerge tests

https://gerrit.wikimedia.org/r/749562

Change 749539 merged by jenkins-bot:

[mediawiki/extensions/TwoColConflict@master] [selenium] Merge some save and preview browser tests

https://gerrit.wikimedia.org/r/749539

Change 749555 merged by jenkins-bot:

[mediawiki/extensions/TwoColConflict@master] [selenium] Merge some talk page browser tests

https://gerrit.wikimedia.org/r/749555

WMDE-Fisch renamed this task from Fix slow browser tests (7 minutes?) and re-add them to gate to Clean-up slow TwoColConflict browser tests suite.Jan 19 2022, 10:01 AM
WMDE-Fisch updated the task description. (Show Details)

I think there's a bit more potential in cleaning up, but for now the patches above

  • reduced the number of test from 46 to 35
  • the runtime of the selenium daily went from ~23min to ~16min ( note that this includes the slow beta cluster as test target and is not comparable with the ~7min mentioned in the original ticket title )
  • the effective runtime of the suite in the CI ( excluding setup ) is ~2:45min ( that's comparable to the ~7min mentioned ) \o/
WMDE-Fisch claimed this task.

For now this iteration of clean-up in these tests is done. From local testing there might be even more movement, when upgrading to to node12 libs but I'm currently not sure if this is supposed to happen automatically or not. At least I would say it's not for this ticket. So closing now.

Re-adding these tests to gate should be discussed somewhere else.