Page MenuHomePhabricator
Create Task
Maniphest T282935

Clean-up slow TwoColConflict browser tests suite
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

There are quite a lot test cases and these all take a pretty long time to run. That's why they got removed from gated extensions via https://gerrit.wikimedia.org/r/690887

Let's try to clean up the tests to make the whole suite faster. Then we could think about re-adding them to gate and submit.

See also the original discussion and request in T234002#7084538.

Details

SubjectRepoBranchLines +/-
[selenium] Merge some talk page browser testsmediawiki/extensions/TwoColConflictmaster+44 -80
[selenium] Merge some save and preview browser testsmediawiki/extensions/TwoColConflictmaster+33 -83
[selenium] Merge some editmerge testsmediawiki/extensions/TwoColConflictmaster+177 -178
[selenium] Merge and clean up collapse browser testsmediawiki/extensions/TwoColConflictmaster+65 -104
[selenium] Remove some useless testsmediawiki/extensions/TwoColConflictmaster+0 -40
Zuul: Temporarily remove TwoColConflict from gated extensionsintegration/configmaster+0 -2
Customize query in gerrit

Related Objects

Event Timeline

thiemowmde created this task.May 15 2021, 10:29 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 15 2021, 10:29 AM
gerritbot added a comment.May 15 2021, 10:29 AM

Change 690887 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Ladsgroup):

[integration/config@master] Temporary remove TwoColConflict from gated extensions

https://gerrit.wikimedia.org/r/690887

gerritbot added a project: Patch-For-Review.May 15 2021, 10:29 AM
gerritbot added a comment.May 15 2021, 6:37 PM

Change 690887 merged by jenkins-bot:

[integration/config@master] Zuul: Temporarily remove TwoColConflict from gated extensions

https://gerrit.wikimedia.org/r/690887

Stashbot mentioned this in T234002: Make MediaWiki Wdio tests less slow (Sept 2019).May 15 2021, 6:38 PM

Mentioned in SAL (#wikimedia-releng) [2021-05-15T18:38:55Z] <James_F> Zuul: Temporarily remove TwoColConflict from gated extensions T234002 T282935.

Maintenance_bot removed a project: Patch-For-Review.May 15 2021, 7:10 PM
WMDE-Fisch mentioned this in T283139: Only receive mails for failing selenium daily tests when test fail in a row.May 19 2021, 8:32 AM
WMDE-Fisch moved this task from Incoming to Backlog on the WMDE-TechWish-Maintenance board.Dec 7 2021, 2:28 PM
WMDE-Fisch claimed this task.Dec 22 2021, 11:32 AM
WMDE-Fisch moved this task from Backlog to In progress on the WMDE-TechWish-Maintenance board.
WMDE-Fisch added a project: WMDE-TechWish-XMAS-Sprint-2021-12-15.
gerritbot added a comment.Dec 22 2021, 1:28 PM

Change 749537 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/TwoColConflict@master] [selenium] Merge and clean up collapse browser tests

https://gerrit.wikimedia.org/r/749537

gerritbot added a project: Patch-For-Review.Dec 22 2021, 1:28 PM
thiemowmde moved this task from Sprint Backlog to Doing on the WMDE-TechWish-XMAS-Sprint-2021-12-15 board.Dec 22 2021, 2:06 PM
gerritbot added a comment.Dec 22 2021, 2:26 PM

Change 749539 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/TwoColConflict@master] [selenium] Merge some save and preview browser tests

https://gerrit.wikimedia.org/r/749539

gerritbot added a comment.Dec 22 2021, 4:21 PM

Change 749555 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/TwoColConflict@master] [selenium] Merge some talk page browser tests

https://gerrit.wikimedia.org/r/749555

gerritbot added a comment.Dec 22 2021, 4:32 PM

Change 749560 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/TwoColConflict@master] [selenium] Remove some useless tests

https://gerrit.wikimedia.org/r/749560

gerritbot added a comment.Dec 22 2021, 5:37 PM

Change 749562 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/TwoColConflict@master] [selenium] Merge some editmerge tests

https://gerrit.wikimedia.org/r/749562

thiemowmde removed WMDE-Fisch as the assignee of this task.Jan 3 2022, 1:53 PM
thiemowmde moved this task from Doing to Sprint Backlog on the WMDE-TechWish-XMAS-Sprint-2021-12-15 board.
gerritbot added a comment.Jan 11 2022, 11:23 AM

Change 749560 merged by jenkins-bot:

[mediawiki/extensions/TwoColConflict@master] [selenium] Remove some useless tests

https://gerrit.wikimedia.org/r/749560

WMDE-Fisch mentioned this in rESCCa8f49f4e8856: [selenium] Remove some useless tests.Jan 11 2022, 11:51 AM
ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.18; 2022-01-17).Jan 11 2022, 12:00 PM
gerritbot added a comment.Jan 17 2022, 5:22 PM

Change 749537 merged by jenkins-bot:

[mediawiki/extensions/TwoColConflict@master] [selenium] Merge and clean up collapse browser tests

https://gerrit.wikimedia.org/r/749537

WMDE-Fisch mentioned this in rESCCac2c449c48c2: [selenium] Merge and clean up collapse browser tests.Jan 17 2022, 5:24 PM
WMDE-Fisch added a project: WMDE-TechWish-Sprint-2022-01-05.Jan 18 2022, 8:41 AM
WMDE-Fisch moved this task from Sprint Backlog to Tech Review on the WMDE-TechWish-Sprint-2022-01-05 board.
gerritbot added a comment.Jan 18 2022, 1:06 PM

Change 749562 merged by jenkins-bot:

[mediawiki/extensions/TwoColConflict@master] [selenium] Merge some editmerge tests

https://gerrit.wikimedia.org/r/749562

WMDE-Fisch mentioned this in rESCC4435750b1de3: [selenium] Merge some editmerge tests.Jan 18 2022, 1:06 PM
gerritbot added a comment.Jan 18 2022, 1:32 PM

Change 749539 merged by jenkins-bot:

[mediawiki/extensions/TwoColConflict@master] [selenium] Merge some save and preview browser tests

https://gerrit.wikimedia.org/r/749539

WMDE-Fisch mentioned this in rESCC718a17056611: [selenium] Merge some save and preview browser tests.Jan 18 2022, 1:34 PM
ReleaseTaggerBot edited projects, added MW-1.38-notes (1.38.0-wmf.19; 2022-01-24); removed MW-1.38-notes (1.38.0-wmf.18; 2022-01-17).Jan 18 2022, 2:00 PM
gerritbot added a comment.Jan 19 2022, 8:18 AM

Change 749555 merged by jenkins-bot:

[mediawiki/extensions/TwoColConflict@master] [selenium] Merge some talk page browser tests

https://gerrit.wikimedia.org/r/749555

WMDE-Fisch mentioned this in rESCC51c3fe2c32fc: [selenium] Merge some talk page browser tests.Jan 19 2022, 8:19 AM
WMDE-Fisch set the point value for this task to 1.Jan 19 2022, 9:12 AM
WMDE-Fisch added a project: WMDE-TechWish-Sprint-2022-01-19.
Lena_WMDE moved this task from Sprint Backlog to Tech Review on the WMDE-TechWish-Sprint-2022-01-19 board.Jan 19 2022, 9:13 AM
Lena_WMDE moved this task from Tech Review to Sprint Backlog on the WMDE-TechWish-Sprint-2022-01-19 board.
WMDE-Fisch renamed this task from Fix slow browser tests (7 minutes?) and re-add them to gate to Clean-up slow TwoColConflict browser tests suite.Jan 19 2022, 10:01 AM
WMDE-Fisch updated the task description. (Show Details)
WMDE-Fisch added a comment.EditedJan 19 2022, 10:17 AM

I think there's a bit more potential in cleaning up, but for now the patches above

  • reduced the number of test from 46 to 35
  • the runtime of the selenium daily went from ~23min to ~16min ( note that this includes the slow beta cluster as test target and is not comparable with the ~7min mentioned in the original ticket title )
  • the effective runtime of the suite in the CI ( excluding setup ) is ~2:45min ( that's comparable to the ~7min mentioned ) \o/
WMDE-Fisch moved this task from Sprint Backlog to Demo on the WMDE-TechWish-Sprint-2022-01-19 board.Jan 20 2022, 1:58 PM
thiemowmde added a project: Performance Issue.Jan 20 2022, 3:45 PM
WMDE-Fisch moved this task from Demo to Done on the WMDE-TechWish-Sprint-2022-01-19 board.Feb 1 2022, 9:08 AM
WMDE-Fisch removed a project: Patch-For-Review.Feb 1 2022, 12:34 PM
WMDE-Fisch closed this task as Resolved.Feb 3 2022, 9:58 AM
WMDE-Fisch claimed this task.

For now this iteration of clean-up in these tests is done. From local testing there might be even more movement, when upgrading to to node12 libs but I'm currently not sure if this is supposed to happen automatically or not. At least I would say it's not for this ticket. So closing now.

Re-adding these tests to gate should be discussed somewhere else.

WMDE-Fisch mentioned this in T338793: Condense AdvancedSearch browser tests suite.Jun 12 2023, 1:55 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits